From: Akhil Goyal <akhil.goyal@nxp.com>
To: Tejasree Kondoj <ktejasree@marvell.com>,
Radu Nicolau <radu.nicolau@intel.com>
Cc: Narayana Prasad Raju Athreya <pathreya@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities
Date: Thu, 2 Jul 2020 10:36:22 +0000 [thread overview]
Message-ID: <VI1PR04MB3168E7F35544E1CD2C61AEEBE66D0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MN2PR18MB2974761810A2ACB5DAE14CA2A86D0@MN2PR18MB2974.namprd18.prod.outlook.com>
> > > +static const struct rte_cryptodev_capabilities *
> > > +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps) {
> > > + SEC_CAPS_ADD(hw_caps, aes);
> > > +
> > > + sec_caps_add(caps_end, RTE_DIM(caps_end));
> > > +
> > > + return otx2_cpt_sec_caps;
> > > +}
> > SEC_CAPS_ADD should be called earlier when the security context is created
> > Or where all other capabilities of the PMD are initialized.
> > It should not be added when capabilities need to be retrieved.
> > As of now you are supporting only AES-GCM, but in future if you add more
> > algos, Then it would be difficult to manage.
> [Tejasree] We will initialize capabilities during probe and capabilities_get()
> would return pointer. Would that work?
Yes, I think so.
next prev parent reply other threads:[~2020-07-02 10:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 12:12 [dpdk-dev] [PATCH 0/8] add OCTEON TX2 lookaside IPsec support Tejasree Kondoj
2020-06-23 12:12 ` [dpdk-dev] [PATCH 1/8] net/octeontx2: move otx2_sec_session struct to otx2_security.h Tejasree Kondoj
2020-06-23 12:12 ` [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions Tejasree Kondoj
2020-07-01 20:46 ` Akhil Goyal
2020-07-02 9:29 ` Anoob Joseph
2020-07-02 9:38 ` Akhil Goyal
2020-07-02 10:00 ` Anoob Joseph
2020-07-02 10:40 ` Akhil Goyal
2020-06-23 12:12 ` [dpdk-dev] [PATCH 3/8] crypto/octeontx2: add cryptodev sec registration Tejasree Kondoj
2020-07-01 20:59 ` Akhil Goyal
2020-07-02 10:26 ` Tejasree Kondoj
2020-06-23 12:12 ` [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities Tejasree Kondoj
2020-07-01 21:07 ` Akhil Goyal
2020-07-02 10:32 ` Tejasree Kondoj
2020-07-02 10:36 ` Akhil Goyal [this message]
2020-06-23 12:12 ` [dpdk-dev] [PATCH 5/8] crypto/octeontx2: add cryptodev sec misc callbacks Tejasree Kondoj
2020-06-23 12:12 ` [dpdk-dev] [PATCH 6/8] crypto/octeontx2: add cryptodev sec session create Tejasree Kondoj
2020-06-23 12:12 ` [dpdk-dev] [PATCH 7/8] crypto/octeontx2: add cryptodev sec enqueue routine Tejasree Kondoj
2020-06-23 12:12 ` [dpdk-dev] [PATCH 8/8] crypto/octeontx2: add cryptodev sec dequeue routine Tejasree Kondoj
2020-07-01 20:54 ` [dpdk-dev] [PATCH 0/8] add OCTEON TX2 lookaside IPsec support Akhil Goyal
2020-07-02 10:23 ` Tejasree Kondoj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB3168E7F35544E1CD2C61AEEBE66D0@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=ktejasree@marvell.com \
--cc=pathreya@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).