From: Matan Azrad <matan@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] bus/vdev: fix scope of device list lock
Date: Mon, 21 May 2018 17:28:52 +0000 [thread overview]
Message-ID: <VI1PR0501MB26080120741BDB73593E6897D2950@VI1PR0501MB2608.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180521164544.26421-1-thomas@monjalon.net>
From: Thomas Monjalon
> The lock vdev_device_list_lock was taken before calling "remove" function for
> the device.
> So it prevents to remove sub-devices (as in failsafe) inside its own "remove"
> function, because of a deadlock.
>
> The lock is now only protecting the device list inside the bus driver.
>
> Fixes: 35f462839b69 ("bus/vdev: add lock on device list")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Matan Azrad <matan@mellanox.com>
next prev parent reply other threads:[~2018-05-21 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 16:11 [dpdk-dev] [PATCH] bus/vdev: reduce " Thomas Monjalon
2018-05-21 16:45 ` [dpdk-dev] [PATCH v2] bus/vdev: fix " Thomas Monjalon
2018-05-21 17:28 ` Matan Azrad [this message]
2018-05-22 9:11 ` Gaëtan Rivet
2018-05-22 9:05 ` [dpdk-dev] [PATCH] bus/vdev: reduce " Burakov, Anatoly
2018-05-22 9:20 ` Thomas Monjalon
2018-05-22 11:37 ` [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one Thomas Monjalon
2018-05-22 12:08 ` Matan Azrad
2018-05-22 13:34 ` Burakov, Anatoly
2018-05-22 14:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0501MB26080120741BDB73593E6897D2950@VI1PR0501MB2608.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).