DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix UAR remapping on non configured queues
@ 2018-02-06  9:26 Nelio Laranjeiro
  2018-02-06 11:42 ` Shahaf Shuler
  0 siblings, 1 reply; 2+ messages in thread
From: Nelio Laranjeiro @ 2018-02-06  9:26 UTC (permalink / raw)
  To: dev; +Cc: Adrien Mazarguil, Shahaf Shuler, Yongseok Koh, xuemingl, stable

priv_tx_uar_remap() is wrongly considering the queue is already configured
and thus present in the queue array of the device.

Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
Cc: xuemingl@mellanox.com

Cc: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_txq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index 23002cf86..ed1c713ea 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -296,6 +296,8 @@ priv_tx_uar_remap(struct priv *priv, int fd)
 	 * Ref to libmlx5 function: mlx5_init_context()
 	 */
 	for (i = 0; i != priv->txqs_n; ++i) {
+		if (!(*priv->txqs)[i])
+			continue;
 		txq = (*priv->txqs)[i];
 		txq_ctrl = container_of(txq, struct mlx5_txq_ctrl, txq);
 		/* UAR addr form verbs used to find dup and offset in page. */
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix UAR remapping on non configured queues
  2018-02-06  9:26 [dpdk-dev] [PATCH] net/mlx5: fix UAR remapping on non configured queues Nelio Laranjeiro
@ 2018-02-06 11:42 ` Shahaf Shuler
  0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-02-06 11:42 UTC (permalink / raw)
  To: Nélio Laranjeiro, dev
  Cc: Adrien Mazarguil, Yongseok Koh, Xueming(Steven) Li, stable

Tuesday, February 6, 2018 11:26 AM, Nelio Laranjeiro:
> priv_tx_uar_remap() is wrongly considering the queue is already configured
> and thus present in the queue array of the device.
> 
> Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file
> descriptor")
> Cc: xuemingl@mellanox.com
> 
> Cc: stable@dpdk.org
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---

Applied to next-net-mlx, thanks. 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-06 11:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06  9:26 [dpdk-dev] [PATCH] net/mlx5: fix UAR remapping on non configured queues Nelio Laranjeiro
2018-02-06 11:42 ` Shahaf Shuler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).