From: Tasnim Bashar <tbashar@mellanox.com> To: Thomas Monjalon <thomas@monjalon.net>, "dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "harini.ramakrishnan@microsoft.com" <harini.ramakrishnan@microsoft.com>, "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>, "ranjit.menon@intel.com" <ranjit.menon@intel.com>, "ocardona@microsoft.com" <ocardona@microsoft.com>, "navasile@linux.microsoft.com" <navasile@linux.microsoft.com>, Tal Shnaiderman <talshn@mellanox.com>, Fady Bader <fady@mellanox.com>, Ophir Munk <ophirmu@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle Date: Tue, 16 Jun 2020 18:53:09 +0000 Message-ID: <VI1PR05MB61284E90A81EBB37A5361301DA9D0@VI1PR05MB6128.eurprd05.prod.outlook.com> (raw) In-Reply-To: <1716943.Gv3JEJsLzV@thomas> > From: Thomas Monjalon <thomas@monjalon.net> > 02/06/2020 04:00, Tasnim Bashar: > > Casting thread ID to handle is not accurate way to get thread handle. > > Need to use OpenThread function to get thread handle from thread ID. > > > > pthread_setaffinity_np and pthread_getaffinity_np functions for > > Windows are affected because of it. > > > > Signed-off-by: Tasnim Bashar <tbashar@mellanox.com> > > --- > > v3: WA to remove warning(-Wmaybe-uninitialized) > > The -Wmaybe-uninitialized warning was there before this patch. > Shouldn't it be a separate patch before this one? The warning appeared only on this patch, so we don't need to separate it > > > static inline int > > -eal_get_thread_affinity_mask(pthread_t threadid, unsigned long > > *cpuset) > > +eal_get_thread_affinity_mask(pthread_t threadid, rte_cpuset_t > > +*cpuset) > > { > > /* Workaround for the lack of a GetThreadAffinityMask() > > *API in Windows > > */ > > - /* obtain previous mask by setting dummy mask */ > > - DWORD dwprevaffinitymask = > > - SetThreadAffinityMask((HANDLE) threadid, 0x1); > > + DWORD_PTR dwprevaffinitymask; > > Please use underscores to separate parts in names. > > > + HANDLE thread_handle; > > + DWORD_PTR ret; > > + > > + thread_handle = OpenThread(THREAD_ALL_ACCESS, FALSE, threadid); > > + if (thread_handle == NULL) { > > + RTE_LOG_WIN32_ERR("OpenThread()"); > > + return -1; > > + } > > + > > + /* obtain previous mask by setting dummy mask */ > > + dwprevaffinitymask = SetThreadAffinityMask(thread_handle, 0x1); > > + if (dwprevaffinitymask == 0) { > > + RTE_LOG_WIN32_ERR("SetThreadAffinityMask()"); > > + CloseHandle(thread_handle); > > + return -1; > > + } > > + > > /* set it back! */ > > - SetThreadAffinityMask((HANDLE) threadid, dwprevaffinitymask); > > - *cpuset = dwprevaffinitymask; > > + ret = SetThreadAffinityMask(thread_handle, dwprevaffinitymask); > > + if (ret == 0) { > > + RTE_LOG_WIN32_ERR("SetThreadAffinityMask()"); > > + CloseHandle(thread_handle); > > + return -1; > > + } > > + memset(cpuset, 0, sizeof(rte_cpuset_t)); > > Shouldn't we use RTE_CPU_ZERO instead of memset? If we use CPU_ZERO or CPU_SET, we still get the same warning! > > > + *cpuset->_bits = dwprevaffinitymask; > > + CloseHandle(thread_handle); > > return 0; > > } > >
next prev parent reply other threads:[~2020-06-16 18:53 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-22 0:11 [dpdk-dev] [PATCH] " Tasnim Bashar 2020-05-22 0:55 ` Dmitry Kozlyuk 2020-06-02 2:00 ` [dpdk-dev] [PATCH v3] " Tasnim Bashar 2020-06-11 14:35 ` Thomas Monjalon 2020-06-12 16:22 ` Tasnim Bashar 2020-06-12 21:33 ` Thomas Monjalon 2020-06-15 8:16 ` Thomas Monjalon 2020-06-16 18:53 ` Tasnim Bashar [this message] 2020-06-16 19:17 ` Thomas Monjalon 2020-06-16 19:59 ` Tasnim Bashar 2020-06-15 9:42 ` Thomas Monjalon 2020-06-16 19:00 ` Tasnim Bashar 2020-06-24 23:10 ` [dpdk-dev] [PATCH v4] eal/windows: fix " Tasnim Bashar 2020-06-25 0:38 ` Ranjit Menon 2020-06-25 19:11 ` Tasnim Bashar 2020-06-25 19:25 ` [dpdk-dev] [PATCH v5] " Tasnim Bashar 2020-06-29 23:09 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR05MB61284E90A81EBB37A5361301DA9D0@VI1PR05MB6128.eurprd05.prod.outlook.com \ --to=tbashar@mellanox.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=fady@mellanox.com \ --cc=harini.ramakrishnan@microsoft.com \ --cc=navasile@linux.microsoft.com \ --cc=ocardona@microsoft.com \ --cc=ophirmu@mellanox.com \ --cc=pallavi.kadam@intel.com \ --cc=ranjit.menon@intel.com \ --cc=talshn@mellanox.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git