From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>
Subject: Re: [PATCH 2/2] common/cnxk: add include for macro definition
Date: Wed, 15 Jun 2022 11:15:43 +0100 [thread overview]
Message-ID: <YqmxT9CzCBGUvuCg@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <4422106.LvFx2qVVIh@thomas>
On Wed, Jun 15, 2022 at 09:06:26AM +0200, Thomas Monjalon wrote:
> 14/06/2022 14:29, Bruce Richardson:
> > The header file "roc_io.h" uses the "__plt_always_inline" macro but
> > don't include "roc_platform.h" to get the definition of it. This
> > inclusion is not necessary for compilation, but the lack of it can
> > confuse some indexers - such as those in eclipse, which reports the
> > lines:
> >
> > "static __plt_always_inline uint64_t"
> >
> > as possible definitions of a variable called "uint64_t". This confusion
> > leads to uint64_t being flagged as an unknown type in all other parts of
> > the project being indexed, e.g. across all of DPDK code.
> >
> > Adding in the include of rte_common.h makes it clear to the indexer that
> > those lines are part of a function definition, and that allows eclipse
> > to correctly recognise uint64_t as a type from stdint.h
>
> It is not rte_common.h
> Looks like a copy past of the first patch.
>
Yes, it's a copy paste error. I got most instances replaced but missed one
(or at least I don't see a second miss).
next prev parent reply other threads:[~2022-06-15 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 12:29 [PATCH 0/2] add includes to help when editing in Eclipse Bruce Richardson
2022-06-14 12:29 ` [PATCH 1/2] examples/l3fwd: add include for macro definition Bruce Richardson
2022-06-14 12:29 ` [PATCH 2/2] common/cnxk: " Bruce Richardson
2022-06-15 7:06 ` Thomas Monjalon
2022-06-15 10:15 ` Bruce Richardson [this message]
2022-06-15 17:10 ` [PATCH v2 0/2] add includes to help when editing in Eclipse Bruce Richardson
2022-06-15 17:10 ` [PATCH v2 1/2] examples/l3fwd: add include for macro definition Bruce Richardson
2022-06-26 8:35 ` Thomas Monjalon
2022-06-15 17:10 ` [PATCH v2 2/2] common/cnxk: " Bruce Richardson
2022-06-17 13:18 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqmxT9CzCBGUvuCg@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).