DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
@ 2020-06-10 13:25 Dekel Peled
  2020-06-14 10:29 ` Raslan Darawsheh
  2020-06-16 10:27 ` Ferruh Yigit
  0 siblings, 2 replies; 10+ messages in thread
From: Dekel Peled @ 2020-06-10 13:25 UTC (permalink / raw)
  To: matan, viacheslavo, rasland; +Cc: dev

Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
above function flow_dv_validate_item_gtp(), where it is used.

Patch was applied together with other patches which modified the same
file, so the mask was located further away from the function it is
used in.

This patch moves the mask definition to the proper location.

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>

[1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
---
 drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 81f5bd4..d645d2d 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -1639,18 +1639,6 @@ struct field_modify_info modify_tcp[] = {
 	return 0;
 }
 
-/*
- * GTP flags are contained in 1 byte of the format:
- * -------------------------------------------
- * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
- * |-----------------------------------------|
- * | value | Version | PT | Res | E | S | PN |
- * -------------------------------------------
- *
- * Matching is supported only for GTP flags E, S, PN.
- */
-#define MLX5_GTP_FLAGS_MASK	0x07
-
 /**
  * Validate VLAN item.
  *
@@ -1724,6 +1712,18 @@ struct field_modify_info modify_tcp[] = {
 	return 0;
 }
 
+/*
+ * GTP flags are contained in 1 byte of the format:
+ * -------------------------------------------
+ * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
+ * |-----------------------------------------|
+ * | value | Version | PT | Res | E | S | PN |
+ * -------------------------------------------
+ *
+ * Matching is supported only for GTP flags E, S, PN.
+ */
+#define MLX5_GTP_FLAGS_MASK	0x07
+
 /**
  * Validate GTP item.
  *
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-10 13:25 [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location Dekel Peled
@ 2020-06-14 10:29 ` Raslan Darawsheh
  2020-06-16 10:27 ` Ferruh Yigit
  1 sibling, 0 replies; 10+ messages in thread
From: Raslan Darawsheh @ 2020-06-14 10:29 UTC (permalink / raw)
  To: Dekel Peled, Matan Azrad, Slava Ovsiienko; +Cc: dev

Hi,

> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Wednesday, June 10, 2020 4:25 PM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Raslan Darawsheh <rasland@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/mlx5: move GTP mask define to correct location
> 
> Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
> above function flow_dv_validate_item_gtp(), where it is used.
> 
> Patch was applied together with other patches which modified the same
> file, so the mask was located further away from the function it is
> used in.
> 
> This patch moves the mask definition to the proper location.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 81f5bd4..d645d2d 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1639,18 +1639,6 @@ struct field_modify_info modify_tcp[] = {
>  	return 0;
>  }
> 
> -/*
> - * GTP flags are contained in 1 byte of the format:
> - * -------------------------------------------
> - * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
> - * |-----------------------------------------|
> - * | value | Version | PT | Res | E | S | PN |
> - * -------------------------------------------
> - *
> - * Matching is supported only for GTP flags E, S, PN.
> - */
> -#define MLX5_GTP_FLAGS_MASK	0x07
> -
>  /**
>   * Validate VLAN item.
>   *
> @@ -1724,6 +1712,18 @@ struct field_modify_info modify_tcp[] = {
>  	return 0;
>  }
> 
> +/*
> + * GTP flags are contained in 1 byte of the format:
> + * -------------------------------------------
> + * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
> + * |-----------------------------------------|
> + * | value | Version | PT | Res | E | S | PN |
> + * -------------------------------------------
> + *
> + * Matching is supported only for GTP flags E, S, PN.
> + */
> +#define MLX5_GTP_FLAGS_MASK	0x07
> +
>  /**
>   * Validate GTP item.
>   *
> --
> 1.8.3.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-10 13:25 [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location Dekel Peled
  2020-06-14 10:29 ` Raslan Darawsheh
@ 2020-06-16 10:27 ` Ferruh Yigit
  2020-06-16 13:40   ` Raslan Darawsheh
  1 sibling, 1 reply; 10+ messages in thread
From: Ferruh Yigit @ 2020-06-16 10:27 UTC (permalink / raw)
  To: Dekel Peled, matan, viacheslavo, rasland; +Cc: dev

On 6/10/2020 2:25 PM, Dekel Peled wrote:
> Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
> above function flow_dv_validate_item_gtp(), where it is used.
> 
> Patch was applied together with other patches which modified the same
> file, so the mask was located further away from the function it is
> used in.
> 
> This patch moves the mask definition to the proper location.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")


Better to add this as 'Fixes', instead of reference, so this way it helps for
the backporting etc..

    Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
    Cc: stable@dpdk.org


> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
> index 81f5bd4..d645d2d 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1639,18 +1639,6 @@ struct field_modify_info modify_tcp[] = {
>  	return 0;
>  }
>  
> -/*
> - * GTP flags are contained in 1 byte of the format:
> - * -------------------------------------------
> - * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
> - * |-----------------------------------------|
> - * | value | Version | PT | Res | E | S | PN |
> - * -------------------------------------------
> - *
> - * Matching is supported only for GTP flags E, S, PN.
> - */
> -#define MLX5_GTP_FLAGS_MASK	0x07
> -
>  /**
>   * Validate VLAN item.
>   *
> @@ -1724,6 +1712,18 @@ struct field_modify_info modify_tcp[] = {
>  	return 0;
>  }
>  
> +/*
> + * GTP flags are contained in 1 byte of the format:
> + * -------------------------------------------
> + * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
> + * |-----------------------------------------|
> + * | value | Version | PT | Res | E | S | PN |
> + * -------------------------------------------
> + *
> + * Matching is supported only for GTP flags E, S, PN.
> + */
> +#define MLX5_GTP_FLAGS_MASK	0x07
> +
>  /**
>   * Validate GTP item.
>   *
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-16 10:27 ` Ferruh Yigit
@ 2020-06-16 13:40   ` Raslan Darawsheh
  2020-06-16 16:06     ` Matan Azrad
  0 siblings, 1 reply; 10+ messages in thread
From: Raslan Darawsheh @ 2020-06-16 13:40 UTC (permalink / raw)
  To: Ferruh Yigit, Dekel Peled, Matan Azrad, Slava Ovsiienko; +Cc: dev

Hi,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, June 16, 2020 1:28 PM
> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
> Raslan Darawsheh <rasland@mellanox.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct
> location
> 
> On 6/10/2020 2:25 PM, Dekel Peled wrote:
> > Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
> > above function flow_dv_validate_item_gtp(), where it is used.
> >
> > Patch was applied together with other patches which modified the same
> > file, so the mask was located further away from the function it is
> > used in.
> >
> > This patch moves the mask definition to the proper location.
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > Acked-by: Matan Azrad <matan@mellanox.com>
> >
> > [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
> 
> 
> Better to add this as 'Fixes', instead of reference, so this way it helps for
> the backporting etc..
> 
>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
>     Cc: stable@dpdk.org

I'll change it in next-net-mlx accordingly,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-16 13:40   ` Raslan Darawsheh
@ 2020-06-16 16:06     ` Matan Azrad
  2020-06-16 16:18       ` Ferruh Yigit
  0 siblings, 1 reply; 10+ messages in thread
From: Matan Azrad @ 2020-06-16 16:06 UTC (permalink / raw)
  To: Raslan Darawsheh, Ferruh Yigit, Dekel Peled, Slava Ovsiienko; +Cc: dev

Hi

Ferruh, Raslan

This patch is not a fix, we don't need to backport it.
I don't think we need fixes and cc stable here.

Matan

From: Raslan Darawsheh
> Hi,
> 
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Sent: Tuesday, June 16, 2020 1:28 PM
> > To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
> > <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
> > Raslan Darawsheh <rasland@mellanox.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
> > correct location
> >
> > On 6/10/2020 2:25 PM, Dekel Peled wrote:
> > > Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
> > > above function flow_dv_validate_item_gtp(), where it is used.
> > >
> > > Patch was applied together with other patches which modified the
> > > same file, so the mask was located further away from the function it
> > > is used in.
> > >
> > > This patch moves the mask definition to the proper location.
> > >
> > > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > > Acked-by: Matan Azrad <matan@mellanox.com>
> > >
> > > [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
> >
> >
> > Better to add this as 'Fixes', instead of reference, so this way it
> > helps for the backporting etc..
> >
> >     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
> >     Cc: stable@dpdk.org
> 
> I'll change it in next-net-mlx accordingly,
> 
> Kindest regards,
> Raslan Darawsheh

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-16 16:06     ` Matan Azrad
@ 2020-06-16 16:18       ` Ferruh Yigit
  2020-06-16 16:23         ` Matan Azrad
  0 siblings, 1 reply; 10+ messages in thread
From: Ferruh Yigit @ 2020-06-16 16:18 UTC (permalink / raw)
  To: Matan Azrad, Raslan Darawsheh, Dekel Peled, Slava Ovsiienko; +Cc: dev

On 6/16/2020 5:06 PM, Matan Azrad wrote:
> Hi
> 
> Ferruh, Raslan
> 
> This patch is not a fix, we don't need to backport it.

Why not backport it?

> I don't think we need fixes and cc stable here.
> 
> Matan
> 
> From: Raslan Darawsheh
>> Hi,
>>
>>> -----Original Message-----
>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Sent: Tuesday, June 16, 2020 1:28 PM
>>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
>>> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
>>> Raslan Darawsheh <rasland@mellanox.com>
>>> Cc: dev@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
>>> correct location
>>>
>>> On 6/10/2020 2:25 PM, Dekel Peled wrote:
>>>> Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
>>>> above function flow_dv_validate_item_gtp(), where it is used.
>>>>
>>>> Patch was applied together with other patches which modified the
>>>> same file, so the mask was located further away from the function it
>>>> is used in.
>>>>
>>>> This patch moves the mask definition to the proper location.
>>>>
>>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>>>> Acked-by: Matan Azrad <matan@mellanox.com>
>>>>
>>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
>>>
>>>
>>> Better to add this as 'Fixes', instead of reference, so this way it
>>> helps for the backporting etc..
>>>
>>>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
>>>     Cc: stable@dpdk.org
>>
>> I'll change it in next-net-mlx accordingly,
>>
>> Kindest regards,
>> Raslan Darawsheh


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-16 16:18       ` Ferruh Yigit
@ 2020-06-16 16:23         ` Matan Azrad
  2020-06-16 16:53           ` Ferruh Yigit
  0 siblings, 1 reply; 10+ messages in thread
From: Matan Azrad @ 2020-06-16 16:23 UTC (permalink / raw)
  To: Ferruh Yigit, Raslan Darawsheh, Dekel Peled, Slava Ovsiienko; +Cc: dev



From: Ferruh Yigit
> On 6/16/2020 5:06 PM, Matan Azrad wrote:
> > Hi
> >
> > Ferruh, Raslan
> >
> > This patch is not a fix, we don't need to backport it.
> 
> Why not backport it?

There is no a bug fix.
The behavior will not be changed.

It is just for comfort.


 
> > I don't think we need fixes and cc stable here.
> >
> > Matan
> >
> > From: Raslan Darawsheh
> >> Hi,
> >>
> >>> -----Original Message-----
> >>> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> Sent: Tuesday, June 16, 2020 1:28 PM
> >>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
> >>> <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>;
> >>> Raslan Darawsheh <rasland@mellanox.com>
> >>> Cc: dev@dpdk.org
> >>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
> >>> correct location
> >>>
> >>> On 6/10/2020 2:25 PM, Dekel Peled wrote:
> >>>> Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK,
> just
> >>>> above function flow_dv_validate_item_gtp(), where it is used.
> >>>>
> >>>> Patch was applied together with other patches which modified the
> >>>> same file, so the mask was located further away from the function
> >>>> it is used in.
> >>>>
> >>>> This patch moves the mask definition to the proper location.
> >>>>
> >>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> >>>> Acked-by: Matan Azrad <matan@mellanox.com>
> >>>>
> >>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
> >>>
> >>>
> >>> Better to add this as 'Fixes', instead of reference, so this way it
> >>> helps for the backporting etc..
> >>>
> >>>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
> >>>     Cc: stable@dpdk.org
> >>
> >> I'll change it in next-net-mlx accordingly,
> >>
> >> Kindest regards,
> >> Raslan Darawsheh


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-16 16:23         ` Matan Azrad
@ 2020-06-16 16:53           ` Ferruh Yigit
  2020-06-17 11:43             ` Matan Azrad
  0 siblings, 1 reply; 10+ messages in thread
From: Ferruh Yigit @ 2020-06-16 16:53 UTC (permalink / raw)
  To: Matan Azrad, Raslan Darawsheh, Dekel Peled, Slava Ovsiienko; +Cc: dev

On 6/16/2020 5:23 PM, Matan Azrad wrote:
> 
> 
> From: Ferruh Yigit
>> On 6/16/2020 5:06 PM, Matan Azrad wrote:
>>> Hi
>>>
>>> Ferruh, Raslan
>>>
>>> This patch is not a fix, we don't need to backport it.
>>
>> Why not backport it?
> 
> There is no a bug fix.
> The behavior will not be changed.
> 
> It is just for comfort.

It is not fix in the functionality, yes. But since it is merged into master, why
not backport it, backporting reduces possible conflicts in related code later.

Also if this increases the readability of the code, why not stable trees benefit
from it too?

> 
> 
>  
>>> I don't think we need fixes and cc stable here.
>>>
>>> Matan
>>>
>>> From: Raslan Darawsheh
>>>> Hi,
>>>>
>>>>> -----Original Message-----
>>>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>>>>> Sent: Tuesday, June 16, 2020 1:28 PM
>>>>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
>>>>> <matan@mellanox.com>; Slava Ovsiienko
>> <viacheslavo@mellanox.com>;
>>>>> Raslan Darawsheh <rasland@mellanox.com>
>>>>> Cc: dev@dpdk.org
>>>>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
>>>>> correct location
>>>>>
>>>>> On 6/10/2020 2:25 PM, Dekel Peled wrote:
>>>>>> Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK,
>> just
>>>>>> above function flow_dv_validate_item_gtp(), where it is used.
>>>>>>
>>>>>> Patch was applied together with other patches which modified the
>>>>>> same file, so the mask was located further away from the function
>>>>>> it is used in.
>>>>>>
>>>>>> This patch moves the mask definition to the proper location.
>>>>>>
>>>>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>>>>>> Acked-by: Matan Azrad <matan@mellanox.com>
>>>>>>
>>>>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
>>>>>
>>>>>
>>>>> Better to add this as 'Fixes', instead of reference, so this way it
>>>>> helps for the backporting etc..
>>>>>
>>>>>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
>>>>>     Cc: stable@dpdk.org
>>>>
>>>> I'll change it in next-net-mlx accordingly,
>>>>
>>>> Kindest regards,
>>>> Raslan Darawsheh
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-16 16:53           ` Ferruh Yigit
@ 2020-06-17 11:43             ` Matan Azrad
  2020-06-17 12:59               ` Kevin Traynor
  0 siblings, 1 reply; 10+ messages in thread
From: Matan Azrad @ 2020-06-17 11:43 UTC (permalink / raw)
  To: Ferruh Yigit, Raslan Darawsheh, Dekel Peled, Slava Ovsiienko; +Cc: dev



From: Ferruh Yigit:
> On 6/16/2020 5:23 PM, Matan Azrad wrote:
> >
> >
> > From: Ferruh Yigit
> >> On 6/16/2020 5:06 PM, Matan Azrad wrote:
> >>> Hi
> >>>
> >>> Ferruh, Raslan
> >>>
> >>> This patch is not a fix, we don't need to backport it.
> >>
> >> Why not backport it?
> >
> > There is no a bug fix.
> > The behavior will not be changed.
> >
> > It is just for comfort.
> 
> It is not fix in the functionality, yes. But since it is merged into master, why
> not backport it, backporting reduces possible conflicts in related code later.

We can say it for any patch in master.
 
> Also if this increases the readability of the code, why not stable trees benefit
> from it too?

It is not too important in some cases, therefore doesn't worth the potential effort of backporting.

I think this is grey case, maybe one thing we can let the maintainer to decide...

I will not insist...

> >>> I don't think we need fixes and cc stable here.
> >>>
> >>> Matan
> >>>
> >>> From: Raslan Darawsheh
> >>>> Hi,
> >>>>
> >>>>> -----Original Message-----
> >>>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >>>>> Sent: Tuesday, June 16, 2020 1:28 PM
> >>>>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
> >>>>> <matan@mellanox.com>; Slava Ovsiienko
> >> <viacheslavo@mellanox.com>;
> >>>>> Raslan Darawsheh <rasland@mellanox.com>
> >>>>> Cc: dev@dpdk.org
> >>>>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
> >>>>> correct location
> >>>>>
> >>>>> On 6/10/2020 2:25 PM, Dekel Peled wrote:
> >>>>>> Recent patch [1] added definition of mask
> MLX5_GTP_FLAGS_MASK,
> >> just
> >>>>>> above function flow_dv_validate_item_gtp(), where it is used.
> >>>>>>
> >>>>>> Patch was applied together with other patches which modified the
> >>>>>> same file, so the mask was located further away from the function
> >>>>>> it is used in.
> >>>>>>
> >>>>>> This patch moves the mask definition to the proper location.
> >>>>>>
> >>>>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> >>>>>> Acked-by: Matan Azrad <matan@mellanox.com>
> >>>>>>
> >>>>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
> >>>>>
> >>>>>
> >>>>> Better to add this as 'Fixes', instead of reference, so this way
> >>>>> it helps for the backporting etc..
> >>>>>
> >>>>>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to
> indexed")
> >>>>>     Cc: stable@dpdk.org
> >>>>
> >>>> I'll change it in next-net-mlx accordingly,
> >>>>
> >>>> Kindest regards,
> >>>> Raslan Darawsheh
> >


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
  2020-06-17 11:43             ` Matan Azrad
@ 2020-06-17 12:59               ` Kevin Traynor
  0 siblings, 0 replies; 10+ messages in thread
From: Kevin Traynor @ 2020-06-17 12:59 UTC (permalink / raw)
  To: Matan Azrad, Ferruh Yigit, Raslan Darawsheh, Dekel Peled,
	Slava Ovsiienko
  Cc: dev

On 17/06/2020 12:43, Matan Azrad wrote:
> 
> 
> From: Ferruh Yigit:
>> On 6/16/2020 5:23 PM, Matan Azrad wrote:
>>>
>>>
>>> From: Ferruh Yigit
>>>> On 6/16/2020 5:06 PM, Matan Azrad wrote:
>>>>> Hi
>>>>>
>>>>> Ferruh, Raslan
>>>>>
>>>>> This patch is not a fix, we don't need to backport it.
>>>>
>>>> Why not backport it?
>>>
>>> There is no a bug fix.
>>> The behavior will not be changed.
>>>
>>> It is just for comfort.
>>
>> It is not fix in the functionality, yes. But since it is merged into master, why
>> not backport it, backporting reduces possible conflicts in related code later.
> 
> We can say it for any patch in master.
>  
>> Also if this increases the readability of the code, why not stable trees benefit
>> from it too?
> 
> It is not too important in some cases, therefore doesn't worth the potential effort of backporting.
> 
> I think this is grey case, maybe one thing we can let the maintainer to decide...
> 
> I will not insist...
> 

In this case it is changing a "non-fix" commit in v20.05. So, in reality
it's not relevant to existing maintained stable branches with or without
the tag.

Wrt letting stable maintainer decide, in general stable maintainer won't
look at patches without the tags, so better to tag if there's a doubt.

>>>>> I don't think we need fixes and cc stable here.
>>>>>
>>>>> Matan
>>>>>
>>>>> From: Raslan Darawsheh
>>>>>> Hi,
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>>>>>>> Sent: Tuesday, June 16, 2020 1:28 PM
>>>>>>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
>>>>>>> <matan@mellanox.com>; Slava Ovsiienko
>>>> <viacheslavo@mellanox.com>;
>>>>>>> Raslan Darawsheh <rasland@mellanox.com>
>>>>>>> Cc: dev@dpdk.org
>>>>>>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
>>>>>>> correct location
>>>>>>>
>>>>>>> On 6/10/2020 2:25 PM, Dekel Peled wrote:
>>>>>>>> Recent patch [1] added definition of mask
>> MLX5_GTP_FLAGS_MASK,
>>>> just
>>>>>>>> above function flow_dv_validate_item_gtp(), where it is used.
>>>>>>>>
>>>>>>>> Patch was applied together with other patches which modified the
>>>>>>>> same file, so the mask was located further away from the function
>>>>>>>> it is used in.
>>>>>>>>
>>>>>>>> This patch moves the mask definition to the proper location.
>>>>>>>>
>>>>>>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>>>>>>>> Acked-by: Matan Azrad <matan@mellanox.com>
>>>>>>>>
>>>>>>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
>>>>>>>
>>>>>>>
>>>>>>> Better to add this as 'Fixes', instead of reference, so this way
>>>>>>> it helps for the backporting etc..
>>>>>>>
>>>>>>>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to
>> indexed")
>>>>>>>     Cc: stable@dpdk.org
>>>>>>
>>>>>> I'll change it in next-net-mlx accordingly,
>>>>>>
>>>>>> Kindest regards,
>>>>>> Raslan Darawsheh
>>>
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-06-17 12:59 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 13:25 [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location Dekel Peled
2020-06-14 10:29 ` Raslan Darawsheh
2020-06-16 10:27 ` Ferruh Yigit
2020-06-16 13:40   ` Raslan Darawsheh
2020-06-16 16:06     ` Matan Azrad
2020-06-16 16:18       ` Ferruh Yigit
2020-06-16 16:23         ` Matan Azrad
2020-06-16 16:53           ` Ferruh Yigit
2020-06-17 11:43             ` Matan Azrad
2020-06-17 12:59               ` Kevin Traynor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).