[PATCH] app/testpmd: add command to get Tx queue used count

[PATCH] app/testpmd: add command to get Tx queue used count

[skoteshwar]

From: Satha Rao <skoteshwar@marvell.com>

Fastpath API to get txq used count.

   testpmd> show port 0 txq 0 desc count

Signed-off-by: Satha Rao <skoteshwar@marvell.com>
---
 app/test-pmd/cmdline.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f704319..1d09633 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -12638,6 +12638,83 @@ struct cmd_show_port_supported_ptypes_result {
 	},
 };
 
+/* *** display tx queue desc used count *** */
+struct cmd_show_tx_queue_desc_count_result {
+	cmdline_fixed_string_t cmd_show;
+	cmdline_fixed_string_t cmd_port;
+	cmdline_fixed_string_t cmd_txq;
+	cmdline_fixed_string_t cmd_desc;
+	cmdline_fixed_string_t cmd_count;
+	portid_t cmd_pid;
+	portid_t cmd_qid;
+};
+
+static void
+cmd_show_tx_queue_desc_count_parsed(void *parsed_result,
+		__rte_unused struct cmdline *cl,
+		__rte_unused void *data)
+{
+	struct cmd_show_tx_queue_desc_count_result *res = parsed_result;
+	int rc;
+
+	if (rte_eth_tx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
+		fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",	res->cmd_pid,
+			res->cmd_qid);
+		return;
+	}
+
+	rc = rte_eth_tx_queue_count(res->cmd_pid, res->cmd_qid);
+	if (rc < 0) {
+		fprintf(stderr, "Tx queue count get failed rc=%d queue_id=%d\n", rc, res->cmd_qid);
+		return;
+	}
+	printf("TxQ %d used desc count = %d\n", res->cmd_qid, rc);
+}
+
+static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_show =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_tx_queue_desc_count_result,
+		 cmd_show, "show");
+static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_port =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_tx_queue_desc_count_result,
+		 cmd_port, "port");
+static cmdline_parse_token_num_t cmd_show_tx_queue_desc_count_pid =
+	TOKEN_NUM_INITIALIZER
+		(struct cmd_show_tx_queue_desc_count_result,
+		 cmd_pid, RTE_UINT16);
+static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_txq =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_tx_queue_desc_count_result,
+		 cmd_txq, "txq");
+static cmdline_parse_token_num_t cmd_show_tx_queue_desc_count_qid =
+	TOKEN_NUM_INITIALIZER
+		(struct cmd_show_tx_queue_desc_count_result,
+		 cmd_qid, RTE_UINT16);
+static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_desc =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_tx_queue_desc_count_result,
+		 cmd_desc, "desc");
+static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_count =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_tx_queue_desc_count_result,
+		 cmd_count, "count");
+static cmdline_parse_inst_t cmd_show_tx_queue_desc_count = {
+	.f = cmd_show_tx_queue_desc_count_parsed,
+	.data = NULL,
+	.help_str = "show port <port_id> txq <queue_id> desc count",
+	.tokens = {
+		(void *)&cmd_show_tx_queue_desc_count_show,
+		(void *)&cmd_show_tx_queue_desc_count_port,
+		(void *)&cmd_show_tx_queue_desc_count_pid,
+		(void *)&cmd_show_tx_queue_desc_count_txq,
+		(void *)&cmd_show_tx_queue_desc_count_qid,
+		(void *)&cmd_show_tx_queue_desc_count_desc,
+		(void *)&cmd_show_tx_queue_desc_count_count,
+		NULL,
+	},
+};
+
 /* *** display rx/tx descriptor status *** */
 struct cmd_show_rx_tx_desc_status_result {
 	cmdline_fixed_string_t cmd_show;
@@ -13346,6 +13423,7 @@ struct cmd_config_tx_affinity_map {
 	(cmdline_parse_inst_t *)&cmd_show_tx_metadata,
 	(cmdline_parse_inst_t *)&cmd_show_rx_tx_desc_status,
 	(cmdline_parse_inst_t *)&cmd_show_rx_queue_desc_used_count,
+	(cmdline_parse_inst_t *)&cmd_show_tx_queue_desc_count,
 	(cmdline_parse_inst_t *)&cmd_set_raw,
 	(cmdline_parse_inst_t *)&cmd_show_set_raw,
 	(cmdline_parse_inst_t *)&cmd_show_set_raw_all,
-- 
1.8.3.1

Re: [PATCH] app/testpmd: add command to get Tx queue used count

[fengchengwen]

Please doc this command in doc/guides/testpmd_app_ug/testpmd_funcs.rst
Also why not extend "show port rxq xxx" command to support txq ?

On 2024/1/24 20:18, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> Fastpath API to get txq used count.
> 
>    testpmd> show port 0 txq 0 desc count
> 
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> ---
>  app/test-pmd/cmdline.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index f704319..1d09633 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -12638,6 +12638,83 @@ struct cmd_show_port_supported_ptypes_result {
>  	},
>  };
>  
> +/* *** display tx queue desc used count *** */
> +struct cmd_show_tx_queue_desc_count_result {
> +	cmdline_fixed_string_t cmd_show;
> +	cmdline_fixed_string_t cmd_port;
> +	cmdline_fixed_string_t cmd_txq;
> +	cmdline_fixed_string_t cmd_desc;
> +	cmdline_fixed_string_t cmd_count;
> +	portid_t cmd_pid;
> +	portid_t cmd_qid;
> +};
> +
> +static void
> +cmd_show_tx_queue_desc_count_parsed(void *parsed_result,
> +		__rte_unused struct cmdline *cl,
> +		__rte_unused void *data)
> +{
> +	struct cmd_show_tx_queue_desc_count_result *res = parsed_result;
> +	int rc;
> +
> +	if (rte_eth_tx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
> +		fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",	res->cmd_pid,
> +			res->cmd_qid);
> +		return;
> +	}
> +
> +	rc = rte_eth_tx_queue_count(res->cmd_pid, res->cmd_qid);
> +	if (rc < 0) {
> +		fprintf(stderr, "Tx queue count get failed rc=%d queue_id=%d\n", rc, res->cmd_qid);
> +		return;
> +	}
> +	printf("TxQ %d used desc count = %d\n", res->cmd_qid, rc);
> +}
> +
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_show =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_show, "show");
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_port =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_port, "port");
> +static cmdline_parse_token_num_t cmd_show_tx_queue_desc_count_pid =
> +	TOKEN_NUM_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_pid, RTE_UINT16);
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_txq =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_txq, "txq");
> +static cmdline_parse_token_num_t cmd_show_tx_queue_desc_count_qid =
> +	TOKEN_NUM_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_qid, RTE_UINT16);
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_desc =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_desc, "desc");
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_count =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_count, "count");
> +static cmdline_parse_inst_t cmd_show_tx_queue_desc_count = {
> +	.f = cmd_show_tx_queue_desc_count_parsed,
> +	.data = NULL,
> +	.help_str = "show port <port_id> txq <queue_id> desc count",
> +	.tokens = {
> +		(void *)&cmd_show_tx_queue_desc_count_show,
> +		(void *)&cmd_show_tx_queue_desc_count_port,
> +		(void *)&cmd_show_tx_queue_desc_count_pid,
> +		(void *)&cmd_show_tx_queue_desc_count_txq,
> +		(void *)&cmd_show_tx_queue_desc_count_qid,
> +		(void *)&cmd_show_tx_queue_desc_count_desc,
> +		(void *)&cmd_show_tx_queue_desc_count_count,
> +		NULL,
> +	},
> +};
> +
>  /* *** display rx/tx descriptor status *** */
>  struct cmd_show_rx_tx_desc_status_result {
>  	cmdline_fixed_string_t cmd_show;
> @@ -13346,6 +13423,7 @@ struct cmd_config_tx_affinity_map {
>  	(cmdline_parse_inst_t *)&cmd_show_tx_metadata,
>  	(cmdline_parse_inst_t *)&cmd_show_rx_tx_desc_status,
>  	(cmdline_parse_inst_t *)&cmd_show_rx_queue_desc_used_count,
> +	(cmdline_parse_inst_t *)&cmd_show_tx_queue_desc_count,
>  	(cmdline_parse_inst_t *)&cmd_set_raw,
>  	(cmdline_parse_inst_t *)&cmd_show_set_raw,
>  	(cmdline_parse_inst_t *)&cmd_show_set_raw_all,
> 

RE: [EXT] Re: [PATCH] app/testpmd: add command to get Tx queue used count

[Satha Koteswara Rao Kottidi]

----------------------------------------------------------------------
Please doc this command in doc/guides/testpmd_app_ug/testpmd_funcs.rst

>> Thanks, will update in next version

Also why not extend "show port rxq xxx" command to support txq ?

>> txq and rxq are different directions, so  extended "show port " command to support txq similar to rxq command. Could you please give more details if I missed something here.

Thanks,
Satha

On 2024/1/24 20:18, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> Fastpath API to get txq used count.
> 
>    testpmd> show port 0 txq 0 desc count
> 
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> ---
>  app/test-pmd/cmdline.c | 78 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 
> f704319..1d09633 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -12638,6 +12638,83 @@ struct cmd_show_port_supported_ptypes_result {
>  	},
>  };
>  
> +/* *** display tx queue desc used count *** */ struct 
> +cmd_show_tx_queue_desc_count_result {
> +	cmdline_fixed_string_t cmd_show;
> +	cmdline_fixed_string_t cmd_port;
> +	cmdline_fixed_string_t cmd_txq;
> +	cmdline_fixed_string_t cmd_desc;
> +	cmdline_fixed_string_t cmd_count;
> +	portid_t cmd_pid;
> +	portid_t cmd_qid;
> +};
> +
> +static void
> +cmd_show_tx_queue_desc_count_parsed(void *parsed_result,
> +		__rte_unused struct cmdline *cl,
> +		__rte_unused void *data)
> +{
> +	struct cmd_show_tx_queue_desc_count_result *res = parsed_result;
> +	int rc;
> +
> +	if (rte_eth_tx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
> +		fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",	res->cmd_pid,
> +			res->cmd_qid);
> +		return;
> +	}
> +
> +	rc = rte_eth_tx_queue_count(res->cmd_pid, res->cmd_qid);
> +	if (rc < 0) {
> +		fprintf(stderr, "Tx queue count get failed rc=%d queue_id=%d\n", rc, res->cmd_qid);
> +		return;
> +	}
> +	printf("TxQ %d used desc count = %d\n", res->cmd_qid, rc); }
> +
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_show =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_show, "show");
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_port =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_port, "port");
> +static cmdline_parse_token_num_t cmd_show_tx_queue_desc_count_pid =
> +	TOKEN_NUM_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_pid, RTE_UINT16);
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_txq =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_txq, "txq");
> +static cmdline_parse_token_num_t cmd_show_tx_queue_desc_count_qid =
> +	TOKEN_NUM_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_qid, RTE_UINT16);
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_desc =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_desc, "desc");
> +static cmdline_parse_token_string_t cmd_show_tx_queue_desc_count_count =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_tx_queue_desc_count_result,
> +		 cmd_count, "count");
> +static cmdline_parse_inst_t cmd_show_tx_queue_desc_count = {
> +	.f = cmd_show_tx_queue_desc_count_parsed,
> +	.data = NULL,
> +	.help_str = "show port <port_id> txq <queue_id> desc count",
> +	.tokens = {
> +		(void *)&cmd_show_tx_queue_desc_count_show,
> +		(void *)&cmd_show_tx_queue_desc_count_port,
> +		(void *)&cmd_show_tx_queue_desc_count_pid,
> +		(void *)&cmd_show_tx_queue_desc_count_txq,
> +		(void *)&cmd_show_tx_queue_desc_count_qid,
> +		(void *)&cmd_show_tx_queue_desc_count_desc,
> +		(void *)&cmd_show_tx_queue_desc_count_count,
> +		NULL,
> +	},
> +};
> +
>  /* *** display rx/tx descriptor status *** */  struct 
> cmd_show_rx_tx_desc_status_result {
>  	cmdline_fixed_string_t cmd_show;
> @@ -13346,6 +13423,7 @@ struct cmd_config_tx_affinity_map {
>  	(cmdline_parse_inst_t *)&cmd_show_tx_metadata,
>  	(cmdline_parse_inst_t *)&cmd_show_rx_tx_desc_status,
>  	(cmdline_parse_inst_t *)&cmd_show_rx_queue_desc_used_count,
> +	(cmdline_parse_inst_t *)&cmd_show_tx_queue_desc_count,
>  	(cmdline_parse_inst_t *)&cmd_set_raw,
>  	(cmdline_parse_inst_t *)&cmd_show_set_raw,
>  	(cmdline_parse_inst_t *)&cmd_show_set_raw_all,
> 

Re: [EXT] Re: [PATCH] app/testpmd: add command to get Tx queue used count

[Ferruh Yigit]

On 1/29/2024 6:37 AM, Satha Koteswara Rao Kottidi wrote:
>> 
>> ----------------------------------------------------------------------
>> Please doc this command in doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> 
>
> Thanks, will update in next version
>
>> 
>> Also why not extend "show port rxq xxx" command to support txq ?
> 
> txq and rxq are different directions, so  extended "show port " command to support txq similar to rxq command. Could you please give more details if I missed something here.
> 

There is an existing "show port <port_id> rxq <queue_id> desc used
count" command, which is for Rx.

As you are adding support for Tx, instead of adding it as a new command,
existing 'cmd_show_rx_queue_desc_used_count_parsed()' can be extended to
support both Rx and Tx.
You can check 'cmd_show_rx_tx_desc_status_parsed()' as sample.

This also helps to have a unified syntax for Rx and Tx, as your version
is slightly diverging from the Rx one.


And please update 'cmd_help_long_parsed()' help string with relevant change.

RE: [EXT] Re: [PATCH] app/testpmd: add command to get Tx queue used count

[Satha Koteswara Rao Kottidi]

>> 
>> ---------------------------------------------------------------------
>> - Please doc this command in 
>> doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> 
>
> Thanks, will update in next version
>
>> 
>> Also why not extend "show port rxq xxx" command to support txq ?
> 
> txq and rxq are different directions, so  extended "show port " command to support txq similar to rxq command. Could you please give more details if I missed something here.
> 

There is an existing "show port <port_id> rxq <queue_id> desc used count" command, which is for Rx.

As you are adding support for Tx, instead of adding it as a new command, existing 'cmd_show_rx_queue_desc_used_count_parsed()' can be extended to support both Rx and Tx.
You can check 'cmd_show_rx_tx_desc_status_parsed()' as sample.

This also helps to have a unified syntax for Rx and Tx, as your version is slightly diverging from the Rx one.


And please update 'cmd_help_long_parsed()' help string with relevant change.

>>> Thanks Ferruh, will update unified command for Rx/Tx in next version.

[PATCH v2] app/testpmd: command to get descriptor used count

[skoteshwar]

From: Satha Rao <skoteshwar@marvell.com>

Existing Rx desc used count command extended to get Tx queue
used count.
    testpmd> show port 0 rxq 0 desc used count
    testpmd> show port 0 txq 0 desc used count

Signed-off-by: Satha Rao <skoteshwar@marvell.com>
---
Depends-on: series-30833 ("ethdev: support Tx queue used count")

v2:
 extended rx_queue_desc_used_count command to support Tx
 updated testpmd_app_ug with new command

 app/test-pmd/cmdline.c                      | 184 +++++++++++---------
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  10 +-
 2 files changed, 104 insertions(+), 90 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f704319771..c8c88f3236 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -12638,6 +12638,104 @@ static cmdline_parse_inst_t cmd_show_port_supported_ptypes = {
 	},
 };
 
+/* *** display rx/tx queue descriptor used count *** */
+struct cmd_show_rx_tx_queue_desc_used_count_result {
+	cmdline_fixed_string_t cmd_show;
+	cmdline_fixed_string_t cmd_port;
+	cmdline_fixed_string_t cmd_dir;
+	cmdline_fixed_string_t cmd_desc;
+	cmdline_fixed_string_t cmd_used;
+	cmdline_fixed_string_t cmd_count;
+	portid_t cmd_pid;
+	portid_t cmd_qid;
+};
+
+static void
+cmd_show_rx_tx_queue_desc_used_count_parsed(void *parsed_result, __rte_unused struct cmdline *cl,
+					    __rte_unused void *data)
+{
+	struct cmd_show_rx_tx_queue_desc_used_count_result *res = parsed_result;
+	int rc;
+
+	if (!strcmp(res->cmd_dir, "rxq")) {
+		if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
+			fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",
+				res->cmd_pid, res->cmd_qid);
+			return;
+		}
+
+		rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid);
+		if (rc < 0) {
+			fprintf(stderr, "Invalid queueid = %d\n", res->cmd_qid);
+			return;
+		}
+		printf("RxQ %d used desc count = %d\n", res->cmd_qid, rc);
+	} else if (!strcmp(res->cmd_dir, "txq")) {
+		if (rte_eth_tx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
+			fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",
+				res->cmd_pid, res->cmd_qid);
+			return;
+		}
+
+		rc = rte_eth_tx_queue_count(res->cmd_pid, res->cmd_qid);
+		if (rc < 0) {
+			fprintf(stderr, "Tx queue count get failed rc=%d queue_id=%d\n", rc,
+				res->cmd_qid);
+			return;
+		}
+		printf("TxQ %d used desc count = %d\n", res->cmd_qid, rc);
+	}
+}
+
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_show =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_show, "show");
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_port =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_port, "port");
+static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_pid =
+	TOKEN_NUM_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_pid, RTE_UINT16);
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_dir =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_dir, "rxq#txq");
+static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_qid =
+	TOKEN_NUM_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_qid, RTE_UINT16);
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_desc =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_desc, "desc");
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_used =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_count, "used");
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_count =
+	TOKEN_STRING_INITIALIZER
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_count, "count");
+static cmdline_parse_inst_t cmd_show_rx_tx_queue_desc_used_count = {
+	.f = cmd_show_rx_tx_queue_desc_used_count_parsed,
+	.data = NULL,
+	.help_str = "show port <port_id> rxq|txq <queue_id> desc used count",
+	.tokens = {
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_show,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_port,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_pid,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_dir,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_qid,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_desc,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_used,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_count,
+		NULL,
+	},
+};
+
 /* *** display rx/tx descriptor status *** */
 struct cmd_show_rx_tx_desc_status_result {
 	cmdline_fixed_string_t cmd_show;
@@ -12745,90 +12843,6 @@ static cmdline_parse_inst_t cmd_show_rx_tx_desc_status = {
 	},
 };
 
-/* *** display rx queue desc used count *** */
-struct cmd_show_rx_queue_desc_used_count_result {
-	cmdline_fixed_string_t cmd_show;
-	cmdline_fixed_string_t cmd_port;
-	cmdline_fixed_string_t cmd_rxq;
-	cmdline_fixed_string_t cmd_desc;
-	cmdline_fixed_string_t cmd_used;
-	cmdline_fixed_string_t cmd_count;
-	portid_t cmd_pid;
-	portid_t cmd_qid;
-};
-
-static void
-cmd_show_rx_queue_desc_used_count_parsed(void *parsed_result,
-		__rte_unused struct cmdline *cl,
-		__rte_unused void *data)
-{
-	struct cmd_show_rx_queue_desc_used_count_result *res = parsed_result;
-	int rc;
-
-	if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
-		fprintf(stderr,
-			"Invalid input: port id = %d, queue id = %d\n",
-			res->cmd_pid, res->cmd_qid);
-		return;
-	}
-
-	rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid);
-	if (rc < 0) {
-		fprintf(stderr, "Invalid queueid = %d\n", res->cmd_qid);
-		return;
-	}
-	printf("Used desc count = %d\n", rc);
-}
-
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_show =
-	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_show, "show");
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_port =
-	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_port, "port");
-static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_pid =
-	TOKEN_NUM_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_pid, RTE_UINT16);
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_rxq =
-	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_rxq, "rxq");
-static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_qid =
-	TOKEN_NUM_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_qid, RTE_UINT16);
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_desc =
-	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_count, "desc");
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_used =
-	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_count, "used");
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_count =
-	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_count, "count");
-static cmdline_parse_inst_t cmd_show_rx_queue_desc_used_count = {
-	.f = cmd_show_rx_queue_desc_used_count_parsed,
-	.data = NULL,
-	.help_str = "show port <port_id> rxq <queue_id> desc used count",
-	.tokens = {
-		(void *)&cmd_show_rx_queue_desc_used_count_show,
-		(void *)&cmd_show_rx_queue_desc_used_count_port,
-		(void *)&cmd_show_rx_queue_desc_used_count_pid,
-		(void *)&cmd_show_rx_queue_desc_used_count_rxq,
-		(void *)&cmd_show_rx_queue_desc_used_count_qid,
-		(void *)&cmd_show_rx_queue_desc_used_count_desc,
-		(void *)&cmd_show_rx_queue_desc_used_count_used,
-		(void *)&cmd_show_rx_queue_desc_used_count_count,
-		NULL,
-	},
-};
-
 /* Common result structure for set port ptypes */
 struct cmd_set_port_ptypes_result {
 	cmdline_fixed_string_t set;
@@ -13345,7 +13359,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_config_tx_metadata_specific,
 	(cmdline_parse_inst_t *)&cmd_show_tx_metadata,
 	(cmdline_parse_inst_t *)&cmd_show_rx_tx_desc_status,
-	(cmdline_parse_inst_t *)&cmd_show_rx_queue_desc_used_count,
+	(cmdline_parse_inst_t *)&cmd_show_rx_tx_queue_desc_used_count,
 	(cmdline_parse_inst_t *)&cmd_set_raw,
 	(cmdline_parse_inst_t *)&cmd_show_set_raw,
 	(cmdline_parse_inst_t *)&cmd_show_set_raw_all,
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index ab18a80b30..6369ee337e 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -264,13 +264,13 @@ Display information for a given port's RX/TX descriptor status::
 
    testpmd> show port (port_id) (rxq|txq) (queue_id) desc (desc_id) status
 
-show rxq desc used count
-~~~~~~~~~~~~~~~~~~~~~~~~
+show desc used count(rxq|txq)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Display the number of receive packet descriptors currently filled by hardware
-and ready to be processed by the driver on a given RX queue::
+Display the number of packet descriptors currently used by hardware for a given
+port's RX/TX queue::
 
-   testpmd> show port (port_id) rxq (queue_id) desc used count
+   testpmd> show port (port_id) (rxq|txq) (queue_id) desc used count
 
 show config
 ~~~~~~~~~~~
-- 
2.25.1

Re: [PATCH v2] app/testpmd: command to get descriptor used count

[Ferruh Yigit]

On 2/1/2024 1:52 PM, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> Existing Rx desc used count command extended to get Tx queue
> used count.
>     testpmd> show port 0 rxq 0 desc used count
>     testpmd> show port 0 txq 0 desc used count
> 
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> ---
> Depends-on: series-30833 ("ethdev: support Tx queue used count")
> 
> v2:
>  extended rx_queue_desc_used_count command to support Tx
>  updated testpmd_app_ug with new command
> 
>  app/test-pmd/cmdline.c                      | 184 +++++++++++---------
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  10 +-
>  2 files changed, 104 insertions(+), 90 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index f704319771..c8c88f3236 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -12638,6 +12638,104 @@ static cmdline_parse_inst_t cmd_show_port_supported_ptypes = {
>  	},
>  };
>  
> +/* *** display rx/tx queue descriptor used count *** */
> +struct cmd_show_rx_tx_queue_desc_used_count_result {
> +	cmdline_fixed_string_t cmd_show;
> +	cmdline_fixed_string_t cmd_port;
> +	cmdline_fixed_string_t cmd_dir;
> +	cmdline_fixed_string_t cmd_desc;
> +	cmdline_fixed_string_t cmd_used;
> +	cmdline_fixed_string_t cmd_count;
> +	portid_t cmd_pid;
> +	portid_t cmd_qid;
> +};
> +
> +static void
> +cmd_show_rx_tx_queue_desc_used_count_parsed(void *parsed_result, __rte_unused struct cmdline *cl,
> +					    __rte_unused void *data)
> +{
> +	struct cmd_show_rx_tx_queue_desc_used_count_result *res = parsed_result;
> +	int rc;
> +
> +	if (!strcmp(res->cmd_dir, "rxq")) {
> +		if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
> +			fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",
> +				res->cmd_pid, res->cmd_qid);
> +			return;
> +		}
> +
> +		rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid);
> +		if (rc < 0) {
> +			fprintf(stderr, "Invalid queueid = %d\n", res->cmd_qid);
>

Can you please unify the error message for Rx and Tx?

> +			return;
> +		}
> +		printf("RxQ %d used desc count = %d\n", res->cmd_qid, rc);
> +	} else if (!strcmp(res->cmd_dir, "txq")) {
> +		if (rte_eth_tx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
> +			fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",
> +				res->cmd_pid, res->cmd_qid);
> +			return;
> +		}
> +
> +		rc = rte_eth_tx_queue_count(res->cmd_pid, res->cmd_qid);
> +		if (rc < 0) {
> +			fprintf(stderr, "Tx queue count get failed rc=%d queue_id=%d\n", rc,
> +				res->cmd_qid);
> +			return;
> +		}
> +		printf("TxQ %d used desc count = %d\n", res->cmd_qid, rc);
> +	}
> +}
> +
> +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_show =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_show, "show");
> +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_port =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_port, "port");
> +static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_pid =
> +	TOKEN_NUM_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_pid, RTE_UINT16);
> +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_dir =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_dir, "rxq#txq");
> +static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_qid =
> +	TOKEN_NUM_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_qid, RTE_UINT16);
> +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_desc =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_desc, "desc");
> +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_used =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_count, "used");
> +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_count =
> +	TOKEN_STRING_INITIALIZER
> +		(struct cmd_show_rx_tx_queue_desc_used_count_result,
> +		 cmd_count, "count");
> +static cmdline_parse_inst_t cmd_show_rx_tx_queue_desc_used_count = {
> +	.f = cmd_show_rx_tx_queue_desc_used_count_parsed,
> +	.data = NULL,
> +	.help_str = "show port <port_id> rxq|txq <queue_id> desc used count",
> +	.tokens = {
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_show,
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_port,
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_pid,
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_dir,
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_qid,
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_desc,
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_used,
> +		(void *)&cmd_show_rx_tx_queue_desc_used_count_count,
> +		NULL,
> +	},
> +};
> +
>  /* *** display rx/tx descriptor status *** */
>  struct cmd_show_rx_tx_desc_status_result {
>  	cmdline_fixed_string_t cmd_show;
> @@ -12745,90 +12843,6 @@ static cmdline_parse_inst_t cmd_show_rx_tx_desc_status = {
>  	},
>  };
>  
> -/* *** display rx queue desc used count *** */
> -struct cmd_show_rx_queue_desc_used_count_result {
> -	cmdline_fixed_string_t cmd_show;
> -	cmdline_fixed_string_t cmd_port;
> -	cmdline_fixed_string_t cmd_rxq;
> -	cmdline_fixed_string_t cmd_desc;
> -	cmdline_fixed_string_t cmd_used;
> -	cmdline_fixed_string_t cmd_count;
> -	portid_t cmd_pid;
> -	portid_t cmd_qid;
> -};
> -
> -static void
> -cmd_show_rx_queue_desc_used_count_parsed(void *parsed_result,
> -		__rte_unused struct cmdline *cl,
> -		__rte_unused void *data)
> -{
> -	struct cmd_show_rx_queue_desc_used_count_result *res = parsed_result;
> -	int rc;
> -
> -	if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
> -		fprintf(stderr,
> -			"Invalid input: port id = %d, queue id = %d\n",
> -			res->cmd_pid, res->cmd_qid);
> -		return;
> -	}
> -
> -	rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid);
> -	if (rc < 0) {
> -		fprintf(stderr, "Invalid queueid = %d\n", res->cmd_qid);
> -		return;
> -	}
> -	printf("Used desc count = %d\n", rc);
> -}
> -
> -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_show =
> -	TOKEN_STRING_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_show, "show");
> -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_port =
> -	TOKEN_STRING_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_port, "port");
> -static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_pid =
> -	TOKEN_NUM_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_pid, RTE_UINT16);
> -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_rxq =
> -	TOKEN_STRING_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_rxq, "rxq");
> -static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_qid =
> -	TOKEN_NUM_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_qid, RTE_UINT16);
> -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_desc =
> -	TOKEN_STRING_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_count, "desc");
> -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_used =
> -	TOKEN_STRING_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_count, "used");
> -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_count =
> -	TOKEN_STRING_INITIALIZER
> -		(struct cmd_show_rx_queue_desc_used_count_result,
> -		 cmd_count, "count");
> -static cmdline_parse_inst_t cmd_show_rx_queue_desc_used_count = {
> -	.f = cmd_show_rx_queue_desc_used_count_parsed,
> -	.data = NULL,
> -	.help_str = "show port <port_id> rxq <queue_id> desc used count",
> -	.tokens = {
> -		(void *)&cmd_show_rx_queue_desc_used_count_show,
> -		(void *)&cmd_show_rx_queue_desc_used_count_port,
> -		(void *)&cmd_show_rx_queue_desc_used_count_pid,
> -		(void *)&cmd_show_rx_queue_desc_used_count_rxq,
> -		(void *)&cmd_show_rx_queue_desc_used_count_qid,
> -		(void *)&cmd_show_rx_queue_desc_used_count_desc,
> -		(void *)&cmd_show_rx_queue_desc_used_count_used,
> -		(void *)&cmd_show_rx_queue_desc_used_count_count,
> -		NULL,
> -	},
> -};
> -
>

Why moving the function up, can you please keep it in same place.


Also can you please update help command output in
'cmd_help_long_parsed()' function at the beggining of the file?

[PATCH v3] app/testpmd: command to get descriptor used count

[skoteshwar]

From: Satha Rao <skoteshwar@marvell.com>

Existing Rx desc used count command extended to get Tx queue
used count.
    testpmd> show port 0 rxq 0 desc used count
    testpmd> show port 0 txq 0 desc used count

Signed-off-by: Satha Rao <skoteshwar@marvell.com>
---
Depends-on: series-30833 ("ethdev: support Tx queue used count")

v2:
 extended rx_queue_desc_used_count command to support Tx
 updated testpmd_app_ug with new command

v3:
 Updated help string, log message as per review comments

 app/test-pmd/cmdline.c                      | 116 ++++++++++++++++------------
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  10 +--
 2 files changed, 70 insertions(+), 56 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f704319..d8ea2b7 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -237,9 +237,8 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"show port (port_id) rxq|txq (queue_id) desc (desc_id) status"
 			"       Show status of rx|tx descriptor.\n\n"
 
-			"show port (port_id) rxq (queue_id) desc used count\n"
-			"    Show current number of filled receive"
-			" packet descriptors.\n\n"
+			"show port (port_id) rxq|txq (queue_id) desc used count\n"
+			"    Show current number of used descriptor count for rx|tx.\n\n"
 
 			"show port (port_id) macs|mcast_macs"
 			"       Display list of mac addresses added to port.\n\n"
@@ -12745,11 +12744,11 @@ struct cmd_show_rx_tx_desc_status_result {
 	},
 };
 
-/* *** display rx queue desc used count *** */
-struct cmd_show_rx_queue_desc_used_count_result {
+/* *** display rx/tx queue descriptor used count *** */
+struct cmd_show_rx_tx_queue_desc_used_count_result {
 	cmdline_fixed_string_t cmd_show;
 	cmdline_fixed_string_t cmd_port;
-	cmdline_fixed_string_t cmd_rxq;
+	cmdline_fixed_string_t cmd_dir;
 	cmdline_fixed_string_t cmd_desc;
 	cmdline_fixed_string_t cmd_used;
 	cmdline_fixed_string_t cmd_count;
@@ -12758,73 +12757,88 @@ struct cmd_show_rx_queue_desc_used_count_result {
 };
 
 static void
-cmd_show_rx_queue_desc_used_count_parsed(void *parsed_result,
-		__rte_unused struct cmdline *cl,
-		__rte_unused void *data)
+cmd_show_rx_tx_queue_desc_used_count_parsed(void *parsed_result, __rte_unused struct cmdline *cl,
+					    __rte_unused void *data)
 {
-	struct cmd_show_rx_queue_desc_used_count_result *res = parsed_result;
+	struct cmd_show_rx_tx_queue_desc_used_count_result *res = parsed_result;
 	int rc;
 
-	if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
-		fprintf(stderr,
-			"Invalid input: port id = %d, queue id = %d\n",
-			res->cmd_pid, res->cmd_qid);
-		return;
-	}
+	if (!strcmp(res->cmd_dir, "rxq")) {
+		if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
+			fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",
+				res->cmd_pid, res->cmd_qid);
+			return;
+		}
 
-	rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid);
-	if (rc < 0) {
-		fprintf(stderr, "Invalid queueid = %d\n", res->cmd_qid);
-		return;
+		rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid);
+		if (rc < 0) {
+			fprintf(stderr, "Rx queue count get failed rc=%d queue_id=%d\n", rc,
+				res->cmd_qid);
+			return;
+		}
+		printf("RxQ %d used desc count = %d\n", res->cmd_qid, rc);
+	} else if (!strcmp(res->cmd_dir, "txq")) {
+		if (rte_eth_tx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) {
+			fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n",
+				res->cmd_pid, res->cmd_qid);
+			return;
+		}
+
+		rc = rte_eth_tx_queue_count(res->cmd_pid, res->cmd_qid);
+		if (rc < 0) {
+			fprintf(stderr, "Tx queue count get failed rc=%d queue_id=%d\n", rc,
+				res->cmd_qid);
+			return;
+		}
+		printf("TxQ %d used desc count = %d\n", res->cmd_qid, rc);
 	}
-	printf("Used desc count = %d\n", rc);
 }
 
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_show =
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_show =
 	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
 		 cmd_show, "show");
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_port =
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_port =
 	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
 		 cmd_port, "port");
-static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_pid =
+static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_pid =
 	TOKEN_NUM_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
 		 cmd_pid, RTE_UINT16);
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_rxq =
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_dir =
 	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_rxq, "rxq");
-static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_qid =
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_dir, "rxq#txq");
+static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_qid =
 	TOKEN_NUM_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
 		 cmd_qid, RTE_UINT16);
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_desc =
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_desc =
 	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
-		 cmd_count, "desc");
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_used =
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
+		 cmd_desc, "desc");
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_used =
 	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
 		 cmd_count, "used");
-static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_count =
+static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_count =
 	TOKEN_STRING_INITIALIZER
-		(struct cmd_show_rx_queue_desc_used_count_result,
+		(struct cmd_show_rx_tx_queue_desc_used_count_result,
 		 cmd_count, "count");
-static cmdline_parse_inst_t cmd_show_rx_queue_desc_used_count = {
-	.f = cmd_show_rx_queue_desc_used_count_parsed,
+static cmdline_parse_inst_t cmd_show_rx_tx_queue_desc_used_count = {
+	.f = cmd_show_rx_tx_queue_desc_used_count_parsed,
 	.data = NULL,
-	.help_str = "show port <port_id> rxq <queue_id> desc used count",
+	.help_str = "show port <port_id> rxq|txq <queue_id> desc used count",
 	.tokens = {
-		(void *)&cmd_show_rx_queue_desc_used_count_show,
-		(void *)&cmd_show_rx_queue_desc_used_count_port,
-		(void *)&cmd_show_rx_queue_desc_used_count_pid,
-		(void *)&cmd_show_rx_queue_desc_used_count_rxq,
-		(void *)&cmd_show_rx_queue_desc_used_count_qid,
-		(void *)&cmd_show_rx_queue_desc_used_count_desc,
-		(void *)&cmd_show_rx_queue_desc_used_count_used,
-		(void *)&cmd_show_rx_queue_desc_used_count_count,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_show,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_port,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_pid,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_dir,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_qid,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_desc,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_used,
+		(void *)&cmd_show_rx_tx_queue_desc_used_count_count,
 		NULL,
 	},
 };
@@ -13345,7 +13359,7 @@ struct cmd_config_tx_affinity_map {
 	(cmdline_parse_inst_t *)&cmd_config_tx_metadata_specific,
 	(cmdline_parse_inst_t *)&cmd_show_tx_metadata,
 	(cmdline_parse_inst_t *)&cmd_show_rx_tx_desc_status,
-	(cmdline_parse_inst_t *)&cmd_show_rx_queue_desc_used_count,
+	(cmdline_parse_inst_t *)&cmd_show_rx_tx_queue_desc_used_count,
 	(cmdline_parse_inst_t *)&cmd_set_raw,
 	(cmdline_parse_inst_t *)&cmd_show_set_raw,
 	(cmdline_parse_inst_t *)&cmd_show_set_raw_all,
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 53923ad..468f70b 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -264,13 +264,13 @@ Display information for a given port's RX/TX descriptor status::
 
    testpmd> show port (port_id) (rxq|txq) (queue_id) desc (desc_id) status
 
-show rxq desc used count
-~~~~~~~~~~~~~~~~~~~~~~~~
+show desc used count(rxq|txq)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Display the number of receive packet descriptors currently filled by hardware
-and ready to be processed by the driver on a given RX queue::
+Display the number of packet descriptors currently used by hardware for a given
+port's RX/TX queue::
 
-   testpmd> show port (port_id) rxq (queue_id) desc used count
+   testpmd> show port (port_id) (rxq|txq) (queue_id) desc used count
 
 show config
 ~~~~~~~~~~~
-- 
1.8.3.1

Re: [PATCH v3] app/testpmd: command to get descriptor used count

[Ferruh Yigit]

On 2/7/2024 5:04 PM, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> Existing Rx desc used count command extended to get Tx queue
> used count.
>     testpmd> show port 0 rxq 0 desc used count
>     testpmd> show port 0 txq 0 desc used count
> 
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
>

Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.