* [PATCH] net/softnic: fix memory free
@ 2022-09-27 4:42 Harshad Narayane
2022-10-03 23:25 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Harshad Narayane @ 2022-09-27 4:42 UTC (permalink / raw)
To: dev; +Cc: Kamalakannan R, Cristian Dumitrescu
Coverity issue: 380975
Coverity issue: 380977
Fixes: 02270033 ("net/softnic: add pipeline library build command")
Fix memory resource free for buffer allocation failure at pipeline
library build.
Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>
Signed-off-by: Kamalakannan R <kamalakannan.r@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
drivers/net/softnic/rte_eth_softnic_cli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c
index e46383352b..085523fe03 100644
--- a/drivers/net/softnic/rte_eth_softnic_cli.c
+++ b/drivers/net/softnic/rte_eth_softnic_cli.c
@@ -327,7 +327,7 @@ cmd_softnic_pipeline_libbuild(struct pmd_internals *softnic __rte_unused,
buffer = malloc(MAX_LINE_SIZE);
if (!buffer) {
snprintf(out, out_size, MSG_OUT_OF_MEMORY);
- return;
+ goto free;
}
snprintf(buffer,
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/softnic: fix memory free
2022-09-27 4:42 [PATCH] net/softnic: fix memory free Harshad Narayane
@ 2022-10-03 23:25 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2022-10-03 23:25 UTC (permalink / raw)
To: Harshad Narayane, dev; +Cc: Kamalakannan R, Cristian Dumitrescu
On 9/27/2022 5:42 AM, Harshad Narayane wrote:
> Coverity issue: 380975
> Coverity issue: 380977
> Fixes: 02270033 ("net/softnic: add pipeline library build command")
>
> Fix memory resource free for buffer allocation failure at pipeline
> library build.
>
> Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>
> Signed-off-by: Kamalakannan R <kamalakannan.r@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-03 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 4:42 [PATCH] net/softnic: fix memory free Harshad Narayane
2022-10-03 23:25 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).