From: Ranjit Menon <ranjit.menon@intel.com>
To: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
<dev@dpdk.org>, <thomas@monjalon.net>, <ocardona@microsoft.com>,
<haramakr@linux.microsoft.com>, <pallavi.kadam@intel.com>
Cc: <dmitry.kozliuk@gmail.com>, <dmitrym@microsoft.com>,
Narcisa Vasile <navasile@microsoft.com>,
Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel driver
Date: Thu, 20 Aug 2020 18:32:02 -0700 [thread overview]
Message-ID: <c0c8dd7c-e1fb-5c35-0436-23a3452a28fa@intel.com> (raw)
In-Reply-To: <1597962235-4787-1-git-send-email-navasile@linux.microsoft.com>
Hi, Naty
On 8/20/2020 3:23 PM, Narcisa Ana Maria Vasile wrote:
> From: Narcisa Vasile <navasile@microsoft.com>
>
> The Windows NetUIO kernel driver allows the DPDK userspace
> application to directly access the hardware.
>
> Cc: Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
> Cc: Omar Cardona <ocardona@microsoft.com>
> Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> ---
>
> v2:
> Fix license message in each file
> Minor fixes in README
> Remove RC file as it is autogenerated
> Remove HW Ids from Inf
> Resubmit as single patch
>
> .gitattributes | 4 +
> .gitignore | 2 +
> windows/netuio/kernel/README_NetUIO.rst | 64 +++
> .../netuio/kernel/windows/netuio/netuio.inf | 78 ++++
> .../netuio/kernel/windows/netuio/netuio_dev.c | 388 +++++++++++++++++
> .../netuio/kernel/windows/netuio/netuio_dev.h | 61 +++
> .../netuio/kernel/windows/netuio/netuio_drv.c | 146 +++++++
> .../netuio/kernel/windows/netuio/netuio_drv.h | 32 ++
> .../kernel/windows/netuio/netuio_interface.h | 73 ++++
> .../kernel/windows/netuio/netuio_queue.c | 397 ++++++++++++++++++
> .../kernel/windows/netuio/netuio_queue.h | 31 ++
> .../netuio/kernel/windows/netuio/resource.h | 14 +
> .../mk/exec-env/windows/netuio/netuio.sln | 24 ++
> .../mk/exec-env/windows/netuio/netuio.vcxproj | 113 +++++
> .../windows/netuio/netuio.vcxproj.filters | 54 +++
> .../windows/netuio/netuio.vcxproj.user | 11 +
> 16 files changed, 1492 insertions(+)
> create mode 100644 .gitattributes
> create mode 100644 .gitignore
> create mode 100644 windows/netuio/kernel/README_NetUIO.rst
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio.inf
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio_dev.c
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio_dev.h
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio_drv.c
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio_drv.h
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio_interface.h
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio_queue.c
> create mode 100644 windows/netuio/kernel/windows/netuio/netuio_queue.h
> create mode 100644 windows/netuio/kernel/windows/netuio/resource.h
> create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.sln
> create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj
> create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj.filters
> create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj.user
I haven't reviewed the code yet, but a few general suggestions and
observations:
1. This code is going into the dpdk-kmods repo, so we don't need the
four-level deep directory path for the source.
2. The code can simply be in the windows/netuio directory (don't need
'kernel')
3. The 'virt2phys' module that is already in the repo puts the
build-related files (project files, solution files etc) in the same
folder as the source files. We should do the same here. We don't need
the mk/exec-env subfolder for these files. They can be in the same
directory as the source.
4. Remove the .vcxproj.user file from the patch. It is not required.
5. The README should be renamed to simply README.rst and it can also be
in this windows/netuio folder
6. The existing README.rst in the windows folder contains information on
how to build and load kernel modules in Windows. This new README can
reference the root-level README, if required. (Also some of the
information in this new README is out-of-date. I'll review that separately)
ranjit m.
next prev parent reply other threads:[~2020-08-21 1:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 22:23 Narcisa Ana Maria Vasile
2020-08-21 1:32 ` Ranjit Menon [this message]
2020-09-09 18:58 ` Narcisa Ana Maria Vasile
2020-08-24 20:53 ` Dmitry Kozlyuk
2020-09-09 18:53 ` Narcisa Ana Maria Vasile
2020-09-13 21:39 ` Dmitry Kozlyuk
2020-09-09 18:41 ` [dpdk-dev] [PATCH v3] " Narcisa Ana Maria Vasile
2020-09-13 21:39 ` Dmitry Kozlyuk
2020-09-19 2:52 ` [dpdk-dev] [PATCH v4] " Narcisa Ana Maria Vasile
2020-09-22 21:25 ` Dmitry Kozlyuk
2020-09-22 21:36 ` Ranjit Menon
2020-10-01 22:55 ` [dpdk-dev] [PATCH v5] " Narcisa Ana Maria Vasile
2020-10-02 18:21 ` Ranjit Menon
2020-10-05 19:34 ` Narcisa Ana Maria Vasile
2020-10-14 9:29 ` Thomas Monjalon
2020-10-02 18:33 ` Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0c8dd7c-e1fb-5c35-0436-23a3452a28fa@intel.com \
--to=ranjit.menon@intel.com \
--cc=Harini.Ramakrishnan@microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=haramakr@linux.microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=navasile@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).