From: Olivier Matz <olivier.matz@6wind.com>
To: "Montorsi, Francesco" <fmontorsi@empirix.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Proposal: enable redirection of DPDK logs from the user app
Date: Wed, 5 Oct 2016 14:18:38 +0200 [thread overview]
Message-ID: <c9b811de-28d7-f4da-5a5c-2038779e4b6b@6wind.com> (raw)
In-Reply-To: <4b3ed268f2584b4aaf251ba39f8c90bf@bilemail1.empirix.com>
Hi Francesco,
On 10/04/2016 02:28 PM, Montorsi, Francesco wrote:
> Hi Olivier,
>
>> It seems the mailing list stripped your patch sent as attachment.
>> Can you please resend it again in the body of the mail?
> You're right sorry. It's attached at the end of this mail.
>
>> I think we can already redirect logs to a file by using
>> fopencookie() + rte_openlog_stream(). Did you already check these
>> functions?
>
> Yes, but to be honest, that seems a troublesome solution for
> something as easy as logging a string; e.g. by using fopencookie()
> approach, you don't have the concept of "log message", you just
> provide a function that must write a block of bytes somewhere.
> Typically instead, you need to know where a log message starts and
> ends, to e.g., add prefixes/postfixes to it.
I'm not sure that true if you call setbuf(log_stream, NULL).
In that case, it looks easy to prefix / postfix messages with a
fopencookie callback like:
/* example on stdout */
ssize_t
simple_write(void *c, const char *buf, size_t size)
{
ssize_t ret1, ret2, ret3;
ret1 = fwrite("<", 1, 1, stdout);
if (ret1 == 0)
return 0;
ret2 = fwrite(buf, size, 1, stdout);
if (ret2 == 0)
return 0;
ret3 = fwrite(">", 1, 1, stdout);
if (ret3 == 0)
return 0;
return ret1 + ret2 + ret3;
}
> Indeed, most of the C/C++ (open source) libraries have some simple
> hook that allows the user to have more control on logging... I think
> DPDK should be no exception... :)
I understand that the current API is a bit more complex, but I don't
feel there is any blocking issue to do what you want. What do you think?
Also, I know you've said your patch needs some rework, but as you've
also said you are using it, maybe it would be useful for you to know:
- it makes use of a global variable 'log_buffer', shared by all the
pthreads, which can lead to crashes
- it strips the log messages to 4095 chars
Regards,
Olivier
next prev parent reply other threads:[~2016-10-05 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 10:24 Montorsi, Francesco
2016-10-04 11:26 ` Olivier Matz
2016-10-04 12:28 ` Montorsi, Francesco
2016-10-05 12:18 ` Olivier Matz [this message]
2016-10-05 13:26 ` Montorsi, Francesco
2016-10-05 14:03 ` Olivier Matz
2016-10-05 21:22 ` Matthew Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9b811de-28d7-f4da-5a5c-2038779e4b6b@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=fmontorsi@empirix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).