From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] eal: default to one memory channel if not specified
Date: Wed, 14 Oct 2015 13:22:04 +0300 [thread overview]
Message-ID: <d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com> (raw)
Obtaining the correct value, especially from a running system, can
be anything from difficult to plain impossible. Since the value is
merely an optimization and does not affect functionality otherwise,
its pointless to force such a guess on users initially, such things
belong to performance tuning phase.
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
lib/librte_eal/common/eal_common_options.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 1f459ac..28f10a2 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -104,7 +104,7 @@ eal_reset_internal_config(struct internal_config *internal_cfg)
internal_cfg->memory = 0;
internal_cfg->force_nrank = 0;
- internal_cfg->force_nchannel = 0;
+ internal_cfg->force_nchannel = 1;
internal_cfg->hugefile_prefix = HUGEFILE_PREFIX_DEFAULT;
internal_cfg->hugepage_dir = NULL;
internal_cfg->force_sockets = 0;
@@ -834,12 +834,6 @@ eal_check_common_options(struct internal_config *internal_cfg)
RTE_LOG(ERR, EAL, "Invalid process type specified\n");
return -1;
}
- if (internal_cfg->process_type == RTE_PROC_PRIMARY &&
- internal_cfg->force_nchannel == 0) {
- RTE_LOG(ERR, EAL, "Number of memory channels (-n) not "
- "specified\n");
- return -1;
- }
if (index(internal_cfg->hugefile_prefix, '%') != NULL) {
RTE_LOG(ERR, EAL, "Invalid char, '%%', in --"OPT_FILE_PREFIX" "
"option\n");
@@ -869,7 +863,7 @@ eal_check_common_options(struct internal_config *internal_cfg)
void
eal_common_usage(void)
{
- printf("-c COREMASK|-l CORELIST -n CHANNELS [options]\n\n"
+ printf("-c COREMASK|-l CORELIST [options]\n\n"
"EAL common options:\n"
" -c COREMASK Hexadecimal bitmask of cores to run on\n"
" -l CORELIST List of cores to run on\n"
--
2.4.3
next reply other threads:[~2015-10-14 10:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 10:22 Panu Matilainen [this message]
2015-10-14 11:45 ` David Marchand
2015-10-14 12:04 ` Panu Matilainen
2015-10-14 13:05 ` Bruce Richardson
2015-10-15 11:49 ` [dpdk-dev] [PATCH 0/2] Provide reasonable default to -n Panu Matilainen
2015-10-15 11:49 ` [dpdk-dev] [PATCH 1/2] mempool: use a better default for number of memory channels Panu Matilainen
2015-10-15 11:49 ` [dpdk-dev] [PATCH 2/2] eal: make the -n argument optional Panu Matilainen
2015-10-15 12:03 ` [dpdk-dev] [PATCH 0/2] Provide reasonable default to -n David Marchand
2015-10-26 16:51 ` Thomas Monjalon
2015-10-15 12:10 ` Mcnamara, John
2015-10-15 12:36 ` Panu Matilainen
2015-10-15 13:12 ` Mcnamara, John
2015-10-26 16:50 ` Thomas Monjalon
2015-10-26 16:56 ` Thomas Monjalon
2015-10-27 7:19 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).