* [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload
@ 2018-05-07 1:26 Qi Zhang
2018-05-07 5:08 ` Xing, Beilei
0 siblings, 1 reply; 5+ messages in thread
From: Qi Zhang @ 2018-05-07 1:26 UTC (permalink / raw)
To: ferruh.yigit; +Cc: beilei.xing, dev, Qi Zhang
Expose the missing mbuf fast free capability since i40 does
support it.
Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 92ee6c5ae..e866c3081 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3301,7 +3301,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_RX_OFFLOAD_VLAN_FILTER |
DEV_RX_OFFLOAD_JUMBO_FRAME;
- dev_info->tx_queue_offload_capa = 0;
+ dev_info->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;
dev_info->tx_offload_capa =
DEV_TX_OFFLOAD_VLAN_INSERT |
DEV_TX_OFFLOAD_QINQ_INSERT |
@@ -3314,7 +3314,9 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
DEV_TX_OFFLOAD_GRE_TNL_TSO |
DEV_TX_OFFLOAD_IPIP_TNL_TSO |
- DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+ DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+ dev_info->tx_queue_offload_capa;
+
dev_info->dev_capa =
RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
--
2.13.6
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload
2018-05-07 1:26 [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload Qi Zhang
@ 2018-05-07 5:08 ` Xing, Beilei
2018-05-08 16:50 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Xing, Beilei @ 2018-05-07 5:08 UTC (permalink / raw)
To: Zhang, Qi Z, Yigit, Ferruh; +Cc: dev
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, May 7, 2018 9:26 AM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: [PATCH] net/i40e: fix missing mbuf fast free offload
>
> Expose the missing mbuf fast free capability since i40 does support it.
>
> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 92ee6c5ae..e866c3081 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3301,7 +3301,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_RX_OFFLOAD_VLAN_FILTER |
> DEV_RX_OFFLOAD_JUMBO_FRAME;
>
> - dev_info->tx_queue_offload_capa = 0;
> + dev_info->tx_queue_offload_capa =
> DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> dev_info->tx_offload_capa =
> DEV_TX_OFFLOAD_VLAN_INSERT |
> DEV_TX_OFFLOAD_QINQ_INSERT |
> @@ -3314,7 +3314,9 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
> DEV_TX_OFFLOAD_GRE_TNL_TSO |
> DEV_TX_OFFLOAD_IPIP_TNL_TSO |
> - DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
> + DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
> + dev_info->tx_queue_offload_capa;
> +
> dev_info->dev_capa =
> RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
> RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
> --
> 2.13.6
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload
2018-05-07 5:08 ` Xing, Beilei
@ 2018-05-08 16:50 ` Ferruh Yigit
2018-05-10 22:09 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2018-05-08 16:50 UTC (permalink / raw)
To: Xing, Beilei, Zhang, Qi Z; +Cc: dev
On 5/7/2018 6:08 AM, Xing, Beilei wrote:
>
>
>> -----Original Message-----
>> From: Zhang, Qi Z
>> Sent: Monday, May 7, 2018 9:26 AM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Cc: Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Subject: [PATCH] net/i40e: fix missing mbuf fast free offload
>>
>> Expose the missing mbuf fast free capability since i40 does support it.
>>
>> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
>>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload
2018-05-08 16:50 ` Ferruh Yigit
@ 2018-05-10 22:09 ` Ferruh Yigit
2018-05-11 0:39 ` Zhang, Qi Z
0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2018-05-10 22:09 UTC (permalink / raw)
To: Xing, Beilei, Zhang, Qi Z; +Cc: dev
On 5/8/2018 5:50 PM, Ferruh Yigit wrote:
> On 5/7/2018 6:08 AM, Xing, Beilei wrote:
>>
>>
>>> -----Original Message-----
>>> From: Zhang, Qi Z
>>> Sent: Monday, May 7, 2018 9:26 AM
>>> To: Yigit, Ferruh <ferruh.yigit@intel.com>
>>> Cc: Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org; Zhang, Qi Z
>>> <qi.z.zhang@intel.com>
>>> Subject: [PATCH] net/i40e: fix missing mbuf fast free offload
>>>
>>> Expose the missing mbuf fast free capability since i40 does support it.
>>>
>>> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
>>>
>>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
>>
>> Acked-by: Beilei Xing <beilei.xing@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
Hi Beilei, Qi,
This patch is preventing i40e to use Tx avx2 fast path and cause a performance
drop, you need to allow this offload in Tx data path selection logic.
Dropping this patch from next-net, updated patch status in patchwork, please
send a new version.
Thanks,
ferruh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload
2018-05-10 22:09 ` Ferruh Yigit
@ 2018-05-11 0:39 ` Zhang, Qi Z
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2018-05-11 0:39 UTC (permalink / raw)
To: Yigit, Ferruh, Xing, Beilei; +Cc: dev
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, May 11, 2018 6:10 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload
>
> On 5/8/2018 5:50 PM, Ferruh Yigit wrote:
> > On 5/7/2018 6:08 AM, Xing, Beilei wrote:
> >>
> >>
> >>> -----Original Message-----
> >>> From: Zhang, Qi Z
> >>> Sent: Monday, May 7, 2018 9:26 AM
> >>> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> >>> Cc: Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org; Zhang, Qi Z
> >>> <qi.z.zhang@intel.com>
> >>> Subject: [PATCH] net/i40e: fix missing mbuf fast free offload
> >>>
> >>> Expose the missing mbuf fast free capability since i40 does support it.
> >>>
> >>> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> >>>
> >>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> >>
> >> Acked-by: Beilei Xing <beilei.xing@intel.com>
> >
> > Applied to dpdk-next-net/master, thanks.
>
> Hi Beilei, Qi,
>
> This patch is preventing i40e to use Tx avx2 fast path and cause a performance
> drop, you need to allow this offload in Tx data path selection logic.
OK, I missed that, will fix. thanks.
>
> Dropping this patch from next-net, updated patch status in patchwork, please
> send a new version.
>
> Thanks,
> ferruh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-11 0:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 1:26 [dpdk-dev] [PATCH] net/i40e: fix missing mbuf fast free offload Qi Zhang
2018-05-07 5:08 ` Xing, Beilei
2018-05-08 16:50 ` Ferruh Yigit
2018-05-10 22:09 ` Ferruh Yigit
2018-05-11 0:39 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).