From: Andrew Rybchenko <arybchenko@solarflare.com> To: Andy Green <andy@warmcat.com>, <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 12/18] drivers: net: sfc: fix another strncpy size and NUL Date: Tue, 8 May 2018 10:36:57 +0300 Message-ID: <e2e3bb52-6880-6611-21d8-6be805dfac7b@solarflare.com> (raw) In-Reply-To: <152575382842.56689.4589071928538784307.stgit@localhost.localdomain> Many thanks. I guess the most of below notes are applicable to many other patches in the series. Signed-off-by: , Fixes: and Cc: stable@dpdk.org tags are missing. See [1]. Changeset summary should start from "net/sfc: " I.e. something like: net/sfc: fix strncpy size and NUL (it looks like "another" is useless in the original subject) In general all patches should pass ./devtools/check-git-log.sh and ./devtools/checkpatches.sh (which requires path to Linux kernel checkpatches.pl). Andrew. [1] http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line On 05/08/2018 07:30 AM, Andy Green wrote: > --- > drivers/net/sfc/sfc_ethdev.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c > index e9bb283e0..bd5f17f33 100644 > --- a/drivers/net/sfc/sfc_ethdev.c > +++ b/drivers/net/sfc/sfc_ethdev.c > @@ -662,10 +662,13 @@ sfc_xstats_get_names(struct rte_eth_dev *dev, > > for (i = 0; i < EFX_MAC_NSTATS; ++i) { > if (EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i)) { > - if (xstats_names != NULL && nstats < xstats_count) > + if (xstats_names != NULL && nstats < xstats_count) { > strncpy(xstats_names[nstats].name, > efx_mac_stat_name(sa->nic, i), > - sizeof(xstats_names[0].name)); > + sizeof(xstats_names[0].name) - 1); > + xstats_names[0].name[ > + sizeof(xstats_names[0].name) - 1] = '\0'; > + } In fact strlcpy() should be used. > nstats++; > } > } >
next prev parent reply other threads:[~2018-05-08 7:37 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-08 4:29 [dpdk-dev] [PATCH 00/18] Fix build on gcc8 and various bugs Andy Green 2018-05-08 4:29 ` [dpdk-dev] [PATCH 01/18] lib: ret_table: workaround hash function cast error Andy Green 2018-05-08 4:29 ` [dpdk-dev] [PATCH 02/18] drivers: bus: pci: fix strncpy dangerous code Andy Green 2018-05-08 8:57 ` Bruce Richardson 2018-05-08 4:29 ` [dpdk-dev] [PATCH 03/18] drivers: bus: dpaa: fix inconsistent struct alignment Andy Green 2018-05-08 4:29 ` [dpdk-dev] [PATCH 04/18] drivers: net: axgbe: fix broken eeprom string comp Andy Green 2018-05-08 4:29 ` [dpdk-dev] [PATCH 05/18] drivers: net: nfp: nfpcore: fix strncpy misuse Andy Green 2018-05-08 8:58 ` Bruce Richardson 2018-05-08 9:00 ` Andy Green 2018-05-08 9:03 ` Bruce Richardson 2018-05-08 4:29 ` [dpdk-dev] [PATCH 06/18] drivers: net: nfp: nfpcore fix off-by-one and no NUL on strncpy use Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 07/18] drivers: net: nfp: don't memcpy out of source range Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 08/18] drivers: net: nfp: fix buffer overflow in fw_name Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL Andy Green 2018-05-08 17:59 ` Shaikh, Shahed 2018-05-08 19:53 ` Bruce Richardson 2018-05-08 20:02 ` Shaikh, Shahed 2018-05-08 22:07 ` Andy Green 2018-05-08 23:33 ` Shaikh, Shahed 2018-05-08 4:30 ` [dpdk-dev] [PATCH 10/18] drivers: net: qede: fix broken strncpy Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 11/18] drivers:net:sfc: fix strncpy length Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 12/18] drivers: net: sfc: fix another strncpy size and NUL Andy Green 2018-05-08 7:36 ` Andrew Rybchenko [this message] 2018-05-08 8:18 ` Andy Green 2018-05-08 9:02 ` Bruce Richardson 2018-05-08 9:08 ` Andrew Rybchenko 2018-05-08 4:30 ` [dpdk-dev] [PATCH 13/18] drivers: net: vdev: readlink inputs cannot be aliased Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 14/18] drivers: net: vdev: fix 3 x strncpy misuse Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 15/18] test-pmd: can't find include Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 16/18] app: fix sprintf overrun bug Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 17/18] app: test-bbdev: strcpy ok for allocated string Andy Green 2018-05-08 4:30 ` [dpdk-dev] [PATCH 18/18] app: test-bbdev: strcpy ok for allocated string 2 Andy Green
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e2e3bb52-6880-6611-21d8-6be805dfac7b@solarflare.com \ --to=arybchenko@solarflare.com \ --cc=andy@warmcat.com \ --cc=dev@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git