From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Joyce Kong <Joyce.Kong@arm.com>,
"huzaifa.rahman" <huzaifa.rahman@emumba.com>,
"jgrajcia@cisco.com" <jgrajcia@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues
Date: Tue, 4 Oct 2022 17:53:17 +0300 [thread overview]
Message-ID: <e326ba0f-396e-2ef6-3cf3-8a05584373db@oktetlabs.ru> (raw)
In-Reply-To: <AS4PR08MB77124977331CC5A4E0956B4992639@AS4PR08MB7712.eurprd08.prod.outlook.com>
On 8/8/22 13:39, Joyce Kong wrote:
> Hi Huzaifa,
>
> This patch looks good to me.
> And would you please help review my memif patches?
> https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@arm.com/
>
> Thanks,
> Joyce
>
>> -----Original Message-----
>> From: huzaifa.rahman <huzaifa.rahman@emumba.com>
>> Sent: Tuesday, July 26, 2022 6:16 PM
>> To: jgrajcia@cisco.com
>> Cc: dev@dpdk.org; huzaifa.rahman <huzaifa.rahman@emumba.com>
>> Subject: [PATCH] memif: memif driver does not crashes when there's
>> different N of TX and RX queues
> net/memif: fix memif crash with different Tx Rx queues
>
>>
>> Bugzilla ID: 734
>>
>> there's a bug in memif_stats_get() function due to confusion between C2S
>> (client->server) and S2C (server->client) rings, causing a crash if there's a
>> different number of RX and TX queues.
>>
>> this is fixed by selectiing the correct rings for RX and TX i.e for RX, S2C rings
>> are selected and for TX, C2S rings are selected.
>>
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> Cc: stable@dpdk.org
>
>> Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
> Reviewed-by: Joyce Kong <joyce.kong@arm.com>
Fixed above on applying.
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2022-10-04 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:16 huzaifa.rahman
2022-08-08 10:39 ` Joyce Kong
2022-10-04 14:53 ` Andrew Rybchenko [this message]
2022-11-10 10:02 ` Huzaifa Rahman
2022-11-10 14:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e326ba0f-396e-2ef6-3cf3-8a05584373db@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=Joyce.Kong@arm.com \
--cc=dev@dpdk.org \
--cc=huzaifa.rahman@emumba.com \
--cc=jgrajcia@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).