DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Cc: borisp@mellanox.com
Subject: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition
Date: Thu, 11 Jan 2018 10:15:58 +0100	[thread overview]
Message-ID: <e3a23acbc34bf1a632a32a56580cb403644ca268.1515662067.git.nelio.laranjeiro@6wind.com> (raw)

ESP header is defined in the RFC2406 [1] as Big Endian fields it should use
the corresponding types in DPDK as well.

Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
Cc: borisp@mellanox.com

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

[1] https://tools.ietf.org/html/rfc2406
---
 lib/librte_net/rte_esp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h
index e228af092..148c06e09 100644
--- a/lib/librte_net/rte_esp.h
+++ b/lib/librte_net/rte_esp.h
@@ -49,8 +49,8 @@ extern "C" {
  * ESP Header
  */
 struct esp_hdr {
-	uint32_t spi;  /**< Security Parameters Index */
-	uint32_t seq;  /**< packet sequence number */
+	rte_be32_t spi;  /**< Security Parameters Index */
+	rte_be32_t seq;  /**< packet sequence number */
 } __attribute__((__packed__));
 
 #ifdef __cplusplus
-- 
2.11.0

             reply	other threads:[~2018-01-11  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  9:15 Nelio Laranjeiro [this message]
2018-01-11  9:15 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix SPI byte order in flow item Nelio Laranjeiro
2018-01-11  9:53   ` Akhil Goyal
2018-01-19  9:34   ` De Lara Guarch, Pablo
2018-01-16 14:24 ` [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition Olivier Matz
2018-01-16 15:52   ` Nélio Laranjeiro
2018-01-19  9:33     ` De Lara Guarch, Pablo
2018-01-19  9:34 ` De Lara Guarch, Pablo
2018-01-19  9:35   ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3a23acbc34bf1a632a32a56580cb403644ca268.1515662067.git.nelio.laranjeiro@6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=borisp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).