From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: skoteshwar@marvell.com, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Qiming Yang <qiming.yang@intel.com>,
Wenjun Wu <wenjun1.wu@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jian Wang <jianwang@trustnetic.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@xilinx.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com, bruce.richardson@intel.com,
konstantin.v.ananyev@yandex.ru, jerinj@marvell.com
Subject: Re: [PATCH v2] ethdev: queue rate parameter changed from 16b to 32b
Date: Mon, 26 Sep 2022 16:17:47 +0300 [thread overview]
Message-ID: <e8330f7e-7258-1374-d08e-ed24a0bdd592@oktetlabs.ru> (raw)
In-Reply-To: <1663940715-19619-1-git-send-email-skoteshwar@marvell.com>
On 9/23/22 16:45, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
>
> The rate parameter modified to uint32_t, so that it can work
> for more than 64 Gbps.
>
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
Overall LGTM, but please update release notes and cleanup
deprecation in the next version.
However, the patch requires Acks from bnxt and ixgbe
maintainers.
> diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c
> index 77ecbef..4dc38a2 100644
> --- a/drivers/net/bnxt/rte_pmd_bnxt.c
> +++ b/drivers/net/bnxt/rte_pmd_bnxt.c
> @@ -172,12 +172,12 @@ int rte_pmd_bnxt_set_vf_mac_addr(uint16_t port, uint16_t vf,
> }
>
> int rte_pmd_bnxt_set_vf_rate_limit(uint16_t port, uint16_t vf,
> - uint16_t tx_rate, uint64_t q_msk)
> + uint32_t tx_rate, uint64_t q_msk)
Deprecateion announces rte_eth_set_queue_rate_limit() changes,
but above is a separate API which is not directly related.
I'm OK with the change, but it requires maintainer Ack.
> {
> struct rte_eth_dev *eth_dev;
> struct rte_eth_dev_info dev_info;
> struct bnxt *bp;
> - uint16_t tot_rate = 0;
> + uint32_t tot_rate = 0;
> uint64_t idx;
> int rc;
>
[snip]
> diff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.h
> index c09e9bf..17c820a 100644
> --- a/drivers/net/cnxk/cnxk_ethdev.h
> +++ b/drivers/net/cnxk/cnxk_ethdev.h
> @@ -557,17 +557,14 @@ int cnxk_nix_timesync_write_time(struct rte_eth_dev *eth_dev,
>
> uint64_t cnxk_nix_rxq_mbuf_setup(struct cnxk_eth_dev *dev);
> int cnxk_nix_tm_ops_get(struct rte_eth_dev *eth_dev, void *ops);
> -int cnxk_nix_tm_set_queue_rate_limit(struct rte_eth_dev *eth_dev,
> - uint16_t queue_idx, uint16_t tx_rate);
> -int cnxk_nix_tm_mark_vlan_dei(struct rte_eth_dev *eth_dev, int mark_green,
> - int mark_yellow, int mark_red,
> - struct rte_tm_error *error);
> -int cnxk_nix_tm_mark_ip_ecn(struct rte_eth_dev *eth_dev, int mark_green,
> - int mark_yellow, int mark_red,
> - struct rte_tm_error *error);
> -int cnxk_nix_tm_mark_ip_dscp(struct rte_eth_dev *eth_dev, int mark_green,
> - int mark_yellow, int mark_red,
> - struct rte_tm_error *error);
Above changes for 3 functions look unrelated. Please, avoid it.
> +int cnxk_nix_tm_set_queue_rate_limit(struct rte_eth_dev *eth_dev, uint16_t queue_idx,
> + uint32_t tx_rate);
> +int cnxk_nix_tm_mark_vlan_dei(struct rte_eth_dev *eth_dev, int mark_green, int mark_yellow,
> + int mark_red, struct rte_tm_error *error);
> +int cnxk_nix_tm_mark_ip_ecn(struct rte_eth_dev *eth_dev, int mark_green, int mark_yellow,
> + int mark_red, struct rte_tm_error *error);
> +int cnxk_nix_tm_mark_ip_dscp(struct rte_eth_dev *eth_dev, int mark_green, int mark_yellow,
> + int mark_red, struct rte_tm_error *error);
>
> /* MTR */
> int cnxk_nix_mtr_ops_get(struct rte_eth_dev *dev, void *ops);
> diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c
> index d45e70a..a36f45d 100644
[snip]
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 1dfad0e..9ff8ee0 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2475,7 +2475,7 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
>
> int
> ixgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf,
> - uint16_t tx_rate, uint64_t q_msk)
> + uint32_t tx_rate, uint64_t q_msk)
Requires Ack from ixgbe maintainer
[snip]
next prev parent reply other threads:[~2022-09-26 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 13:16 [PATCH] " skoteshwar
2022-09-23 13:45 ` [PATCH v2] " skoteshwar
2022-09-26 13:17 ` Andrew Rybchenko [this message]
2022-09-28 5:53 ` [EXT] " Satha Koteswara Rao Kottidi
2022-09-28 5:51 ` [PATCH v3] " skoteshwar
2022-09-30 9:57 ` Satha Koteswara Rao Kottidi
2022-10-03 5:42 ` Satha Koteswara Rao Kottidi
2022-10-04 9:40 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8330f7e-7258-1374-d08e-ed24a0bdd592@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=ajit.khaparde@broadcom.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ferruh.yigit@xilinx.com \
--cc=jerinj@marvell.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=ndabilpuram@marvell.com \
--cc=qiming.yang@intel.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=thomas@monjalon.net \
--cc=wenjun1.wu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).