* [dpdk-dev] [PATCH v7 7/9] bonding: per queue stats
@ 2015-10-30 13:56 Tomasz Kulasek
0 siblings, 0 replies; 2+ messages in thread
From: Tomasz Kulasek @ 2015-10-30 13:56 UTC (permalink / raw)
To: dev
Date: Fri, 30 Oct 2015 14:56:02 +0100
Message-Id: <1446213364-11856-8-git-send-email-tomaszx.kulasek@intel.com>
X-Mailer: git-send-email 2.1.4
In-Reply-To: <1446213364-11856-1-git-send-email-tomaszx.kulasek@intel.com>
References: <1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com>
<1446213364-11856-1-git-send-email-tomaszx.kulasek@intel.com>
This patch adds fills bonding port's stats with a sum of corresponding
values taken from bonded slaves, when stats are requested for bonding port.
v5 changes:
- removed queue_stats_mapping_set from eth_dev_ops of bonding device
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 2880f5c..eecb381 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1801,7 +1801,7 @@ bond_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
{
struct bond_dev_private *internals = dev->data->dev_private;
struct rte_eth_stats slave_stats;
- int i;
+ int i, j;
for (i = 0; i < internals->slave_count; i++) {
rte_eth_stats_get(internals->slaves[i].port_id, &slave_stats);
@@ -1820,6 +1820,15 @@ bond_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->rx_pause_xon += slave_stats.rx_pause_xon;
stats->tx_pause_xoff += slave_stats.tx_pause_xoff;
stats->rx_pause_xoff += slave_stats.rx_pause_xoff;
+
+ for (j = 0; j < RTE_ETHDEV_QUEUE_STAT_CNTRS; j++) {
+ stats->q_ipackets[j] += slave_stats.q_ipackets[j];
+ stats->q_opackets[j] += slave_stats.q_opackets[j];
+ stats->q_ibytes[j] += slave_stats.q_ibytes[j];
+ stats->q_obytes[j] += slave_stats.q_obytes[j];
+ stats->q_errors[j] += slave_stats.q_errors[j];
+ }
+
}
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* [dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding
@ 2015-10-16 10:00 Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 " Tomasz Kulasek
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Kulasek @ 2015-10-16 10:00 UTC (permalink / raw)
To: dev
OVERVIEW
--------
1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS makes bonding
device fully RSS-capable, so all slaves are synchronized with its configuration.
This mode is intended to provide RSS configuration as known from "dynamic RSS
configuration for one port" and made slaves transparent for client application
implementation.
2) If .rxmode.mq_mode for bonding device isn't ETH_MQ_RX_RSS, slaves are not
synchronized. That provides an ability to configure them manually. This mode may
be useful when application wants to manage RSS in an unusual way and the
consistency of RSS configuration for slaves isn't required.
Turning on/off RSS mode for slaves when bonding is started is not possible.
Other RSS configuration is propagated over slaves, when bonding device API is
used to do it.
v6 changes:
- patchset reordered
- fixed forward dependency between patch 4/9 and 5/9
v5 changes:
- updated to DPDK 2.2
- removed copyright change from null device source
- removed queue_stats_mapping_set from eth_dev_ops of bonding device
- null pmd cleanups (removed unnecessary malloc, replaced memcpy with
rte_memcpy)
- fixed queues number configuration in null pmd
v4 changes:
- fixed copy-paste error,
- removed example application as too complex and introducing a new
dependency,
- addapted null pmd to be used as testing device for dynamic RSS configuration,
- addapted test units to use null pmd instead of ring pmd,
- ring pmd is not used and changed in this patchset
v3 changes:
- checkpatch cleanups
v2 changes:
- added support for keys other than 40 bytes long,
- now, if RSS key is not set for bonding, it is not set also for slaves,
- fix - full initial RSS configuration before any slave is added was not
possible due to the initially zeroed flow_type_rss_offloads for bonding,
- fix - changed error to warning when slave is synchronizing due to the
bonding's initial configuration (to allow use slaves' drivers not supporting
dynamic RSS configuration in bonding),
- some code cleanups,
- updated documentation,
Tomasz Kulasek (9):
bonding: rss dynamic configuration
null: fix segfault when null_pmd added to bonding
null: extend number of virtual queues
null: export eth_dev_null_create
null: virtual dynamic rss configuration
test: dynamic rss configuration
bonding: per queue stats
doc: fixed spellings and typos
doc: dynamic rss configuration for bonding
app/test/Makefile | 8 +
app/test/test_link_bonding_rssconf.c | 679 ++++++++++++++++++++
.../prog_guide/link_bonding_poll_mode_drv_lib.rst | 42 +-
drivers/net/bonding/rte_eth_bond_api.c | 28 +
drivers/net/bonding/rte_eth_bond_pmd.c | 216 ++++++-
drivers/net/bonding/rte_eth_bond_private.h | 12 +
drivers/net/null/Makefile | 2 +-
drivers/net/null/rte_eth_null.c | 149 ++++-
drivers/net/null/rte_eth_null.h | 40 ++
drivers/net/null/rte_pmd_null_version.map | 7 +
10 files changed, 1151 insertions(+), 32 deletions(-)
create mode 100644 app/test/test_link_bonding_rssconf.c
create mode 100644 drivers/net/null/rte_eth_null.h
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-dev] [PATCH v7 0/9] Dynamic RSS Configuration for Bonding
2015-10-16 10:00 [dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding Tomasz Kulasek
@ 2015-10-30 14:25 ` Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 7/9] bonding: per queue stats Tomasz Kulasek
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Kulasek @ 2015-10-30 14:25 UTC (permalink / raw)
To: dev
OVERVIEW
--------
1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS makes bonding
device fully RSS-capable, so all slaves are synchronized with its configuration.
This mode is intended to provide RSS configuration as known from "dynamic RSS
configuration for one port" and made slaves transparent for client application
implementation.
2) If .rxmode.mq_mode for bonding device isn't ETH_MQ_RX_RSS, slaves are not
synchronized. That provides an ability to configure them manually. This mode may
be useful when application wants to manage RSS in an unusual way and the
consistency of RSS configuration for slaves isn't required.
Turning on/off RSS mode for slaves when bonding is started is not possible.
Other RSS configuration is propagated over slaves, when bonding device API is
used to do it.
v7 changes:
- Makefile for test application changed to not fail when requirements for
test units not met
v6 changes:
- patchset reordered
- fixed forward dependency between patch 4/9 and 5/9
v5 changes:
- updated to DPDK 2.2
- removed copyright change from null device source
- removed queue_stats_mapping_set from eth_dev_ops of bonding device
- null pmd cleanups (removed unnecessary malloc, replaced memcpy with
rte_memcpy)
- fixed queues number configuration in null pmd
v4 changes:
- fixed copy-paste error,
- removed example application as too complex and introducing a new
dependency,
- addapted null pmd to be used as testing device for dynamic RSS configuration,
- addapted test units to use null pmd instead of ring pmd,
- ring pmd is not used and changed in this patchset
v3 changes:
- checkpatch cleanups
v2 changes:
- added support for keys other than 40 bytes long,
- now, if RSS key is not set for bonding, it is not set also for slaves,
- fix - full initial RSS configuration before any slave is added was not
possible due to the initially zeroed flow_type_rss_offloads for bonding,
- fix - changed error to warning when slave is synchronizing due to the
bonding's initial configuration (to allow use slaves' drivers not supporting
dynamic RSS configuration in bonding),
- some code cleanups,
- updated documentation,
Tomasz Kulasek (9):
bonding: rss dynamic configuration
null: fix segfault when null_pmd added to bonding
null: extend number of virtual queues
null: export eth_dev_null_create
null: virtual dynamic rss configuration
test: dynamic rss configuration
bonding: per queue stats
doc: fixed spellings and typos
doc: dynamic rss configuration for bonding
app/test/Makefile | 7 +
app/test/test_link_bonding_rssconf.c | 679 ++++++++++++++++++++
.../prog_guide/link_bonding_poll_mode_drv_lib.rst | 42 +-
drivers/net/bonding/rte_eth_bond_api.c | 28 +
drivers/net/bonding/rte_eth_bond_pmd.c | 216 ++++++-
drivers/net/bonding/rte_eth_bond_private.h | 12 +
drivers/net/null/Makefile | 2 +-
drivers/net/null/rte_eth_null.c | 149 ++++-
drivers/net/null/rte_eth_null.h | 40 ++
drivers/net/null/rte_pmd_null_version.map | 7 +
10 files changed, 1150 insertions(+), 32 deletions(-)
create mode 100644 app/test/test_link_bonding_rssconf.c
create mode 100644 drivers/net/null/rte_eth_null.h
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-dev] [PATCH v7 7/9] bonding: per queue stats
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 " Tomasz Kulasek
@ 2015-10-30 14:25 ` Tomasz Kulasek
0 siblings, 0 replies; 2+ messages in thread
From: Tomasz Kulasek @ 2015-10-30 14:25 UTC (permalink / raw)
To: dev
This patch adds fills bonding port's stats with a sum of corresponding
values taken from bonded slaves, when stats are requested for bonding port.
v5 changes:
- removed queue_stats_mapping_set from eth_dev_ops of bonding device
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 2880f5c..eecb381 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1801,7 +1801,7 @@ bond_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
{
struct bond_dev_private *internals = dev->data->dev_private;
struct rte_eth_stats slave_stats;
- int i;
+ int i, j;
for (i = 0; i < internals->slave_count; i++) {
rte_eth_stats_get(internals->slaves[i].port_id, &slave_stats);
@@ -1820,6 +1820,15 @@ bond_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->rx_pause_xon += slave_stats.rx_pause_xon;
stats->tx_pause_xoff += slave_stats.tx_pause_xoff;
stats->rx_pause_xoff += slave_stats.rx_pause_xoff;
+
+ for (j = 0; j < RTE_ETHDEV_QUEUE_STAT_CNTRS; j++) {
+ stats->q_ipackets[j] += slave_stats.q_ipackets[j];
+ stats->q_opackets[j] += slave_stats.q_opackets[j];
+ stats->q_ibytes[j] += slave_stats.q_ibytes[j];
+ stats->q_obytes[j] += slave_stats.q_obytes[j];
+ stats->q_errors[j] += slave_stats.q_errors[j];
+ }
+
}
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-30 14:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-30 13:56 [dpdk-dev] [PATCH v7 7/9] bonding: per queue stats Tomasz Kulasek
-- strict thread matches above, loose matches on Subject: below --
2015-10-16 10:00 [dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 " Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 7/9] bonding: per queue stats Tomasz Kulasek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).