Re: [dpdk-dev] [PATCH] dedicated queues: delete redundant check valid_bonded_port_id has include check_for_bonded_ethdev, no need to check again.

[=?gb18030?B?19S/2MXLtqzR8w==?= <197020236@qq.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3532 bytes --]

Ok, I will fix it in the next patch, thank you.




------------------ Original ------------------
From:&nbsp;"xavier.huwei"<xavier.huwei@huawei.com&gt;;
Date:&nbsp;Thu, Jul 2, 2020 09:02 AM
To:&nbsp;"×Ô¿ØÅ˶¬Ñó"<197020236@qq.com&gt;;"chas3"<chas3@att.com&gt;;
Cc:&nbsp;"dev"<dev@dpdk.org&gt;;"Wei Hu (Xavier)"<xavier.huwei@huawei.com&gt;;
Subject:&nbsp;Re: [dpdk-dev] [PATCH] dedicated queues: delete redundant check valid_bonded_port_id has include check_for_bonded_ethdev, no need to check again.



Hi, pandongyang

The title is too long, and lack of the commit log.
&nbsp;&nbsp;&nbsp; You can use this script to check your commit when making patch
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ./devtools/check-git-log.sh -[num]

On 2020/6/21 21:34, 197020236@qq.com wrote:
&gt; From: pandongyang <197020236@qq.com&gt;
&gt;
&gt; Signed-off-by: pandongyang <197020236@qq.com&gt;
&gt; ---
&gt;&nbsp;&nbsp; drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
&gt;&nbsp;&nbsp; 1 file changed, 6 deletions(-)
&gt;
&gt; diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt; index b77a37d..3393743 100644
&gt; --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt; +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt; @@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
&gt;&nbsp;&nbsp; 	dev = &amp;rte_eth_devices[port];
&gt;&nbsp;&nbsp; 	internals = dev-&gt;data-&gt;dev_private;
&gt;&nbsp;&nbsp; 
&gt; -	if (check_for_bonded_ethdev(dev) != 0)
&gt; -		return -1;
&gt; -
&gt;&nbsp;&nbsp; 	if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
&gt;&nbsp;&nbsp; 		return -1;
&gt;&nbsp;&nbsp; 
Maybe it is better to remove another place as follows

int
rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
{
&nbsp;&nbsp;&nbsp;&nbsp; int retval = 0;
&nbsp;&nbsp;&nbsp;&nbsp; struct rte_eth_dev *dev;
&nbsp;&nbsp;&nbsp;&nbsp; struct bond_dev_private *internals;

&nbsp;&nbsp;&nbsp;&nbsp; if (valid_bonded_port_id(port) != 0)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -EINVAL;

&nbsp;&nbsp;&nbsp;&nbsp; dev = &amp;rte_eth_devices[port];
&nbsp;&nbsp;&nbsp;&nbsp; internals = dev-&gt;data-&gt;dev_private;

-&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) != 0)
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;

&nbsp;&nbsp;&nbsp;&nbsp; [snip]


&gt; @@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
&gt;&nbsp;&nbsp; 	dev = &amp;rte_eth_devices[port];
&gt;&nbsp;&nbsp; 	internals = dev-&gt;data-&gt;dev_private;
&gt;&nbsp;&nbsp; 
&gt; -	if (check_for_bonded_ethdev(dev) != 0)
&gt; -		return -1;
&gt; -
&gt;&nbsp;&nbsp; 	/* Device must be stopped to set up slow queue */
&gt;&nbsp;&nbsp; 	if (dev-&gt;data-&gt;dev_started)
&gt;&nbsp;&nbsp; 		return -1;
similar to above comment

int
rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
{
&nbsp;&nbsp;&nbsp;&nbsp; int retval = 0;
&nbsp;&nbsp;&nbsp;&nbsp; struct rte_eth_dev *dev;
&nbsp;&nbsp;&nbsp;&nbsp; struct bond_dev_private *internals;

&nbsp;&nbsp;&nbsp;&nbsp; if (valid_bonded_port_id(port) != 0)
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -EINVAL;

&nbsp;&nbsp;&nbsp;&nbsp; dev = &amp;rte_eth_devices[port];
&nbsp;&nbsp;&nbsp;&nbsp; internals = dev-&gt;data-&gt;dev_private;

-&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) != 0)
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;

[snip]


Thanks, Xavier