From: " =?gb18030?B?19S/2MXLtqzR8w==?=" <197020236@qq.com> To: " =?gb18030?B?RmVycnVoIFlpZ2l0?=" <ferruh.yigit@intel.com>, " =?gb18030?B?Y2hhczM=?=" <chas3@att.com>, " =?gb18030?B?ZGV2?=" <dev@dpdk.org>, " =?gb18030?B?eGF2aWVyLmh1d2Vp?=" <xavier.huwei@huawei.com> Subject: [dpdk-dev] =?gb18030?b?u9i4tKO6IFtkcGRrLXN0YWJsZV0gW1BBVENIIFYy?= =?gb18030?q?=5D_net/bonding=3A_delete_redundant_code?= Date: Sat, 18 Jul 2020 10:29:19 +0800 Message-ID: <tencent_4D2434E57F72DFDD1E4D525759424D7C5E0A@qq.com> (raw) In-Reply-To: <5925dbda-d5ad-d8be-0b7a-2b6b468f5d16@intel.com> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3542 bytes --] Ok, my signature is : Dongyang Pan <197020236@qq.com> Thanks! ------------------ ÔʼÓʼþ ------------------ ·¢¼þÈË: "Ferruh Yigit" <ferruh.yigit@intel.com>; ·¢ËÍʱ¼ä: 2020Äê7ÔÂ17ÈÕ(ÐÇÆÚÎå) ÍíÉÏ8:46 ÊÕ¼þÈË: "×Ô¿ØÅ˶¬Ñó"<197020236@qq.com>; ³ËÍ: "Wei Hu (Xavier)"<xavier.huwei@huawei.com>;"dev"<dev@dpdk.org>;"stable"<stable@dpdk.org>; Ö÷Ìâ: Re: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code On 7/17/2020 12:22 PM, Wei Hu (Xavier) wrote: > Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> > > > On 2020/7/4 9:22, Wei Hu (Xavier) wrote: >> >> >> On 2020/7/4 9:15, 197020236@qq.com wrote: >>> From: pandongyang <197020236@qq.com> >>> >>> The function valid_bonded_port_id() has already contains function >>> rte_eth_dev_is_valid_port(), so delete redundant check. >>> >>> Fixes: 588ae95e7983 ("net/bonding: fix port ID check") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: pandongyang <197020236@qq.com> Hi pandongyang, Can you please provide the sign-off in following format: Name Surname <email@address.com> We need this to be able to accept the patch. Thanks, ferruh >> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> >>> --- >>> v1 -> v2: Adjust commit info >>> --- >>> drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c >>> b/drivers/net/bonding/rte_eth_bond_8023ad.c >>> index b77a37ddb..339374337 100644 >>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c >>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c >>> @@ -1675,9 +1675,6 @@ >>> rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port) >>> dev = &rte_eth_devices[port]; >>> internals = dev->data->dev_private; >>> - if (check_for_bonded_ethdev(dev) != 0) >>> - return -1; >>> - >>> if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0) >>> return -1; >>> @@ -1704,9 +1701,6 @@ >>> rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port) >>> dev = &rte_eth_devices[port]; >>> internals = dev->data->dev_private; >>> - if (check_for_bonded_ethdev(dev) != 0) >>> - return -1; >>> - >>> /* Device must be stopped to set up slow queue */ >>> if (dev->data->dev_started) >>> return -1; >> >
next prev parent reply other threads:[~2020-07-18 2:29 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20878f97-ff83-4f39-b603-bcd8379fa5a9@DGGEMS414-HUB.china.huawei.com> 2020-07-04 1:22 ` [dpdk-dev] [PATCH V2] net/bonding: delete redundant code Wei Hu (Xavier) 2020-07-17 11:22 ` Wei Hu (Xavier) 2020-07-17 12:46 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2020-07-18 2:29 ` =?gb18030?B?19S/2MXLtqzR8w==?= [this message] 2020-07-20 22:51 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_4D2434E57F72DFDD1E4D525759424D7C5E0A@qq.com \ --to=197020236@qq.com \ --cc=chas3@att.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=xavier.huwei@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git