[dpdk-dev] =?gb18030?b?u9i4tKO6IFtkcGRrLXN0YWJsZV0gW1BBVENIIFYy?= =?gb18030?q?=5D_net/bonding=3A_delete_redundant_code?=

[=?gb18030?B?19S/2MXLtqzR8w==?= <197020236@qq.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3542 bytes --]

Ok, my signature is :
&nbsp; &nbsp; &nbsp; Dongyang Pan <197020236@qq.com&gt;
Thanks!




------------------&nbsp;ԭʼÓʼþ&nbsp;------------------
·¢¼þÈË:                                                                                                                        "Ferruh Yigit"                                                                                    <ferruh.yigit@intel.com&gt;;
·¢ËÍʱ¼ä:&nbsp;2020Äê7ÔÂ17ÈÕ(ÐÇÆÚÎå) ÍíÉÏ8:46
ÊÕ¼þÈË:&nbsp;"×Ô¿ØÅ˶¬Ñó"<197020236@qq.com&gt;;
³­ËÍ:&nbsp;"Wei Hu (Xavier)"<xavier.huwei@huawei.com&gt;;"dev"<dev@dpdk.org&gt;;"stable"<stable@dpdk.org&gt;;
Ö÷Ìâ:&nbsp;Re: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code



On 7/17/2020 12:22 PM, Wei Hu (Xavier) wrote:
&gt; Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com&gt;
&gt; 
&gt; 
&gt; On 2020/7/4 9:22, Wei Hu (Xavier) wrote:
&gt;&gt;
&gt;&gt;
&gt;&gt; On 2020/7/4 9:15, 197020236@qq.com wrote:
&gt;&gt;&gt; From: pandongyang <197020236@qq.com&gt;
&gt;&gt;&gt;
&gt;&gt;&gt; The function valid_bonded_port_id() has already contains function
&gt;&gt;&gt; rte_eth_dev_is_valid_port(), so delete redundant check.
&gt;&gt;&gt;
&gt;&gt;&gt; Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
&gt;&gt;&gt; Cc: stable@dpdk.org
&gt;&gt;&gt;
&gt;&gt;&gt; Signed-off-by: pandongyang <197020236@qq.com&gt;

Hi pandongyang,

Can you please provide the sign-off in following format:
Name Surname <email@address.com&gt;

We need this to be able to accept the patch.

Thanks,
ferruh


&gt;&gt; Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com&gt;
&gt;&gt;&gt; ---
&gt;&gt;&gt; v1 -&gt; v2: Adjust commit info
&gt;&gt;&gt; ---
&gt;&gt;&gt;&nbsp;&nbsp; drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
&gt;&gt;&gt;&nbsp;&nbsp; 1 file changed, 6 deletions(-)
&gt;&gt;&gt;
&gt;&gt;&gt; diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c 
&gt;&gt;&gt; b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; index b77a37ddb..339374337 100644
&gt;&gt;&gt; --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; @@ -1675,9 +1675,6 @@ 
&gt;&gt;&gt; rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dev = &amp;rte_eth_devices[port];
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; internals = dev-&gt;data-&gt;dev_private;
&gt;&gt;&gt;&nbsp;&nbsp; -&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) != 0)
&gt;&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt; -
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt;&nbsp;&nbsp; @@ -1704,9 +1701,6 @@ 
&gt;&gt;&gt; rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dev = &amp;rte_eth_devices[port];
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; internals = dev-&gt;data-&gt;dev_private;
&gt;&gt;&gt;&nbsp;&nbsp; -&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) != 0)
&gt;&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt; -
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Device must be stopped to set up slow queue */
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (dev-&gt;data-&gt;dev_started)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;
&gt;