test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise mode to forbid misc packets
@ 2019-04-15  3:17 zhang,yan
  0 siblings, 0 replies; 4+ messages in thread
From: zhang,yan @ 2019-04-15  3:17 UTC (permalink / raw)
  To: dts; +Cc: zhang,yan

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_vf_to_vf_nic_bridge.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py b/tests/TestSuite_vf_to_vf_nic_bridge.py
index 356795a..920b5ab 100644
--- a/tests/TestSuite_vf_to_vf_nic_bridge.py
+++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
@@ -179,7 +179,9 @@ class TestVF2VFBridge(TestCase):
         self.vm0_ports = self.vm0_dut.get_ports('any')
         self.vm0_pmd = PmdOutput(self.vm0_dut)
         self.vm0_pmd.start_testpmd('all')
+        self.vm0_pmd.execute_cmd('clear port stats all')
         self.vm0_pmd.execute_cmd('set fwd rxonly')
+        self.vm0_pmd.execute_cmd("set promisc all off")
         self.vm0_pmd.execute_cmd('start')
 
         self.vm1_ports = self.vm1_dut.get_ports('any')
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise mode to forbid misc packets
  2019-04-15 20:50 ` Tu, Lijuan
@ 2019-04-16  0:58   ` Zhang, YanX A
  0 siblings, 0 replies; 4+ messages in thread
From: Zhang, YanX A @ 2019-04-16  0:58 UTC (permalink / raw)
  To: Tu, Lijuan, dts

Ok, I'll pay attention next time

-----Original Message-----
From: Tu, Lijuan 
Sent: Tuesday, April 16, 2019 4:50 AM
To: Zhang, YanX A <yanx.a.zhang@intel.com>; dts@dpdk.org
Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
Subject: RE: [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise mode to forbid misc packets

Applied, This patch was supposed to be V2, thanks for your contribution, Could you please take more care of your version tag next time?

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Sunday, April 14, 2019 8:29 PM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise 
> mode to forbid misc packets
> 
> There will be some miscellaneous packetss appearing on the receiving 
> port, and setting up command "set promisc all off" to forbidden 
> packets
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_vf_to_vf_nic_bridge.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py
> b/tests/TestSuite_vf_to_vf_nic_bridge.py
> index 356795a..15b2ff9 100644
> --- a/tests/TestSuite_vf_to_vf_nic_bridge.py
> +++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
> @@ -180,6 +180,7 @@ class TestVF2VFBridge(TestCase):
>          self.vm0_pmd = PmdOutput(self.vm0_dut)
>          self.vm0_pmd.start_testpmd('all')
>          self.vm0_pmd.execute_cmd('set fwd rxonly')
> +        self.vm0_pmd.execute_cmd("set promisc all off")
>          self.vm0_pmd.execute_cmd('start')
> 
>          self.vm1_ports = self.vm1_dut.get_ports('any') @@ -194,6 
> +195,7 @@ class TestVF2VFBridge(TestCase):
>          load = {}
>          load['content'] = "'X'*46"
>          self.generate_pcap_pkt(dst, src, load)
> +        self.vm0_pmd.execute_cmd('clear port stats all')
>          self.send_stream_pktgen(self.vm1_dut)
>          recv_num = self.vm0_pmd.get_pmd_stats(0)['RX-packets']
>          time.sleep(1)
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise mode to forbid misc packets
  2019-04-15  3:29 zhang,yan
@ 2019-04-15 20:50 ` Tu, Lijuan
  2019-04-16  0:58   ` Zhang, YanX A
  0 siblings, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2019-04-15 20:50 UTC (permalink / raw)
  To: Zhang, YanX A, dts; +Cc: Zhang, YanX A

Applied, This patch was supposed to be V2, thanks for your contribution, Could you please take more care of your version tag next time?

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Sunday, April 14, 2019 8:29 PM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise mode to
> forbid misc packets
> 
> There will be some miscellaneous packetss appearing on the receiving port,
> and setting up command "set promisc all off" to forbidden packets
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_vf_to_vf_nic_bridge.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py
> b/tests/TestSuite_vf_to_vf_nic_bridge.py
> index 356795a..15b2ff9 100644
> --- a/tests/TestSuite_vf_to_vf_nic_bridge.py
> +++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
> @@ -180,6 +180,7 @@ class TestVF2VFBridge(TestCase):
>          self.vm0_pmd = PmdOutput(self.vm0_dut)
>          self.vm0_pmd.start_testpmd('all')
>          self.vm0_pmd.execute_cmd('set fwd rxonly')
> +        self.vm0_pmd.execute_cmd("set promisc all off")
>          self.vm0_pmd.execute_cmd('start')
> 
>          self.vm1_ports = self.vm1_dut.get_ports('any') @@ -194,6 +195,7 @@
> class TestVF2VFBridge(TestCase):
>          load = {}
>          load['content'] = "'X'*46"
>          self.generate_pcap_pkt(dst, src, load)
> +        self.vm0_pmd.execute_cmd('clear port stats all')
>          self.send_stream_pktgen(self.vm1_dut)
>          recv_num = self.vm0_pmd.get_pmd_stats(0)['RX-packets']
>          time.sleep(1)
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise mode to forbid misc packets
@ 2019-04-15  3:29 zhang,yan
  2019-04-15 20:50 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: zhang,yan @ 2019-04-15  3:29 UTC (permalink / raw)
  To: dts; +Cc: zhang,yan

There will be some miscellaneous packetss appearing on the receiving
port, and setting up command "set promisc all off" to forbidden packets

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_vf_to_vf_nic_bridge.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_vf_to_vf_nic_bridge.py b/tests/TestSuite_vf_to_vf_nic_bridge.py
index 356795a..15b2ff9 100644
--- a/tests/TestSuite_vf_to_vf_nic_bridge.py
+++ b/tests/TestSuite_vf_to_vf_nic_bridge.py
@@ -180,6 +180,7 @@ class TestVF2VFBridge(TestCase):
         self.vm0_pmd = PmdOutput(self.vm0_dut)
         self.vm0_pmd.start_testpmd('all')
         self.vm0_pmd.execute_cmd('set fwd rxonly')
+        self.vm0_pmd.execute_cmd("set promisc all off")
         self.vm0_pmd.execute_cmd('start')
 
         self.vm1_ports = self.vm1_dut.get_ports('any')
@@ -194,6 +195,7 @@ class TestVF2VFBridge(TestCase):
         load = {}
         load['content'] = "'X'*46"
         self.generate_pcap_pkt(dst, src, load)
+        self.vm0_pmd.execute_cmd('clear port stats all')
         self.send_stream_pktgen(self.vm1_dut)
         recv_num = self.vm0_pmd.get_pmd_stats(0)['RX-packets']
         time.sleep(1)
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-16  0:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15  3:17 [dts] [PATCH V1] tests/vf_to_vf_nic_bridge:disable promise mode to forbid misc packets zhang,yan
2019-04-15  3:29 zhang,yan
2019-04-15 20:50 ` Tu, Lijuan
2019-04-16  0:58   ` Zhang, YanX A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).