test suite reviews and discussions
 help / color / mirror / Atom feed
From: lihong <lihongx.ma@intel.com>
To: dts@dpdk.org
Cc: lihong <lihongx.ma@intel.com>
Subject: [dts] [PATCH V2] framework/packet: remove the set of conf.use_pcap
Date: Thu,  6 Jun 2019 05:22:11 +0800	[thread overview]
Message-ID: <1559769731-7704-1-git-send-email-lihongx.ma@intel.com> (raw)

when set scapy conf.use_pcap=True,
in scapy 2.2 and 2.3, it will affect the sniff and rdpcap method,
it will use the libpcap to read packet.
in scapy 2.4, it will affect the sendp method, it will use module
in pcapy, so you should upgrade pcapy to 0.11.3 if you want to set
the conf.use_pcap to True.
But after try, find it is not necessary to set the conf.use_pcap to
True, it no effect to our cases. so remove the config in the file,
that we no need to do anything after upgrade scapy.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/packet.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/framework/packet.py b/framework/packet.py
index 4d872fd..e0b98e3 100755
--- a/framework/packet.py
+++ b/framework/packet.py
@@ -44,12 +44,8 @@ import shlex        # separate command line for pipe
 from uuid import uuid4
 from settings import FOLDERS
 
-from scapy.config import conf
-conf.use_pcap = True
-
 import struct
 from socket import AF_INET6
-from scapy.all import conf
 from scapy.utils import wrpcap, rdpcap, hexstr
 from scapy.layers.inet import Ether, IP, TCP, UDP, ICMP
 from scapy.layers.inet6 import IPv6, IPv6ExtHdrRouting, IPv6ExtHdrFragment
-- 
2.7.4


             reply	other threads:[~2019-06-06  4:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 21:22 lihong [this message]
2019-06-12  6:45 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1559769731-7704-1-git-send-email-lihongx.ma@intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).