test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/dcf_lifecycle: add a method to create and check acl rule
@ 2021-10-20  2:55 Jiale Song
  2021-10-21  2:04 ` Huang, ZhiminX
  2021-10-25  8:01 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Jiale Song @ 2021-10-20  2:55 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

as the priority of switch rule becomes higher, some rules that support switch cannot be 
downloaded directly to acl. add a method to create and check acl rule.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_dcf_lifecycle.py | 59 +++++++++++++++++++++++++++++++-
 1 file changed, 58 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_dcf_lifecycle.py b/tests/TestSuite_dcf_lifecycle.py
index d47ef2b1..310172af 100755
--- a/tests/TestSuite_dcf_lifecycle.py
+++ b/tests/TestSuite_dcf_lifecycle.py
@@ -315,6 +315,7 @@ class TestDcfLifeCycle(TestCase):
             "-c {core_mask} "
             "-n {mem_channel} "
             "{allowlist} "
+            "--log-level=ice,7 "
             "--file-prefix={prefix} "
             "-- -i ").format(**{
                 'bin': ''.join(['./',self.vf_dcf_testpmd]),
@@ -374,6 +375,7 @@ class TestDcfLifeCycle(TestCase):
             "-c {core_mask} "
             "-n {mem_channel} "
             "{allowlist} "
+            "--log-level=ice,7 "
             "--file-prefix={prefix} "
             "-- -i ").format(**{
                 'bin': ''.join(['./',self.vf_testpmd2]),
@@ -1020,6 +1022,60 @@ class TestDcfLifeCycle(TestCase):
         self.preset_pmd_res()
         self.vf_create()
 
+    def create_acl_filter_rule(self, rules, session_name="", check_stats=True):
+        """
+        create acl filter rules
+        """
+        if session_name == "":
+            session_name = self.dut
+        p = re.compile(r"Flow rule #(\d+) created")
+        rule_list = []
+        acl_list = []
+        switch_rule = "Succeeded to create (2) flow"
+        acl_rule = "Succeeded to create (4) flow"
+        if isinstance(rules, str):
+            rule_list.append(rules)
+        else:
+            rule_list = rules
+        for rule in rule_list:
+            # create rule is switch or acl
+            out1 = session_name.send_expect(rule, "testpmd> ")
+            if check_stats:
+                if switch_rule in out1:
+                    switch_id = p.findall(out1)[0]
+                    # crete acl_rule
+                    out2 = session_name.send_expect(rule, "testpmd> ")
+                    # destory switch rule
+                    session_name.send_expect("flow destroy %s rule %s" % (0, switch_id), "testpmd> ")
+                    rule_id = p.search(out2)
+                    if rule_id:
+                        acl_list.append(rule_id.group(1))
+                    else:
+                        acl_list.append(False)
+
+                elif acl_rule in out1:
+                    rule_id = p.search(out1)
+                    if rule_id:
+                        acl_list.append(rule_id.group(1))
+                    else:
+                        acl_list.append(False)
+                else:
+                    self.verify(False, "some rules not created Successful, result %s, rule %s" % (acl_list, rule_list))
+
+            else:
+                if switch_rule in out1:
+                    # crete acl_rule
+                    out2 = session_name.send_expect(rule, "testpmd> ")
+                    self.verify('Failed to create flow' in out2,
+                                "some rules should created Failed, '%s'" % (rule))
+                elif acl_rule in out1:
+                    self.verify(False, "some rules should created Failed, '%s' " % (rule))
+
+                else:
+                    self.verify(True, "some rules should created Failed, '%s' " % (rule))
+
+        return acl_list
+
     def destroy_resource(self):
         try:
             self.vf_destroy()
@@ -1232,7 +1288,8 @@ class TestDcfLifeCycle(TestCase):
     def pretest_handle_acl_filter(self):
         # Create an ACL rule, and send packet with dst mac of VF1, then it will dropped by VF1.
         rule = 'flow create 0 priority 0 ingress pattern eth / ipv4 / tcp src spec 8010 src mask 65520 / end actions drop / end'
-        self.d_con([rule, "testpmd> ", 15])
+        # acl rule
+        self.create_acl_filter_rule(rule, check_stats=True)
         self.check_rule_list()
         self.send_pkt_to_vf1_first(self.dmac)
         out = self.vf_pmd2_con(['stop', "testpmd> ", 15])
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [dts] [PATCH V2] tests/dcf_lifecycle: add a method to create and check acl rule
@ 2021-10-19  8:49 Jiale Song
  0 siblings, 0 replies; 4+ messages in thread
From: Jiale Song @ 2021-10-19  8:49 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

as the priority of switch rule becomes higher, some rules that support switch cannot be 
downloaded directly to acl. add a method to create and check acl rule.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_dcf_lifecycle.py | 58 +++++++++++++++++++++++++++++++-
 1 file changed, 57 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_dcf_lifecycle.py b/tests/TestSuite_dcf_lifecycle.py
index d47ef2b..ce51ea1 100755
--- a/tests/TestSuite_dcf_lifecycle.py
+++ b/tests/TestSuite_dcf_lifecycle.py
@@ -315,6 +315,7 @@ class TestDcfLifeCycle(TestCase):
             "-c {core_mask} "
             "-n {mem_channel} "
             "{allowlist} "
+            "--log-level=ice,7 "
             "--file-prefix={prefix} "
             "-- -i ").format(**{
                 'bin': ''.join(['./',self.vf_dcf_testpmd]),
@@ -374,6 +375,7 @@ class TestDcfLifeCycle(TestCase):
             "-c {core_mask} "
             "-n {mem_channel} "
             "{allowlist} "
+            "--log-level=ice,7 "
             "--file-prefix={prefix} "
             "-- -i ").format(**{
                 'bin': ''.join(['./',self.vf_testpmd2]),
@@ -1020,6 +1022,59 @@ class TestDcfLifeCycle(TestCase):
         self.preset_pmd_res()
         self.vf_create()
 
+    def create_acl_filter_rule(self, rules, session_name="", check_stats=True):
+        """
+        create acl filter rules
+        """
+        if session_name == "":
+            session_name = self.dut
+        p = re.compile(r"Flow rule #(\d+) created")
+        rule_list = []
+        switch_rule = "Succeeded to create (2) flow"
+        switch_id = ''
+        acl_rule = "Succeeded to create (4) flow"
+        if isinstance(rules, list):
+            for rule in rules:
+                if 'sctp' not in rule:
+                    # create switch rule
+                    switch_out = session_name.send_expect(rule, "testpmd> ")
+                    self.verify(switch_rule in switch_out, 'switch rule create failed')
+                    switch_id = p.findall(switch_out)[0]
+                # create acl rule
+                acl_out = session_name.send_expect(rule, "testpmd> ")
+                # destory switch rule
+                if switch_id != '':
+                    session_name.send_expect("flow destroy %s rule %s" % (0, switch_id), "testpmd> ")
+                if acl_rule in acl_out:
+                    m = p.search(acl_out)
+                    if m:
+                        rule_list.append(m.group(1))
+                    else:
+                        rule_list.append(False)
+        else:
+            if 'sctp' not in rules:
+                # create switch rule
+                switch_out = session_name.send_expect(rule, "testpmd> ")
+                self.verify(switch_rule in switch_out, 'switch rule create failed')
+                switch_id = p.findall(switch_out)[0]
+            # create acl rule
+            acl_out = session_name.send_expect(rules, "testpmd> ")
+            # destory switch rule
+            if switch_id != ''
+                session_name.send_expect("flow destroy %s rule %s" % (0, switch_id), "testpmd> ")
+            if acl_rule in acl_out:
+                m = p.search(acl_out)
+                if m:
+                    rule_list.append(m.group(1))
+                else:
+                    rule_list.append(False)
+
+        if check_stats:
+            self.verify(all(rule_list), "some rules not created successfully, result %s, rule %s" % (rule_list, rules))
+        else:
+            self.verify(not any(rule_list), "all rules should create failed, result %s" % rule_list)
+        return rule_list
+
     def destroy_resource(self):
         try:
             self.vf_destroy()
@@ -1232,7 +1287,8 @@ class TestDcfLifeCycle(TestCase):
     def pretest_handle_acl_filter(self):
         # Create an ACL rule, and send packet with dst mac of VF1, then it will dropped by VF1.
         rule = 'flow create 0 priority 0 ingress pattern eth / ipv4 / tcp src spec 8010 src mask 65520 / end actions drop / end'
-        self.d_con([rule, "testpmd> ", 15])
+        # acl rule
+        self.create_acl_filter_rule(rule, check_stats=True)
         self.check_rule_list()
         self.send_pkt_to_vf1_first(self.dmac)
         out = self.vf_pmd2_con(['stop', "testpmd> ", 15])
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-25  8:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20  2:55 [dts] [PATCH V2] tests/dcf_lifecycle: add a method to create and check acl rule Jiale Song
2021-10-21  2:04 ` Huang, ZhiminX
2021-10-25  8:01 ` Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2021-10-19  8:49 Jiale Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).