test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/unit_tests_eal: modify ACL test to enhnace test coverage
@ 2021-05-17 17:52 Konstantin Ananyev
  2021-06-18  7:42 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Ananyev @ 2021-05-17 17:52 UTC (permalink / raw)
  To: dts; +Cc: Konstantin Ananyev

Modify test_acl() to run with " --force-max-simd-bitwidth=0".
That will ensure validation of all supported on given HW ACL algorithms.

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 test_plans/unit_tests_eal_test_plan.rst | 4 +++-
 tests/TestSuite_unit_tests_eal.py       | 5 +++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/test_plans/unit_tests_eal_test_plan.rst b/test_plans/unit_tests_eal_test_plan.rst
index 7b2cf627..4cb9d6b9 100644
--- a/test_plans/unit_tests_eal_test_plan.rst
+++ b/test_plans/unit_tests_eal_test_plan.rst
@@ -308,7 +308,9 @@ To Be Filled
 
 Acl
 ===
-To Be Filled
+Performs ACL functional validation.
+If DPDK version permits, then start with " --force-max-simd-bitwidth=0" EAL parameter.
+That will ensure validation of all supported on given HW ACL algorithms.
 
 Link_bonding
 ============
diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index f799b681..e5703f1d 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -460,6 +460,11 @@ class TestUnitTestsEal(TestCase):
         Run acl autotest.
         """
 
+        eal_params = self.dut.create_eal_parameters()
+        self.test_app_cmdline += "--no-pci"
+
+        if self.dut.dpdk_version >= '20.11.0':
+            self.test_app_cmdline += " --force-max-simd-bitwidth=0"
         self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
         out = self.dut.send_expect("acl_autotest", "RTE>>", self.run_cmd_time)
         self.dut.send_expect("quit", "# ")
-- 
2.26.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] tests/unit_tests_eal: modify ACL test to enhnace test coverage
  2021-05-17 17:52 [dts] [PATCH] tests/unit_tests_eal: modify ACL test to enhnace test coverage Konstantin Ananyev
@ 2021-06-18  7:42 ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-06-18  7:42 UTC (permalink / raw)
  To: Ananyev, Konstantin, dts; +Cc: Ananyev, Konstantin

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Konstantin Ananyev
> Sent: 2021年5月18日 1:53
> To: dts@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Subject: [dts] [PATCH] tests/unit_tests_eal: modify ACL test to enhnace test
> coverage
> 
> Modify test_acl() to run with " --force-max-simd-bitwidth=0".
> That will ensure validation of all supported on given HW ACL algorithms.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] tests/unit_tests_eal: modify ACL test to enhnace test coverage
  2021-05-18 15:39 Konstantin Ananyev
@ 2021-05-26  8:13 ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-05-26  8:13 UTC (permalink / raw)
  To: Ananyev, Konstantin, dts; +Cc: Ananyev, Konstantin

> Modify test_acl() to run with " --force-max-simd-bitwidth=0".
> That will ensure validation of all supported on given HW ACL algorithms.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH] tests/unit_tests_eal: modify ACL test to enhnace test coverage
@ 2021-05-18 15:39 Konstantin Ananyev
  2021-05-26  8:13 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Ananyev @ 2021-05-18 15:39 UTC (permalink / raw)
  To: dts; +Cc: Konstantin Ananyev

Modify test_acl() to run with " --force-max-simd-bitwidth=0".
That will ensure validation of all supported on given HW ACL algorithms.

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 test_plans/unit_tests_eal_test_plan.rst | 4 +++-
 tests/TestSuite_unit_tests_eal.py       | 5 +++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/test_plans/unit_tests_eal_test_plan.rst b/test_plans/unit_tests_eal_test_plan.rst
index 7b2cf627..4cb9d6b9 100644
--- a/test_plans/unit_tests_eal_test_plan.rst
+++ b/test_plans/unit_tests_eal_test_plan.rst
@@ -308,7 +308,9 @@ To Be Filled
 
 Acl
 ===
-To Be Filled
+Performs ACL functional validation.
+If DPDK version permits, then start with " --force-max-simd-bitwidth=0" EAL parameter.
+That will ensure validation of all supported on given HW ACL algorithms.
 
 Link_bonding
 ============
diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index f799b681..e5703f1d 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -460,6 +460,11 @@ class TestUnitTestsEal(TestCase):
         Run acl autotest.
         """
 
+        eal_params = self.dut.create_eal_parameters()
+        self.test_app_cmdline += "--no-pci"
+
+        if self.dut.dpdk_version >= '20.11.0':
+            self.test_app_cmdline += " --force-max-simd-bitwidth=0"
         self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
         out = self.dut.send_expect("acl_autotest", "RTE>>", self.run_cmd_time)
         self.dut.send_expect("quit", "# ")
-- 
2.26.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-18  7:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 17:52 [dts] [PATCH] tests/unit_tests_eal: modify ACL test to enhnace test coverage Konstantin Ananyev
2021-06-18  7:42 ` Tu, Lijuan
2021-05-18 15:39 Konstantin Ananyev
2021-05-26  8:13 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).