test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid
@ 2022-09-08  5:53 Weiyuan Li
  2022-09-08  5:53 ` [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li
  2022-09-20  7:42 ` [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid Fu, Qi
  0 siblings, 2 replies; 5+ messages in thread
From: Weiyuan Li @ 2022-09-08  5:53 UTC (permalink / raw)
  To: dts; +Cc: Weiyuan Li

Optimize script case vlan_tpid_config add check tpid.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-Patch conflict modification

 tests/TestSuite_dual_vlan.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 15d6f2b2..87c5325b 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -502,7 +502,7 @@ class TestDualVlan(TestCase):
 
     def test_vlan_tpid_config(self):
         """
-        Configure receive port out vlan TPID
+        Configure receive port inner VLAN TPID
         """
         self.verify(
             self.nic
@@ -524,6 +524,7 @@ class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify("vlan %s" % outvlan in out, "vlan tpid disable error: " + out)
         self.verify("vlan %s" % invlan in out, "vlan tpid disable error: " + out)
 
@@ -531,6 +532,7 @@ class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify(
             out is not None and "vlan" not in out, "vlane tpid enable error: " + out
         )
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan
  2022-09-08  5:53 [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid Weiyuan Li
@ 2022-09-08  5:53 ` Weiyuan Li
  2022-09-20  7:42   ` Fu, Qi
  2022-09-20  8:08   ` lijuan.tu
  2022-09-20  7:42 ` [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid Fu, Qi
  1 sibling, 2 replies; 5+ messages in thread
From: Weiyuan Li @ 2022-09-08  5:53 UTC (permalink / raw)
  To: dts; +Cc: Weiyuan Li

Add diable/enable "extend off" "strip off" in test plan.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-Patch conflict modification

 test_plans/dual_vlan_test_plan.rst | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index 985394a2..752b5025 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -44,6 +44,10 @@ Enable vlan filtering on port 0::
 
     testpmd> vlan set filter on 0
 
+Disable extend on port 0::
+
+    testpmd> vlan set extend off 0
+
 Check whether the mode is set successful::
 
     testpmd> show port info 0
@@ -103,6 +107,11 @@ Configure the traffic generator to send VLAN packets with the Tag Identifier
 Test Case: Add/Remove VLAN Tag Identifier pass VLAN filtering
 =============================================================
 
+Disable VLAN packet extend and strip port ``0``::
+
+    testpmd> vlan set extend off 0
+    testpmd> vlan set strip off 0
+
 Enable VLAN filtering on port ``0``::
 
     testpmd> vlan set filter on 0
@@ -240,7 +249,7 @@ and send 1 packet on port ``A``. Verify that the packet can been received on por
 ``B`` without VLAN Tag Identifier.
 
 
-Test Case: Configure receive port outer VLAN TPID
+Test Case: Configure receive port inner VLAN TPID
 =================================================
 
 Enable vlan header QinQ on port ``0`` firstly to support set TPID::
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid
  2022-09-08  5:53 [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid Weiyuan Li
  2022-09-08  5:53 ` [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li
@ 2022-09-20  7:42 ` Fu, Qi
  1 sibling, 0 replies; 5+ messages in thread
From: Fu, Qi @ 2022-09-20  7:42 UTC (permalink / raw)
  To: Li, WeiyuanX, dts; +Cc: Li, WeiyuanX

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Thursday, September 8, 2022 1:54 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case
> vlan_tpid_config add check tpid
> 
> Optimize script case vlan_tpid_config add check tpid.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
> 
> v2:
> -Patch conflict modification
> 
>  tests/TestSuite_dual_vlan.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
Acked-by: Fu, Qi <qi.fu@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan
  2022-09-08  5:53 ` [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li
@ 2022-09-20  7:42   ` Fu, Qi
  2022-09-20  8:08   ` lijuan.tu
  1 sibling, 0 replies; 5+ messages in thread
From: Fu, Qi @ 2022-09-20  7:42 UTC (permalink / raw)
  To: Li, WeiyuanX, dts; +Cc: Li, WeiyuanX

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Thursday, September 8, 2022 1:54 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan
> 
> Add diable/enable "extend off" "strip off" in test plan.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
> 
> v2:
> -Patch conflict modification
> 
>  test_plans/dual_vlan_test_plan.rst | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
Acked-by: Fu, Qi <qi.fu@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan
  2022-09-08  5:53 ` [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li
  2022-09-20  7:42   ` Fu, Qi
@ 2022-09-20  8:08   ` lijuan.tu
  1 sibling, 0 replies; 5+ messages in thread
From: lijuan.tu @ 2022-09-20  8:08 UTC (permalink / raw)
  To: dts, Weiyuan Li; +Cc: Weiyuan Li

On Thu,  8 Sep 2022 13:53:48 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> Add diable/enable "extend off" "strip off" in test plan.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-20  8:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08  5:53 [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid Weiyuan Li
2022-09-08  5:53 ` [dts][PATCH V2 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li
2022-09-20  7:42   ` Fu, Qi
2022-09-20  8:08   ` lijuan.tu
2022-09-20  7:42 ` [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid Fu, Qi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).