test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/TestSuite_efd:Modify the hard coded appparameter
@ 2020-12-10 11:29 Zhou Jun
  2020-12-15  5:55 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Zhou Jun @ 2020-12-10 11:29 UTC (permalink / raw)
  To: dts; +Cc: Zhou Jun

Modify the hard coded app parameter to call the platform interface

Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
---
 tests/TestSuite_efd.py | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/tests/TestSuite_efd.py b/tests/TestSuite_efd.py
index 36df999c..787733ca 100644
--- a/tests/TestSuite_efd.py
+++ b/tests/TestSuite_efd.py
@@ -79,7 +79,8 @@ class TestEFD(TestCase):
         """
         Run EFD unit test
         """
-        self.dut.send_expect("./%s -n 1 -c f" % self.app_test_path, "RTE>>", 60)
+        eal_para = self.dut.create_eal_parameters(cores=[0, 1, 2, 3])
+        self.dut.send_expect("./%s %s" % (self.app_test_path, eal_para), "RTE>>", 60)
         out = self.dut.send_expect("efd_autotest", "RTE>>", 120)
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
@@ -88,7 +89,8 @@ class TestEFD(TestCase):
         """
         Run EFD unit perf test
         """
-        self.dut.send_expect("./%s -n 1 -c f" % self.app_test_path, "RTE>>", 60)
+        eal_para = self.dut.create_eal_parameters(cores=[0, 1, 2, 3])
+        self.dut.send_expect("./%s %s" % (self.app_test_path, eal_para), "RTE>>", 60)
         out = self.dut.send_expect("efd_perf_autotest", "RTE>>", 120)
         self.logger.info(out)
         self.dut.send_expect("quit", "# ")
@@ -175,8 +177,8 @@ class TestEFD(TestCase):
         # extended flow number into etgen module
 
         # output port is calculated from overall ports number
-        server_cmd_fmt = "%s -c %s -n %d -w %s -w %s -- -p 0x3 -n %d -f %s"
-        node_cmd_fmt = "%s -c %s -n %d --proc-type=secondary -- -n %d"
+        server_cmd_fmt = "%s %s -- -p 0x3 -n %d -f %s"
+        node_cmd_fmt = "%s %s --proc-type=secondary -- -n %d"
         socket = self.dut.get_numa_id(self.dut_ports[0])
 
         pcap = os.sep.join([self.output_path, "efd.pcap"])
@@ -195,19 +197,16 @@ class TestEFD(TestCase):
 
         self.verify(len(cores), "Can't find enough cores")
 
-        server_cmd = server_cmd_fmt % (self.server_app, utils.create_mask(cores[0:2]),
-                                       self.dut.get_memory_channels(),
-                                       self.dut.get_port_pci(self.dut_ports[0]),
-                                       self.dut.get_port_pci(self.dut_ports[1]),
-                                       node_num, hex(flow_num))
-
+        eal_para = self.dut.create_eal_parameters(cores=cores[0:2], ports=[0, 1])
+        server_cmd = server_cmd_fmt % (self.server_app, eal_para, node_num, hex(flow_num))
         # create table may need few minutes
         self.dut.send_expect(server_cmd, "Finished Process Init", timeout=240)
 
         node_sessions = []
         for node in range(node_num):
-            node_cmd = node_cmd_fmt % (self.node_app, utils.create_mask([cores[2 + node]]),
-                                       self.dut.get_memory_channels(), node)
+
+            eal_para = self.dut.create_eal_parameters(cores=[cores[2 + node]])
+            node_cmd = node_cmd_fmt % (self.node_app, eal_para, node)
             node_session = self.dut.new_session(suite="node%d" % node)
             node_sessions.append(node_session)
             node_session.send_expect(node_cmd, "Finished Process Init", timeout=30)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_efd:Modify the hard coded appparameter
  2020-12-10 11:29 [dts] [PATCH V1] tests/TestSuite_efd:Modify the hard coded appparameter Zhou Jun
@ 2020-12-15  5:55 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-12-15  5:55 UTC (permalink / raw)
  To: Zhou, JunX W, dts; +Cc: Zhou, JunX W

> Modify the hard coded app parameter to call the platform interface
> 
> Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-15  5:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 11:29 [dts] [PATCH V1] tests/TestSuite_efd:Modify the hard coded appparameter Zhou Jun
2020-12-15  5:55 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).