test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] update the thread number
@ 2019-03-19  9:21 Wenjie Li
  2019-03-20  1:35 ` Zhu, ShuaiX
  0 siblings, 1 reply; 2+ messages in thread
From: Wenjie Li @ 2019-03-19  9:21 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

1. the thread number should be equal to the port number, update it
2. move dut.kill_all() to tear_down() to avoid the interactions between cases

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
V2: add "sed -i ..." to set_ports()
V1: wrongly add "sed -i ..." to set_table()
---
 tests/TestSuite_flow_classify_softnic.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_flow_classify_softnic.py b/tests/TestSuite_flow_classify_softnic.py
index 66db5c3..dd05769 100644
--- a/tests/TestSuite_flow_classify_softnic.py
+++ b/tests/TestSuite_flow_classify_softnic.py
@@ -109,6 +109,7 @@ class TestFlowClassifySoftnic(TestCase):
             self.dut.send_expect(cmd, "# ", 20)
             cmd = "sed -i '4i\link LINK3 dev %s' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.dut_p3_pci, filename)
             self.dut.send_expect(cmd, "# ", 20)
+        self.dut.send_expect("sed -i 's/^thread 4 pipeline/thread %d pipeline/g' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.port_num, filename), "# ", 20)
 
     def set_table(self, cmd, filename):
         """
@@ -1349,10 +1350,10 @@ class TestFlowClassifySoftnic(TestCase):
         """
         Run after each test case.
         """
-        pass
+        self.dut.kill_all()
 
     def tear_down_all(self):
         """
         Run after each test suite.
         """
-        self.dut.kill_all()
+        pass
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2] update the thread number
  2019-03-19  9:21 [dts] [PATCH V2] update the thread number Wenjie Li
@ 2019-03-20  1:35 ` Zhu, ShuaiX
  0 siblings, 0 replies; 2+ messages in thread
From: Zhu, ShuaiX @ 2019-03-20  1:35 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A, Zhu, ShuaiX

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Tuesday, March 19, 2019 5:21 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V2] update the thread number
> 
> 1. the thread number should be equal to the port number, update it 2. move
> dut.kill_all() to tear_down() to avoid the interactions between cases
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> V2: add "sed -i ..." to set_ports()
> V1: wrongly add "sed -i ..." to set_table()
> ---
>  tests/TestSuite_flow_classify_softnic.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_flow_classify_softnic.py
> b/tests/TestSuite_flow_classify_softnic.py
> index 66db5c3..dd05769 100644
> --- a/tests/TestSuite_flow_classify_softnic.py
> +++ b/tests/TestSuite_flow_classify_softnic.py
> @@ -109,6 +109,7 @@ class TestFlowClassifySoftnic(TestCase):
>              self.dut.send_expect(cmd, "# ", 20)
>              cmd = "sed -i '4i\link LINK3
> dev %s' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.dut_p3_pci,
> filename)
>              self.dut.send_expect(cmd, "# ", 20)
> +        self.dut.send_expect("sed -i 's/^thread 4 pipeline/thread %d
> + pipeline/g' ./drivers/net/softnic/flow_classify_softnic/%s" %
> + (self.port_num, filename), "# ", 20)
> 
>      def set_table(self, cmd, filename):
>          """
> @@ -1349,10 +1350,10 @@ class TestFlowClassifySoftnic(TestCase):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.dut.kill_all()
> 
>      def tear_down_all(self):
>          """
>          Run after each test suite.
>          """
> -        self.dut.kill_all()
> +        pass
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-20  1:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19  9:21 [dts] [PATCH V2] update the thread number Wenjie Li
2019-03-20  1:35 ` Zhu, ShuaiX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).