test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wu, ChangqingX" <changqingx.wu@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
Date: Fri, 12 Apr 2019 01:36:09 +0000	[thread overview]
Message-ID: <7F81DD3887C58F49A6B2EFEC3C28E22E0B6CD085@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA60548@SHSMSX101.ccr.corp.intel.com>

Dpdk made some code changes in the commit:53324971a14e02f5f710d6e73fe475650e9a9802, which effects method that tests the number of "Bad-l4csum", continuously sends 2 or more packets between start and stop, the number of "Bad-l4csum" Will accumulate, if stop, the number of "Bad-l4csum" will be reset, you can check: dpdk-11148, Yigit, Ferruh comments 


Thanks
changqingx

-----Original Message-----
From: Tu, Lijuan 
Sent: Friday, April 12, 2019 1:26 AM
To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
Cc: Wu, ChangqingX <changqingx.wu@intel.com>
Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

I am not quit catch your reason, I think when it catch "Bad-l4csum", and the number increases. So what is your consideration that remove the statement.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, April 9, 2019 12:15 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_vxlan.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> 8de8384..34297e0 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>          if "inner_l4_invalid" in kwargs:
>              self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
>                          == self.l4err_num + 1, "Failed to count inner l4 chksum error")
> -            self.l4err_num += 1
> 
>          # verify detected l3 invalid checksum
>          if "ip_invalid" in kwargs:
> --
> 2.17.2


  reply	other threads:[~2019-04-12  1:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  7:15 changqingxwu
2019-04-09  8:05 ` Zhu, ShuaiX
2019-04-11 17:26 ` Tu, Lijuan
2019-04-12  1:36   ` Wu, ChangqingX [this message]
2019-04-12 16:54     ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7F81DD3887C58F49A6B2EFEC3C28E22E0B6CD085@SHSMSX101.ccr.corp.intel.com \
    --to=changqingx.wu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).