test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] test_plans/distributor: test plan revise
  2019-03-19 11:03 [dts] [PATCH V1] test_plans/distributor: test plan revise Zhe
@ 2019-03-19  3:21 ` Li, WenjieX A
  2019-03-24  8:03 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Li, WenjieX A @ 2019-03-19  3:21 UTC (permalink / raw)
  To: Wan, Zhe, dts; +Cc: Wan, Zhe

With latest dpdk, there is not dpdk/test directory.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhe
> Sent: Tuesday, March 19, 2019 7:04 PM
> To: dts@dpdk.org
> Cc: Wan, Zhe <zhe.wan@intel.com>
> Subject: [dts] [PATCH V1] test_plans/distributor: test plan revise
> 
> From: Zhe Wan <zhe.wan@intel.com>
> 
> Signed-off-by: Zhe Wan <zhe.wan@intel.com>
> ---
>  test_plans/distributor_test_plan.rst | 42 +++---------------------------------
>  1 file changed, 3 insertions(+), 39 deletions(-)
> 
> diff --git a/test_plans/distributor_test_plan.rst
> b/test_plans/distributor_test_plan.rst
> index 106936d..db64a54 100644
> --- a/test_plans/distributor_test_plan.rst
> +++ b/test_plans/distributor_test_plan.rst
> @@ -53,7 +53,7 @@ Test Case: Distributor unit test
> ================================  Start test application and run distributor
> unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/test/test -c f -n 4
>  	   RTE>>distributor_autotest
> 
>  Verify burst distributor API unit test passed @@ -62,47 +62,13 @@ Test Case:
> Distributor performance unit test
> ============================================
>  Start test application and run distributor unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/tes/test -c f -n 4
>  	   RTE>>distributor_perf_autotest
> 
>  Compared CPU cycles for normal distributor and burst API
> 
>  Verify burst distributor API cost much less cycles then normal version
> 
> -Test Case: Distributor packet check
> -===================================
> -Start distributor sample with one worker::
> -
> -	distributor_app -c 0x7c  -n 4 -- -p 0x1
> -
> -Send few packets (less then burst size) with sequence index which indicated in -
> ip dst address
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets equal to burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets over burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Test Case: Distributor with workers
> -===================================
> -Start distributor sample with two workers::
> -
> -	distributor_app -c 0xfc  -n 4 -- -p 0x1
> -
> -Send several packets with ip address increasing
> -
> -Check packets distributed to different workers
> -
> -Check all packets have been sent back from tx lcore
> -
> -Repeat step 1 to step4 with 4(3fc)/8(3ffc)/16(0x3ffffc)/32(0xffff0003ffffc)
> -workers
> -
>  Test case: Distribute with maximum workers
> ==========================================
>  Start distributor sample with 63(0xeffffffffffffffff0) workers @@ -117,7 +83,7
> @@ Test Case: Distributor with multiple input ports
> ================================================
>  Start distributor sample with two workers and two ports::
> 
> -	distributor_app -c 0x7c -n 4 -- -p 0x3
> +	./examples/distributor/build/distributor_app -c 0x7c -n 4 -- -p 0x3
> 
>  Send packets with sequence indicated in udp port id
> 
> @@ -151,5 +117,3 @@ for each action in lcores as listed in the table below::
>  	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
>  	| 7  |    32   |        |         |        |         |        |         |        |         |        |         |
> |         |
>  	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
> -	| 8  |    63   |        |         |        |         |        |         |        |         |        |         |
> |         |
> -	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] test_plans/distributor: test plan revise
@ 2019-03-19 11:03 Zhe
  2019-03-19  3:21 ` Li, WenjieX A
  2019-03-24  8:03 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Zhe @ 2019-03-19 11:03 UTC (permalink / raw)
  To: dts; +Cc: Zhe Wan

From: Zhe Wan <zhe.wan@intel.com>

Signed-off-by: Zhe Wan <zhe.wan@intel.com>
---
 test_plans/distributor_test_plan.rst | 42 +++---------------------------------
 1 file changed, 3 insertions(+), 39 deletions(-)

diff --git a/test_plans/distributor_test_plan.rst b/test_plans/distributor_test_plan.rst
index 106936d..db64a54 100644
--- a/test_plans/distributor_test_plan.rst
+++ b/test_plans/distributor_test_plan.rst
@@ -53,7 +53,7 @@ Test Case: Distributor unit test
 ================================
 Start test application and run distributor unit test::
 
-	   test -c f -n 4 -- -i
+	   ./test/test/test -c f -n 4
 	   RTE>>distributor_autotest
 
 Verify burst distributor API unit test passed
@@ -62,47 +62,13 @@ Test Case: Distributor performance unit test
 ============================================
 Start test application and run distributor unit test::
 
-	   test -c f -n 4 -- -i
+	   ./test/tes/test -c f -n 4
 	   RTE>>distributor_perf_autotest
 
 Compared CPU cycles for normal distributor and burst API
 
 Verify burst distributor API cost much less cycles then normal version
 
-Test Case: Distributor packet check
-===================================
-Start distributor sample with one worker::
-
-	distributor_app -c 0x7c  -n 4 -- -p 0x1
-
-Send few packets (less then burst size) with sequence index which indicated in
-ip dst address
-
-Check forwarded packets are all in sequence and content not changed
-
-Send packets equal to burst size with sequence index
-
-Check forwarded packets are all in sequence and content not changed
-
-Send packets over burst size with sequence index
-
-Check forwarded packets are all in sequence and content not changed
-
-Test Case: Distributor with workers
-===================================
-Start distributor sample with two workers::
-
-	distributor_app -c 0xfc  -n 4 -- -p 0x1
-	
-Send several packets with ip address increasing
-
-Check packets distributed to different workers
-
-Check all packets have been sent back from tx lcore
-
-Repeat step 1 to step4 with 4(3fc)/8(3ffc)/16(0x3ffffc)/32(0xffff0003ffffc)
-workers
-
 Test case: Distribute with maximum workers
 ==========================================
 Start distributor sample with 63(0xeffffffffffffffff0) workers
@@ -117,7 +83,7 @@ Test Case: Distributor with multiple input ports
 ================================================
 Start distributor sample with two workers and two ports::
 
-	distributor_app -c 0x7c -n 4 -- -p 0x3
+	./examples/distributor/build/distributor_app -c 0x7c -n 4 -- -p 0x3
 
 Send packets with sequence indicated in udp port id
 
@@ -151,5 +117,3 @@ for each action in lcores as listed in the table below::
 	+----+---------+--------+---------+--------+---------+--------+---------+--------+---------+--------+---------+--------+---------+
 	| 7  |    32   |        |         |        |         |        |         |        |         |        |         |        |         |
 	+----+---------+--------+---------+--------+---------+--------+---------+--------+---------+--------+---------+--------+---------+
-	| 8  |    63   |        |         |        |         |        |         |        |         |        |         |        |         |
-	+----+---------+--------+---------+--------+---------+--------+---------+--------+---------+--------+---------+--------+---------+
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] test_plans/distributor: test plan revise
  2019-03-19 11:03 [dts] [PATCH V1] test_plans/distributor: test plan revise Zhe
  2019-03-19  3:21 ` Li, WenjieX A
@ 2019-03-24  8:03 ` Tu, Lijuan
  2019-03-25  8:31   ` Wan, Zhe
  1 sibling, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2019-03-24  8:03 UTC (permalink / raw)
  To: Wan, Zhe, dts; +Cc: Wan, Zhe

Hi zhe,

1, There is a typo: ./test/tes/test -c f -n 4  should be ./test/test/test -c f -n 4
2, And confused by your directory, the actually test application directory should be  ./app/test/test or ./x86_64-native-linuxapp-gcc/app/test.
3, what do you think about remove several cases.


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhe
> Sent: Tuesday, March 19, 2019 4:04 AM
> To: dts@dpdk.org
> Cc: Wan, Zhe <zhe.wan@intel.com>
> Subject: [dts] [PATCH V1] test_plans/distributor: test plan revise
> 
> From: Zhe Wan <zhe.wan@intel.com>
> 
> Signed-off-by: Zhe Wan <zhe.wan@intel.com>
> ---
>  test_plans/distributor_test_plan.rst | 42 +++---------------------------------
>  1 file changed, 3 insertions(+), 39 deletions(-)
> 
> diff --git a/test_plans/distributor_test_plan.rst
> b/test_plans/distributor_test_plan.rst
> index 106936d..db64a54 100644
> --- a/test_plans/distributor_test_plan.rst
> +++ b/test_plans/distributor_test_plan.rst
> @@ -53,7 +53,7 @@ Test Case: Distributor unit test
> ================================  Start test application and run distributor
> unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/test/test -c f -n 4
>  	   RTE>>distributor_autotest
> 
>  Verify burst distributor API unit test passed @@ -62,47 +62,13 @@ Test Case:
> Distributor performance unit test
> ============================================
>  Start test application and run distributor unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/tes/test -c f -n 4
>  	   RTE>>distributor_perf_autotest
> 
>  Compared CPU cycles for normal distributor and burst API
> 
>  Verify burst distributor API cost much less cycles then normal version
> 
> -Test Case: Distributor packet check
> -===================================
> -Start distributor sample with one worker::
> -
> -	distributor_app -c 0x7c  -n 4 -- -p 0x1
> -
> -Send few packets (less then burst size) with sequence index which indicated in -
> ip dst address
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets equal to burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets over burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Test Case: Distributor with workers
> -===================================
> -Start distributor sample with two workers::
> -
> -	distributor_app -c 0xfc  -n 4 -- -p 0x1
> -
> -Send several packets with ip address increasing
> -
> -Check packets distributed to different workers
> -
> -Check all packets have been sent back from tx lcore
> -
> -Repeat step 1 to step4 with 4(3fc)/8(3ffc)/16(0x3ffffc)/32(0xffff0003ffffc)
> -workers
> -
>  Test case: Distribute with maximum workers
> ==========================================
>  Start distributor sample with 63(0xeffffffffffffffff0) workers @@ -117,7 +83,7
> @@ Test Case: Distributor with multiple input ports
> ================================================
>  Start distributor sample with two workers and two ports::
> 
> -	distributor_app -c 0x7c -n 4 -- -p 0x3
> +	./examples/distributor/build/distributor_app -c 0x7c -n 4 -- -p 0x3
> 
>  Send packets with sequence indicated in udp port id
> 
> @@ -151,5 +117,3 @@ for each action in lcores as listed in the table below::
>  	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
>  	| 7  |    32   |        |         |        |         |        |         |        |         |        |         |
> |         |
>  	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
> -	| 8  |    63   |        |         |        |         |        |         |        |         |        |         |
> |         |
> -	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] test_plans/distributor: test plan revise
  2019-03-24  8:03 ` Tu, Lijuan
@ 2019-03-25  8:31   ` Wan, Zhe
  0 siblings, 0 replies; 4+ messages in thread
From: Wan, Zhe @ 2019-03-25  8:31 UTC (permalink / raw)
  To: Tu, Lijuan, dts

Hi Lijuan,
Thanks for your review.
In the removed test cases, will start one and two workers, they have already get covered. 
And in now existing test cases, will start 1, 2, 3, 4, 8, 16, 32 workers. 
Also we didn't have these test cases in TestSuite_distributor.py.
So I removed these redundant test cases.

Thanks!
BR,
Wan,Zhe

-----Original Message-----
From: Tu, Lijuan 
Sent: Sunday, March 24, 2019 4:03 PM
To: Wan, Zhe <zhe.wan@intel.com>; dts@dpdk.org
Cc: Wan, Zhe <zhe.wan@intel.com>
Subject: RE: [dts] [PATCH V1] test_plans/distributor: test plan revise

Hi zhe,

1, There is a typo: ./test/tes/test -c f -n 4  should be ./test/test/test -c f -n 4 2, And confused by your directory, the actually test application directory should be  ./app/test/test or ./x86_64-native-linuxapp-gcc/app/test.
3, what do you think about remove several cases.


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhe
> Sent: Tuesday, March 19, 2019 4:04 AM
> To: dts@dpdk.org
> Cc: Wan, Zhe <zhe.wan@intel.com>
> Subject: [dts] [PATCH V1] test_plans/distributor: test plan revise
> 
> From: Zhe Wan <zhe.wan@intel.com>
> 
> Signed-off-by: Zhe Wan <zhe.wan@intel.com>
> ---
>  test_plans/distributor_test_plan.rst | 42 
> +++---------------------------------
>  1 file changed, 3 insertions(+), 39 deletions(-)
> 
> diff --git a/test_plans/distributor_test_plan.rst
> b/test_plans/distributor_test_plan.rst
> index 106936d..db64a54 100644
> --- a/test_plans/distributor_test_plan.rst
> +++ b/test_plans/distributor_test_plan.rst
> @@ -53,7 +53,7 @@ Test Case: Distributor unit test 
> ================================  Start test application and run 
> distributor unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/test/test -c f -n 4
>  	   RTE>>distributor_autotest
> 
>  Verify burst distributor API unit test passed @@ -62,47 +62,13 @@ Test Case:
> Distributor performance unit test
> ============================================
>  Start test application and run distributor unit test::
> 
> -	   test -c f -n 4 -- -i
> +	   ./test/tes/test -c f -n 4
>  	   RTE>>distributor_perf_autotest
> 
>  Compared CPU cycles for normal distributor and burst API
> 
>  Verify burst distributor API cost much less cycles then normal 
> version
> 
> -Test Case: Distributor packet check
> -===================================
> -Start distributor sample with one worker::
> -
> -	distributor_app -c 0x7c  -n 4 -- -p 0x1
> -
> -Send few packets (less then burst size) with sequence index which 
> indicated in - ip dst address
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets equal to burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Send packets over burst size with sequence index
> -
> -Check forwarded packets are all in sequence and content not changed
> -
> -Test Case: Distributor with workers
> -===================================
> -Start distributor sample with two workers::
> -
> -	distributor_app -c 0xfc  -n 4 -- -p 0x1
> -
> -Send several packets with ip address increasing
> -
> -Check packets distributed to different workers
> -
> -Check all packets have been sent back from tx lcore
> -
> -Repeat step 1 to step4 with 
> 4(3fc)/8(3ffc)/16(0x3ffffc)/32(0xffff0003ffffc)
> -workers
> -
>  Test case: Distribute with maximum workers 
> ==========================================
>  Start distributor sample with 63(0xeffffffffffffffff0) workers @@ 
> -117,7 +83,7 @@ Test Case: Distributor with multiple input ports 
> ================================================
>  Start distributor sample with two workers and two ports::
> 
> -	distributor_app -c 0x7c -n 4 -- -p 0x3
> +	./examples/distributor/build/distributor_app -c 0x7c -n 4 -- -p 0x3
> 
>  Send packets with sequence indicated in udp port id
> 
> @@ -151,5 +117,3 @@ for each action in lcores as listed in the table below::
>  	
> +----+---------+--------+---------+--------+---------+--------+-------
> --+--------+-
> --------+--------+---------+--------+---------+
>  	| 7  |    32   |        |         |        |         |        |         |        |         |        |         |
> |         |
>  	
> +----+---------+--------+---------+--------+---------+--------+-------
> --+--------+-
> --------+--------+---------+--------+---------+
> -	| 8  |    63   |        |         |        |         |        |         |        |         |        |         |
> |         |
> -	+----+---------+--------+---------+--------+---------+--------+---------+--------+-
> --------+--------+---------+--------+---------+
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-25  8:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 11:03 [dts] [PATCH V1] test_plans/distributor: test plan revise Zhe
2019-03-19  3:21 ` Li, WenjieX A
2019-03-24  8:03 ` Tu, Lijuan
2019-03-25  8:31   ` Wan, Zhe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).