test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd
  2019-05-07  9:33 [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd zhuwenhui
@ 2019-05-07  9:33 ` Yao, BingX Y
  2019-05-08  5:16 ` Li, WenjieX A
  1 sibling, 0 replies; 3+ messages in thread
From: Yao, BingX Y @ 2019-05-07  9:33 UTC (permalink / raw)
  To: Zhu, WenhuiX, dts; +Cc: Zhu, WenhuiX

Tested-by: Yao, BingX Y <bingx.y.yao@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
Sent: Tuesday, May 7, 2019 5:34 PM
To: dts@dpdk.org
Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
Subject: [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd

When fortville spirit binds multiple ports, starting testpmd requires more cores.

Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_dynamic_queue.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index 3aad63f..9cd0073 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -27,12 +27,12 @@ class TestDynamicQueue(TestCase):
         self.dut_testpmd = PmdOutput(self.dut)
 
     def set_up(self):
-        # Because of fortville spirit limitation,can't use 2 ports for testing
+        # Fortville_spirit needs more cores to run properly
         if (self.nic in ["fortville_spirit"]):
+            self.verify("len(self.dut.cores)>=7", "Less than seven 
+ cares can't run testpmd")
             self.dut_testpmd.start_testpmd(
-                "Default", "--port-topology=chained --txq=%s --rxq=%s"
-                % (self.PF_QUEUE, self.PF_QUEUE), eal_param="-w %s"
-                % (self.dut.get_port_pci(self.dut_ports[0])))
+                "all", "--port-topology=chained --txq=%s --rxq=%s"
+                % (self.PF_QUEUE, self.PF_QUEUE))
         elif (self.nic in ["cavium_a063"]):
             eal_opts = ""
             for port in self.dut_ports:
--
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd
@ 2019-05-07  9:33 zhuwenhui
  2019-05-07  9:33 ` Yao, BingX Y
  2019-05-08  5:16 ` Li, WenjieX A
  0 siblings, 2 replies; 3+ messages in thread
From: zhuwenhui @ 2019-05-07  9:33 UTC (permalink / raw)
  To: dts; +Cc: zhuwenhui

When fortville spirit binds multiple ports,
starting testpmd requires more cores.

Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_dynamic_queue.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index 3aad63f..9cd0073 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -27,12 +27,12 @@ class TestDynamicQueue(TestCase):
         self.dut_testpmd = PmdOutput(self.dut)
 
     def set_up(self):
-        # Because of fortville spirit limitation,can't use 2 ports for testing
+        # Fortville_spirit needs more cores to run properly
         if (self.nic in ["fortville_spirit"]):
+            self.verify("len(self.dut.cores)>=7", "Less than seven cares can't run testpmd")
             self.dut_testpmd.start_testpmd(
-                "Default", "--port-topology=chained --txq=%s --rxq=%s"
-                % (self.PF_QUEUE, self.PF_QUEUE), eal_param="-w %s"
-                % (self.dut.get_port_pci(self.dut_ports[0])))
+                "all", "--port-topology=chained --txq=%s --rxq=%s"
+                % (self.PF_QUEUE, self.PF_QUEUE))
         elif (self.nic in ["cavium_a063"]):
             eal_opts = ""
             for port in self.dut_ports:
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd
  2019-05-07  9:33 [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd zhuwenhui
  2019-05-07  9:33 ` Yao, BingX Y
@ 2019-05-08  5:16 ` Li, WenjieX A
  1 sibling, 0 replies; 3+ messages in thread
From: Li, WenjieX A @ 2019-05-08  5:16 UTC (permalink / raw)
  To: Zhu, WenhuiX, dts; +Cc: Zhu, WenhuiX

> +            self.verify("len(self.dut.cores)>=7", "Less than seven
> + cares can't run testpmd")
"cores", not "cares"; please correct the typo, thank you!

BR,
Wenjie

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> Sent: Tuesday, May 7, 2019 5:34 PM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd
> 
> When fortville spirit binds multiple ports, starting testpmd requires more cores.
> 
> Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> ---
>  tests/TestSuite_dynamic_queue.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_dynamic_queue.py
> b/tests/TestSuite_dynamic_queue.py
> index 3aad63f..9cd0073 100644
> --- a/tests/TestSuite_dynamic_queue.py
> +++ b/tests/TestSuite_dynamic_queue.py
> @@ -27,12 +27,12 @@ class TestDynamicQueue(TestCase):
>          self.dut_testpmd = PmdOutput(self.dut)
> 
>      def set_up(self):
> -        # Because of fortville spirit limitation,can't use 2 ports for testing
> +        # Fortville_spirit needs more cores to run properly
>          if (self.nic in ["fortville_spirit"]):
> +            self.verify("len(self.dut.cores)>=7", "Less than seven
> + cares can't run testpmd")
[Li, WenjieX A] cores, not cares
>              self.dut_testpmd.start_testpmd(
> -                "Default", "--port-topology=chained --txq=%s --rxq=%s"
> -                % (self.PF_QUEUE, self.PF_QUEUE), eal_param="-w %s"
> -                % (self.dut.get_port_pci(self.dut_ports[0])))
> +                "all", "--port-topology=chained --txq=%s --rxq=%s"
> +                % (self.PF_QUEUE, self.PF_QUEUE))
>          elif (self.nic in ["cavium_a063"]):
>              eal_opts = ""
>              for port in self.dut_ports:
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-08  5:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07  9:33 [dts] [PATCH V2] tests/dynamic_queue add more cores for testpmd zhuwenhui
2019-05-07  9:33 ` Yao, BingX Y
2019-05-08  5:16 ` Li, WenjieX A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).