test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/pmdrssreta: change hard coded corelist
@ 2019-03-25 19:01 Rami Rosen
  2019-04-03 16:29 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2019-03-25 19:01 UTC (permalink / raw)
  To: dts; +Cc: Rami Rosen

This patch changes the hard coded corelist to the actual cores
in pmdrssreta.

Following conceptually this patch: 
http://mails.dpdk.org/archives/dts/2019-March/005464.html

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 tests/TestSuite_pmdrssreta.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
index 7709730..89086c1 100644
--- a/tests/TestSuite_pmdrssreta.py
+++ b/tests/TestSuite_pmdrssreta.py
@@ -172,6 +172,8 @@ class TestPmdrssreta(TestCase):
         """
         Run at the start of each test suite.
         """
+	cores = self.dut.get_core_list("all")
+	self.coremask = utils.create_mask(cores)
 
         ports = self.dut.get_ports(self.nic)
         self.ports_socket = self.dut.get_numa_id(ports[0])
@@ -242,7 +244,8 @@ class TestPmdrssreta(TestCase):
         localPort = self.tester.get_local_port(dutPorts[0])
         itf = self.tester.get_interface(localPort)
         self.dut.kill_all()
-        self.dut.send_expect("./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=2 --txq=2" % (self.target, self.dut.get_memory_channels()), "testpmd> ", 120)
+        self.dut.send_expect("./%s/app/testpmd  -c %s -n %d -- -i --rxq=2 --txq=2" % (self.target, self.coremask, self.dut.get_memory_channels()), "testpmd> ", 120)
+
         self.dut.send_expect("start", "testpmd> ", 120)
         out = self.dut.send_expect("show port info all", "testpmd> ", 120)
         self.dut.send_expect("quit", "# ", 30)
-- 
2.19.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/pmdrssreta: change hard coded corelist
  2019-03-25 19:01 [dts] [PATCH] tests/pmdrssreta: change hard coded corelist Rami Rosen
@ 2019-04-03 16:29 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-04-03 16:29 UTC (permalink / raw)
  To: Rami Rosen, dts

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Monday, March 25, 2019 12:02 PM
> To: dts@dpdk.org
> Cc: Rami Rosen <ramirose@gmail.com>
> Subject: [dts] [PATCH] tests/pmdrssreta: change hard coded corelist
> 
> This patch changes the hard coded corelist to the actual cores in pmdrssreta.
> 
> Following conceptually this patch:
> http://mails.dpdk.org/archives/dts/2019-March/005464.html
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  tests/TestSuite_pmdrssreta.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
> index 7709730..89086c1 100644
> --- a/tests/TestSuite_pmdrssreta.py
> +++ b/tests/TestSuite_pmdrssreta.py
> @@ -172,6 +172,8 @@ class TestPmdrssreta(TestCase):
>          """
>          Run at the start of each test suite.
>          """
> +	cores = self.dut.get_core_list("all")
> +	self.coremask = utils.create_mask(cores)
> 
>          ports = self.dut.get_ports(self.nic)
>          self.ports_socket = self.dut.get_numa_id(ports[0]) @@ -242,7 +244,8
> @@ class TestPmdrssreta(TestCase):
>          localPort = self.tester.get_local_port(dutPorts[0])
>          itf = self.tester.get_interface(localPort)
>          self.dut.kill_all()
> -        self.dut.send_expect("./%s/app/testpmd  -c fffff -n %d -- -i --
> coremask=0xffffe --rxq=2 --txq=2" % (self.target,
> self.dut.get_memory_channels()), "testpmd> ", 120)
> +        self.dut.send_expect("./%s/app/testpmd  -c %s -n %d -- -i
> + --rxq=2 --txq=2" % (self.target, self.coremask,
> + self.dut.get_memory_channels()), "testpmd> ", 120)
> +
>          self.dut.send_expect("start", "testpmd> ", 120)
>          out = self.dut.send_expect("show port info all", "testpmd> ", 120)
>          self.dut.send_expect("quit", "# ", 30)
> --
> 2.19.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-03 16:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 19:01 [dts] [PATCH] tests/pmdrssreta: change hard coded corelist Rami Rosen
2019-04-03 16:29 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).