test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] nvgre: Added "L3_IPV4" flag for both nvgre and non-nvgre pks for cavium_a063.
@ 2019-04-17  5:16 usurekha
  2019-04-18 23:36 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: usurekha @ 2019-04-17  5:16 UTC (permalink / raw)
  To: dts; +Cc: fmasood, avijay, jerinj, usurekha

From: usurekha <usurekha@marvell.com>

As otx2 hw is capable of identifying pkt as "L3_IPV4" for both normal and
tunnelled pkts instead of "L3_IPV4_EXT_UNKNOWN" flag.
So added "L3_IPv4" flag to identify the pkt for cavium device.

Signed-off-by: usurekha <usurekha@marvell.com>
---
 tests/TestSuite_nvgre.py | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
index c4da924..aea915c 100644
--- a/tests/TestSuite_nvgre.py
+++ b/tests/TestSuite_nvgre.py
@@ -158,11 +158,23 @@ class NvgreTestConfig(object):
         self.inner_l4_invalid = 0
         self.payload_size = 18
 
-    def packet_type(self):
+    def packet_type(self,nic = None):
         """
         Return nvgre packet type
         """
-        if self.outer_ip_proto != 47:
+        if "cavium_a063" in nic:
+            if self.outer_ip_proto !=47:
+                if self.outer_l3_type == 'IPv4':
+                    return 'L3_IPV4'
+                else:
+                    return 'L3_IPV6'
+            else:
+                if self.inner_l3_type == 'IPv4':
+                    return 'L3_IPV4'
+                else:
+                    return 'L3_IPV6'
+
+        elif self.outer_ip_proto != 47:
             if self.outer_l3_type == 'IPv4':
                 return 'L3_IPV4_EXT_UNKNOWN'
             else:
@@ -349,7 +361,7 @@ class TestNvgre(TestCase):
         nvgre Prerequisites
         """
         # this feature only enable in FVL now
-        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV"]:
+        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "cavium_a063"]:
             self.compile_switch = 'CONFIG_RTE_LIBRTE_I40E_INC_VECTOR'
         elif self.nic in ["sageville", "sagepond"]:
             self.compile_switch = 'CONFIG_RTE_IXGBE_INC_VECTOR'
@@ -458,7 +470,7 @@ class TestNvgre(TestCase):
         # check whether detect nvgre type
         out = self.dut.get_session_output()
         print out
-        self.verify(config.packet_type() in out, "Nvgre Packet not detected")
+        self.verify(config.packet_type(self.nic) in out, "Nvgre Packet not detected")
         self.dut.send_expect("show port stats all", "testpmd>", 10)
         self.dut.send_expect("stop", "testpmd>", 10)
         self.dut.send_expect("quit", "#", 10)
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] nvgre: Added "L3_IPV4" flag for both nvgre and non-nvgre pks for cavium_a063.
  2019-04-17  5:16 [dts] [PATCH] nvgre: Added "L3_IPV4" flag for both nvgre and non-nvgre pks for cavium_a063 usurekha
@ 2019-04-18 23:36 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-04-18 23:36 UTC (permalink / raw)
  To: usurekha, dts; +Cc: fmasood, avijay, jerinj

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> usurekha@marvell.com
> Sent: Tuesday, April 16, 2019 10:16 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; jerinj@marvell.com;
> usurekha <usurekha@marvell.com>
> Subject: [dts] [PATCH] nvgre: Added "L3_IPV4" flag for both nvgre and non-
> nvgre pks for cavium_a063.
> 
> From: usurekha <usurekha@marvell.com>
> 
> As otx2 hw is capable of identifying pkt as "L3_IPV4" for both normal and
> tunnelled pkts instead of "L3_IPV4_EXT_UNKNOWN" flag.
> So added "L3_IPv4" flag to identify the pkt for cavium device.
> 
> Signed-off-by: usurekha <usurekha@marvell.com>
> ---
>  tests/TestSuite_nvgre.py | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py index
> c4da924..aea915c 100644
> --- a/tests/TestSuite_nvgre.py
> +++ b/tests/TestSuite_nvgre.py
> @@ -158,11 +158,23 @@ class NvgreTestConfig(object):
>          self.inner_l4_invalid = 0
>          self.payload_size = 18
> 
> -    def packet_type(self):
> +    def packet_type(self,nic = None):
>          """
>          Return nvgre packet type
>          """
> -        if self.outer_ip_proto != 47:
> +        if "cavium_a063" in nic:
> +            if self.outer_ip_proto !=47:
> +                if self.outer_l3_type == 'IPv4':
> +                    return 'L3_IPV4'
> +                else:
> +                    return 'L3_IPV6'
> +            else:
> +                if self.inner_l3_type == 'IPv4':
> +                    return 'L3_IPV4'
> +                else:
> +                    return 'L3_IPV6'
> +
> +        elif self.outer_ip_proto != 47:
>              if self.outer_l3_type == 'IPv4':
>                  return 'L3_IPV4_EXT_UNKNOWN'
>              else:
> @@ -349,7 +361,7 @@ class TestNvgre(TestCase):
>          nvgre Prerequisites
>          """
>          # this feature only enable in FVL now
> -        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortville_25g", "fortpark_TLV"]:
> +        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortville_25g", "fortpark_TLV", "cavium_a063"]:
>              self.compile_switch = 'CONFIG_RTE_LIBRTE_I40E_INC_VECTOR'
>          elif self.nic in ["sageville", "sagepond"]:
>              self.compile_switch = 'CONFIG_RTE_IXGBE_INC_VECTOR'
> @@ -458,7 +470,7 @@ class TestNvgre(TestCase):
>          # check whether detect nvgre type
>          out = self.dut.get_session_output()
>          print out
> -        self.verify(config.packet_type() in out, "Nvgre Packet not detected")
> +        self.verify(config.packet_type(self.nic) in out, "Nvgre Packet
> + not detected")
>          self.dut.send_expect("show port stats all", "testpmd>", 10)
>          self.dut.send_expect("stop", "testpmd>", 10)
>          self.dut.send_expect("quit", "#", 10)
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-18 23:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17  5:16 [dts] [PATCH] nvgre: Added "L3_IPV4" flag for both nvgre and non-nvgre pks for cavium_a063 usurekha
2019-04-18 23:36 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).