test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix the config filename
@ 2019-05-20 21:43 lihong
  2019-05-21  5:37 ` Zhu, WenhuiX
  2019-05-29  2:13 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: lihong @ 2019-05-20 21:43 UTC (permalink / raw)
  To: dts; +Cc: lihong

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_unit_tests_pmd_perf.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_unit_tests_pmd_perf.py b/tests/TestSuite_unit_tests_pmd_perf.py
index 0d332bf..ea221df 100644
--- a/tests/TestSuite_unit_tests_pmd_perf.py
+++ b/tests/TestSuite_unit_tests_pmd_perf.py
@@ -61,20 +61,20 @@ class TestUnitTestsPmdPerf(TestCase):
         """
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
-        [self.arch, machine, env, toolchain] = self.target.split('-')
+        [self.arch, machine, _, toolchain] = self.target.split('-')
         self.verify(self.arch in ["x86_64", "arm64"], "pmd perf request running in x86_64 or arm64")
         self.burst_ctlmodes = ['poll_before_xmit', 'poll_after_xmit']
         self.rxtx_modes = ['vector', 'scalar', 'full', 'hybrid']
         self.anchors = ['rxtx', 'rxonly', 'txonly']
 
         # for better scalar performance data, need disable CONFIG_RTE_IXGBE_INC_VECTOR
-        [arch, machine, env, toolchain] = self.target.split('-')
-        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=y/CONFIG_RTE_IXGBE_INC_VECTOR=n/' config/common_%s" % env, "# ", 30)
+        [arch, machine, _, toolchain] = self.target.split('-')
+        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=y/CONFIG_RTE_IXGBE_INC_VECTOR=n/' config/common_base", "# ", 30)
         self.dut.build_install_dpdk(self.target)
         out = self.dut.build_dpdk_apps('./app/test/')
         self.verify('make: Leaving directory' in out, "Compilation failed")
         self.dut.send_expect("mv -f ./app/test/test ./app/test/test_scalar", "# ")
-        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=n/CONFIG_RTE_IXGBE_INC_VECTOR=y/' config/common_%s" % env, "# ", 30)
+        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=n/CONFIG_RTE_IXGBE_INC_VECTOR=y/' config/common_base", "# ", 30)
         self.dut.build_install_dpdk(self.target)
         out = self.dut.build_dpdk_apps('./app/test/')
         self.verify('make: Leaving directory' in out, "Compilation failed")
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] fix the config filename
  2019-05-20 21:43 [dts] [PATCH V1] fix the config filename lihong
@ 2019-05-21  5:37 ` Zhu, WenhuiX
  2019-05-29  2:13 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-05-21  5:37 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
Sent: Tuesday, May 21, 2019 5:44 AM
To: dts@dpdk.org
Cc: Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts] [PATCH V1] fix the config filename

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_unit_tests_pmd_perf.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_unit_tests_pmd_perf.py b/tests/TestSuite_unit_tests_pmd_perf.py
index 0d332bf..ea221df 100644
--- a/tests/TestSuite_unit_tests_pmd_perf.py
+++ b/tests/TestSuite_unit_tests_pmd_perf.py
@@ -61,20 +61,20 @@ class TestUnitTestsPmdPerf(TestCase):
         """
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
-        [self.arch, machine, env, toolchain] = self.target.split('-')
+        [self.arch, machine, _, toolchain] = self.target.split('-')
         self.verify(self.arch in ["x86_64", "arm64"], "pmd perf request running in x86_64 or arm64")
         self.burst_ctlmodes = ['poll_before_xmit', 'poll_after_xmit']
         self.rxtx_modes = ['vector', 'scalar', 'full', 'hybrid']
         self.anchors = ['rxtx', 'rxonly', 'txonly']
 
         # for better scalar performance data, need disable CONFIG_RTE_IXGBE_INC_VECTOR
-        [arch, machine, env, toolchain] = self.target.split('-')
-        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=y/CONFIG_RTE_IXGBE_INC_VECTOR=n/' config/common_%s" % env, "# ", 30)
+        [arch, machine, _, toolchain] = self.target.split('-')
+        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=y/CONFIG_RTE_IXGBE_INC_VECTOR=n/' config/common_base", "# ", 30)
         self.dut.build_install_dpdk(self.target)
         out = self.dut.build_dpdk_apps('./app/test/')
         self.verify('make: Leaving directory' in out, "Compilation failed")
         self.dut.send_expect("mv -f ./app/test/test ./app/test/test_scalar", "# ")
-        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=n/CONFIG_RTE_IXGBE_INC_VECTOR=y/' config/common_%s" % env, "# ", 30)
+        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_IXGBE_INC_VECTOR=n/CONFIG_RTE_IXGBE_INC_VECTOR=y/' config/common_base", "# ", 30)
         self.dut.build_install_dpdk(self.target)
         out = self.dut.build_dpdk_apps('./app/test/')
         self.verify('make: Leaving directory' in out, "Compilation failed")
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] fix the config filename
  2019-05-20 21:43 [dts] [PATCH V1] fix the config filename lihong
  2019-05-21  5:37 ` Zhu, WenhuiX
@ 2019-05-29  2:13 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-05-29  2:13 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Tuesday, May 21, 2019 5:44 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] fix the config filename
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_unit_tests_pmd_perf.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_pmd_perf.py
> b/tests/TestSuite_unit_tests_pmd_perf.py
> index 0d332bf..ea221df 100644
> --- a/tests/TestSuite_unit_tests_pmd_perf.py
> +++ b/tests/TestSuite_unit_tests_pmd_perf.py
> @@ -61,20 +61,20 @@ class TestUnitTestsPmdPerf(TestCase):
>          """
>          self.dut_ports = self.dut.get_ports(self.nic)
>          self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
> -        [self.arch, machine, env, toolchain] = self.target.split('-')
> +        [self.arch, machine, _, toolchain] = self.target.split('-')
>          self.verify(self.arch in ["x86_64", "arm64"], "pmd perf request running
> in x86_64 or arm64")
>          self.burst_ctlmodes = ['poll_before_xmit', 'poll_after_xmit']
>          self.rxtx_modes = ['vector', 'scalar', 'full', 'hybrid']
>          self.anchors = ['rxtx', 'rxonly', 'txonly']
> 
>          # for better scalar performance data, need disable
> CONFIG_RTE_IXGBE_INC_VECTOR
> -        [arch, machine, env, toolchain] = self.target.split('-')
> -        self.dut.send_expect("sed -i -e
> 's/CONFIG_RTE_IXGBE_INC_VECTOR=y/CONFIG_RTE_IXGBE_INC_VECTOR=n/'
> config/common_%s" % env, "# ", 30)
> +        [arch, machine, _, toolchain] = self.target.split('-')
> +        self.dut.send_expect("sed -i -e
> 's/CONFIG_RTE_IXGBE_INC_VECTOR=y/CONFIG_RTE_IXGBE_INC_VECTOR=n/'
> config/common_base", "# ", 30)
>          self.dut.build_install_dpdk(self.target)
>          out = self.dut.build_dpdk_apps('./app/test/')
>          self.verify('make: Leaving directory' in out, "Compilation failed")
>          self.dut.send_expect("mv -f ./app/test/test ./app/test/test_scalar", "# ")
> -        self.dut.send_expect("sed -i -e
> 's/CONFIG_RTE_IXGBE_INC_VECTOR=n/CONFIG_RTE_IXGBE_INC_VECTOR=y/'
> config/common_%s" % env, "# ", 30)
> +        self.dut.send_expect("sed -i -e
> 's/CONFIG_RTE_IXGBE_INC_VECTOR=n/CONFIG_RTE_IXGBE_INC_VECTOR=y/'
> config/common_base", "# ", 30)
>          self.dut.build_install_dpdk(self.target)
>          out = self.dut.build_dpdk_apps('./app/test/')
>          self.verify('make: Leaving directory' in out, "Compilation failed")
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-29  2:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20 21:43 [dts] [PATCH V1] fix the config filename lihong
2019-05-21  5:37 ` Zhu, WenhuiX
2019-05-29  2:13 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).