test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/rxtx_offload: add -c params when use tcpdump read pcap file
@ 2019-06-05 23:03 lihong
  2019-06-06  7:21 ` Zhu, WenhuiX
  2019-06-12  6:45 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: lihong @ 2019-06-05 23:03 UTC (permalink / raw)
  To: dts; +Cc: yuan.peng, lihong

The tcpdump capture all the tx packets from testpmd, read the pcap
file will use too much time, and it not need to read all the packet
in the pcap file. Using 1024 packets to verify the tx packets is enough.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_rxtx_offload.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index 53f7cf9..0ae83f4 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -269,7 +269,7 @@ class TestRxTx_Offload(TestCase):
     def get_tcpdump_package(self):
 
         self.tester.send_expect("killall tcpdump", "#")
-        return self.tester.send_expect("tcpdump -nn -e -v -r ./getPackageByTcpdump.cap", "#", 120)
+        return self.tester.send_expect("tcpdump -nn -e -v -c 1024 -r ./getPackageByTcpdump.cap", "#", 120)
 
     def test_rxoffload_port(self):
         """
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/rxtx_offload: add -c params when use tcpdump read pcap file
  2019-06-05 23:03 [dts] [PATCH V1] tests/rxtx_offload: add -c params when use tcpdump read pcap file lihong
@ 2019-06-06  7:21 ` Zhu, WenhuiX
  2019-06-12  6:45 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-06-06  7:21 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Peng, Yuan, Ma, LihongX


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
Sent: Thursday, June 6, 2019 7:03 AM
To: dts@dpdk.org
Cc: Peng, Yuan <yuan.peng@intel.com>; Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts] [PATCH V1] tests/rxtx_offload: add -c params when use tcpdump read pcap file

The tcpdump capture all the tx packets from testpmd, read the pcap file will use too much time, and it not need to read all the packet in the pcap file. Using 1024 packets to verify the tx packets is enough.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_rxtx_offload.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py index 53f7cf9..0ae83f4 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -269,7 +269,7 @@ class TestRxTx_Offload(TestCase):
     def get_tcpdump_package(self):
 
         self.tester.send_expect("killall tcpdump", "#")
-        return self.tester.send_expect("tcpdump -nn -e -v -r ./getPackageByTcpdump.cap", "#", 120)
+        return self.tester.send_expect("tcpdump -nn -e -v -c 1024 -r 
+ ./getPackageByTcpdump.cap", "#", 120)
 
     def test_rxoffload_port(self):
         """
--
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/rxtx_offload: add -c params when use tcpdump read pcap file
  2019-06-05 23:03 [dts] [PATCH V1] tests/rxtx_offload: add -c params when use tcpdump read pcap file lihong
  2019-06-06  7:21 ` Zhu, WenhuiX
@ 2019-06-12  6:45 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-06-12  6:45 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Peng, Yuan, Ma, LihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Thursday, June 6, 2019 7:03 AM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] tests/rxtx_offload: add -c params when use
> tcpdump read pcap file
> 
> The tcpdump capture all the tx packets from testpmd, read the pcap file will
> use too much time, and it not need to read all the packet in the pcap file.
> Using 1024 packets to verify the tx packets is enough.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_rxtx_offload.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
> index 53f7cf9..0ae83f4 100644
> --- a/tests/TestSuite_rxtx_offload.py
> +++ b/tests/TestSuite_rxtx_offload.py
> @@ -269,7 +269,7 @@ class TestRxTx_Offload(TestCase):
>      def get_tcpdump_package(self):
> 
>          self.tester.send_expect("killall tcpdump", "#")
> -        return self.tester.send_expect("tcpdump -nn -e -v -
> r ./getPackageByTcpdump.cap", "#", 120)
> +        return self.tester.send_expect("tcpdump -nn -e -v -c 1024 -r
> + ./getPackageByTcpdump.cap", "#", 120)
> 
>      def test_rxoffload_port(self):
>          """
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-12  6:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 23:03 [dts] [PATCH V1] tests/rxtx_offload: add -c params when use tcpdump read pcap file lihong
2019-06-06  7:21 ` Zhu, WenhuiX
2019-06-12  6:45 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).