test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Han, YingyaX" <yingyax.han@intel.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1]test_plan/vf_l3fwd: add vf l3fwd performance test plan
Date: Wed, 8 May 2019 01:38:44 +0000	[thread overview]
Message-ID: <9AC1400278453341942179604C2BF1260B93C24D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CAHLOa7TgvYYNqTZfG5T1XZV_ocEXeT1PezSLCQVcRPse6gP9_g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

Hi Rosen,

Thank you for pointing out the mistake.
I’ll modify the patch and sent it again.

Thanks,
Yingya

From: Rami Rosen [mailto:ramirose@gmail.com]
Sent: Wednesday, May 8, 2019 2:28 AM
To: Han, YingyaX <yingyax.han@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1]test_plan/vf_l3fwd: add vf l3fwd performance test plan

Hi Han,
Thanks for this patch.

Minor comments are following:

performace -> Should be performance:
> +Test Case 1: Measure performace with kernel PF & dpdk VF

traffic configuration meet LPM=> should be: traffic configuration meets LPM
>+make sure your traffic configuration meet LPM rules, and will go to all queues, all ports.

Again also here: performace -> Should be performance:
>+Test Case 2: Measure performace with dpdk PF & dpdk VF

Again also here: traffic configuration meet LPM=> should be: traffic configuration meets LPM
>+make sure your traffic configuration meet LPM rules, and will go to all queues, all ports.

Reviewed-by: Rami Rosen <ramirose@gmail.com<mailto:ramirose@gmail.com>>


[-- Attachment #2: Type: text/html, Size: 5276 bytes --]

      reply	other threads:[~2019-05-08  2:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 16:00 han yingya
2019-05-07 18:27 ` Rami Rosen
2019-05-08  1:38   ` Han, YingyaX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9AC1400278453341942179604C2BF1260B93C24D@SHSMSX101.ccr.corp.intel.com \
    --to=yingyax.han@intel.com \
    --cc=dts@dpdk.org \
    --cc=ramirose@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).