[dts] [PATCH V1] increase send packet number when bonding mode is 5

test suite reviews and discussions
 help / color / mirror / Atom feed

* [dts] [PATCH V1] increase send packet number when bonding mode is 5
@ 2019-05-07  0:30 lihong
  2019-05-08  5:30 ` Wu, ChangqingX
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: lihong @ 2019-05-07  0:30 UTC (permalink / raw)
  To: dts; +Cc: lihong

when bonding mode is 5, the transmit should load balancing for tx,
if receive packet number not enough, it will not reflect the balance
state. So change the send packet number from 1000 to 100000.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_pmd_bonded.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_pmd_bonded.py b/tests/TestSuite_pmd_bonded.py
index 2d4856a..78d5d21 100644
--- a/tests/TestSuite_pmd_bonded.py
+++ b/tests/TestSuite_pmd_bonded.py
@@ -196,7 +196,7 @@ class TestPmdBonded(TestCase):
         """
         Send count packet to portid
         count: 1 or 2 or 3 or ... or 'MANY'
-               if count is 'MANY', then set count=1000,
+               if count is 'MANY', then set count=100000,
                send packets during 5 seconds.
         ether_ip:
             'ether':
@@ -226,7 +226,7 @@ class TestPmdBonded(TestCase):
         except ValueError as e:
             if count == 'MANY':
                 during = 5
-                count = 1000
+                count = 100000
             else:
                 raise e
 
@@ -261,7 +261,7 @@ UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
                 self.tester.scapy_append('sendp([Ether(dst=nutmac, src=srcmac)/Dot1Q(vlan=vlanvalue)/IP(dst=destip, src=srcip, len=%s)/\
 UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)' % (pktlen, padding, itf, count))
 
-            self.tester.scapy_execute()
+            self.tester.scapy_execute(timeout=180)
             loop += 1
 
             now = time.time()
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] increase send packet number when bonding mode is 5
  2019-05-07  0:30 [dts] [PATCH V1] increase send packet number when bonding mode is 5 lihong
@ 2019-05-08  5:30 ` Wu, ChangqingX
  2019-05-08  7:17 ` Li, WenjieX A
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Wu, ChangqingX @ 2019-05-08  5:30 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Tested-by: Wu, ChangqingX <changqingx.wu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
Sent: Tuesday, May 7, 2019 8:31 AM
To: dts@dpdk.org
Cc: Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts] [PATCH V1] increase send packet number when bonding mode is 5

when bonding mode is 5, the transmit should load balancing for tx, if receive packet number not enough, it will not reflect the balance state. So change the send packet number from 1000 to 100000.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_pmd_bonded.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_pmd_bonded.py b/tests/TestSuite_pmd_bonded.py index 2d4856a..78d5d21 100644
--- a/tests/TestSuite_pmd_bonded.py
+++ b/tests/TestSuite_pmd_bonded.py
@@ -196,7 +196,7 @@ class TestPmdBonded(TestCase):
         """
         Send count packet to portid
         count: 1 or 2 or 3 or ... or 'MANY'
-               if count is 'MANY', then set count=1000,
+               if count is 'MANY', then set count=100000,
                send packets during 5 seconds.
         ether_ip:
             'ether':
@@ -226,7 +226,7 @@ class TestPmdBonded(TestCase):
         except ValueError as e:
             if count == 'MANY':
                 during = 5
-                count = 1000
+                count = 100000
             else:
                 raise e
 
@@ -261,7 +261,7 @@ UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
                 self.tester.scapy_append('sendp([Ether(dst=nutmac, src=srcmac)/Dot1Q(vlan=vlanvalue)/IP(dst=destip, src=srcip, len=%s)/\  UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)' % (pktlen, padding, itf, count))
 
-            self.tester.scapy_execute()
+            self.tester.scapy_execute(timeout=180)
             loop += 1
 
             now = time.time()
--
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] increase send packet number when bonding mode is 5
  2019-05-07  0:30 [dts] [PATCH V1] increase send packet number when bonding mode is 5 lihong
  2019-05-08  5:30 ` Wu, ChangqingX
@ 2019-05-08  7:17 ` Li, WenjieX A
  2019-05-17  8:25 ` Chen, Zhaoyan
  2019-05-22  3:26 ` Tu, Lijuan
  3 siblings, 0 replies; 5+ messages in thread
From: Li, WenjieX A @ 2019-05-08  7:17 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Reviewed-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Tuesday, May 7, 2019 8:31 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] increase send packet number when bonding mode is 5
> 
> when bonding mode is 5, the transmit should load balancing for tx, if receive
> packet number not enough, it will not reflect the balance state. So change the
> send packet number from 1000 to 100000.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_pmd_bonded.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_pmd_bonded.py b/tests/TestSuite_pmd_bonded.py
> index 2d4856a..78d5d21 100644
> --- a/tests/TestSuite_pmd_bonded.py
> +++ b/tests/TestSuite_pmd_bonded.py
> @@ -196,7 +196,7 @@ class TestPmdBonded(TestCase):
>          """
>          Send count packet to portid
>          count: 1 or 2 or 3 or ... or 'MANY'
> -               if count is 'MANY', then set count=1000,
> +               if count is 'MANY', then set count=100000,
>                 send packets during 5 seconds.
>          ether_ip:
>              'ether':
> @@ -226,7 +226,7 @@ class TestPmdBonded(TestCase):
>          except ValueError as e:
>              if count == 'MANY':
>                  during = 5
> -                count = 1000
> +                count = 100000
>              else:
>                  raise e
> 
> @@ -261,7 +261,7 @@ UDP(sport=srcport,
> dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
>                  self.tester.scapy_append('sendp([Ether(dst=nutmac,
> src=srcmac)/Dot1Q(vlan=vlanvalue)/IP(dst=destip, src=srcip, len=%s)/\
> UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s",
> count=%d)' % (pktlen, padding, itf, count))
> 
> -            self.tester.scapy_execute()
> +            self.tester.scapy_execute(timeout=180)
>              loop += 1
> 
>              now = time.time()
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] increase send packet number when bonding mode is 5
  2019-05-07  0:30 [dts] [PATCH V1] increase send packet number when bonding mode is 5 lihong
  2019-05-08  5:30 ` Wu, ChangqingX
  2019-05-08  7:17 ` Li, WenjieX A
@ 2019-05-17  8:25 ` Chen, Zhaoyan
  2019-05-22  3:26 ` Tu, Lijuan
  3 siblings, 0 replies; 5+ messages in thread
From: Chen, Zhaoyan @ 2019-05-17  8:25 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX, Chen, Zhaoyan

Acked-by: Zhaoyan Chen<zhaoyan.chen@intel.com>



Regards,
Zhaoyan Chen

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Tuesday, May 7, 2019 8:31 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] increase send packet number when bonding mode is 5
> 
> when bonding mode is 5, the transmit should load balancing for tx, if receive packet
> number not enough, it will not reflect the balance state. So change the send packet
> number from 1000 to 100000.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_pmd_bonded.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_pmd_bonded.py b/tests/TestSuite_pmd_bonded.py index
> 2d4856a..78d5d21 100644
> --- a/tests/TestSuite_pmd_bonded.py
> +++ b/tests/TestSuite_pmd_bonded.py
> @@ -196,7 +196,7 @@ class TestPmdBonded(TestCase):
>          """
>          Send count packet to portid
>          count: 1 or 2 or 3 or ... or 'MANY'
> -               if count is 'MANY', then set count=1000,
> +               if count is 'MANY', then set count=100000,
>                 send packets during 5 seconds.
>          ether_ip:
>              'ether':
> @@ -226,7 +226,7 @@ class TestPmdBonded(TestCase):
>          except ValueError as e:
>              if count == 'MANY':
>                  during = 5
> -                count = 1000
> +                count = 100000
>              else:
>                  raise e
> 
> @@ -261,7 +261,7 @@ UDP(sport=srcport,
> dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
>                  self.tester.scapy_append('sendp([Ether(dst=nutmac,
> src=srcmac)/Dot1Q(vlan=vlanvalue)/IP(dst=destip, src=srcip, len=%s)/\
> UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s",
> count=%d)' % (pktlen, padding, itf, count))
> 
> -            self.tester.scapy_execute()
> +            self.tester.scapy_execute(timeout=180)
>              loop += 1
> 
>              now = time.time()
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] increase send packet number when bonding mode is 5
  2019-05-07  0:30 [dts] [PATCH V1] increase send packet number when bonding mode is 5 lihong
                   ` (2 preceding siblings ...)
  2019-05-17  8:25 ` Chen, Zhaoyan
@ 2019-05-22  3:26 ` Tu, Lijuan
  3 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2019-05-22  3:26 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Tuesday, May 7, 2019 8:31 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] increase send packet number when bonding mode
> is 5
> 
> when bonding mode is 5, the transmit should load balancing for tx, if receive
> packet number not enough, it will not reflect the balance state. So change
> the send packet number from 1000 to 100000.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_pmd_bonded.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_pmd_bonded.py
> b/tests/TestSuite_pmd_bonded.py index 2d4856a..78d5d21 100644
> --- a/tests/TestSuite_pmd_bonded.py
> +++ b/tests/TestSuite_pmd_bonded.py
> @@ -196,7 +196,7 @@ class TestPmdBonded(TestCase):
>          """
>          Send count packet to portid
>          count: 1 or 2 or 3 or ... or 'MANY'
> -               if count is 'MANY', then set count=1000,
> +               if count is 'MANY', then set count=100000,
>                 send packets during 5 seconds.
>          ether_ip:
>              'ether':
> @@ -226,7 +226,7 @@ class TestPmdBonded(TestCase):
>          except ValueError as e:
>              if count == 'MANY':
>                  during = 5
> -                count = 1000
> +                count = 100000
>              else:
>                  raise e
> 
> @@ -261,7 +261,7 @@ UDP(sport=srcport,
> dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
>                  self.tester.scapy_append('sendp([Ether(dst=nutmac,
> src=srcmac)/Dot1Q(vlan=vlanvalue)/IP(dst=destip, src=srcip, len=%s)/\
> UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s",
> count=%d)' % (pktlen, padding, itf, count))
> 
> -            self.tester.scapy_execute()
> +            self.tester.scapy_execute(timeout=180)
>              loop += 1
> 
>              now = time.time()
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-22  3:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07  0:30 [dts] [PATCH V1] increase send packet number when bonding mode is 5 lihong
2019-05-08  5:30 ` Wu, ChangqingX
2019-05-08  7:17 ` Li, WenjieX A
2019-05-17  8:25 ` Chen, Zhaoyan
2019-05-22  3:26 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).