test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/rte_flow_common:fix no fdir matchedid issue
@ 2021-07-28 15:15 Zhimin Huang
  2021-08-03  5:09 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Zhimin Huang @ 2021-07-28 15:15 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

*.when expect markid is 0 and testpmd not have fdir matchid,
it should be failed for this issue, so add empty set judgement.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 tests/rte_flow_common.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/rte_flow_common.py b/tests/rte_flow_common.py
index 42afbfd1..591aa5a1 100644
--- a/tests/rte_flow_common.py
+++ b/tests/rte_flow_common.py
@@ -400,7 +400,7 @@ def check_mark(out, pkt_num, check_param, stats=True):
                 raise Exception("got wrong output, not match pattern %s" % p.pattern)
             if mark_id is not None:
                 mark_list = set(int(i, CVL_TXQ_RXQ_NUMBER) for i in fdir_scanner.findall(out))
-                verify(all([i == check_param["mark_id"] for i in mark_list]),
+                verify(all([i == check_param["mark_id"] for i in mark_list]) and mark_list,
                        "failed: some packet mark id of %s not match" % mark_list)
             else:
                 verify(not fdir_flag, "output should not include mark id")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/rte_flow_common:fix no fdir matchedid issue
  2021-07-28 15:15 [dts] [PATCH V1] tests/rte_flow_common:fix no fdir matchedid issue Zhimin Huang
@ 2021-08-03  5:09 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-08-03  5:09 UTC (permalink / raw)
  To: Huang, ZhiminX, dts; +Cc: Huang, ZhiminX

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: 2021年7月28日 23:16
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] tests/rte_flow_common:fix no fdir matchedid issue
> 
> *.when expect markid is 0 and testpmd not have fdir matchid, it should be failed
> for this issue, so add empty set judgement.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-03  5:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 15:15 [dts] [PATCH V1] tests/rte_flow_common:fix no fdir matchedid issue Zhimin Huang
2021-08-03  5:09 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).