From: "Dong, JunX" <junx.dong@intel.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Tu, Lijuan" <lijuan.tu@intel.com>,
"ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: RE: [PATCH v1] framework/qemu_kvm: fix pylama errors
Date: Thu, 16 Dec 2021 03:15:11 +0000 [thread overview]
Message-ID: <BN9PR11MB5274F8278788879B5ED2C517EA779@BN9PR11MB5274.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1638793303-2955-1-git-send-email-juraj.linkes@pantheon.tech>
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Monday, December 6, 2021 8:22 PM
> To: Tu, Lijuan <lijuan.tu@intel.com>; ohilyard@iol.unh.edu
> Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] framework/qemu_kvm: fix pylama errors
>
> Pylama found the following errors:
> framework/qemu_kvm.py:1498: [E] E0602 Undefined variable
> 'assgined_pcis_info' [pylint]
> framework/qemu_kvm.py:1508: [E] E0602 Undefined variable
> 'assinged_pcis_info' [pylint]
> framework/qemu_kvm.py:1508: [E] E1101 Instance of 'QEMUKvm' has no
> '__vf_has_been_assinged' member [pylint]
> framework/qemu_kvm.py:1587: [E] E1121 Too many positional arguments
> for method call [pylint]
> framework/qemu_kvm.py:1733: [E] E0213 Method should have "self" as first
> argument [pylint]
> framework/qemu_kvm.py:1750: [E] E1102 func is not callable [pylint]
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> Lijuan, please add additional people to review if needed.
> ---
> framework/qemu_kvm.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
> 515a4c04..32cd668e 100644
> --- a/framework/qemu_kvm.py
> +++ b/framework/qemu_kvm.py
> @@ -1495,7 +1495,7 @@ class QEMUKvm(VirtBase):
> if self.__is_vf_pci(pci):
> assigned_pcis_info[pci]['is_vf'] = True
> pf_pci = self.__map_vf_to_pf(pci)
> - assgined_pcis_info[pci]['pf_pci'] = pf_pci
> + assigned_pcis_info[pci]['pf_pci'] = pf_pci
> if self.virt_pool.alloc_vf_from_pf(vm=self.vm_name,
> pf_pci=pf_pci,
> *[pci]):
> @@ -1505,7 +1505,7 @@ class QEMUKvm(VirtBase):
> else:
> # check that if any VF of specified PF has been
> # used, raise exception
> - vf_pci = self.__vf_has_been_assinged(pci, **assinged_pcis_info)
> + vf_pci = self.__vf_has_been_assigned(pci,
> + **assigned_pcis_info)
> if vf_pci:
> raise Exception(
> "Error: A VF [%s] generated by PF [%s] has " % @@ -1584,7
> +1584,7 @@ class QEMUKvm(VirtBase):
> """
> Get IP which VM is connected by bridge.
> """
> - out = self.control_command('ping', '60')
> + out = self.control_command('ping')
> if not out:
> time.sleep(10)
> out = self.control_command('ifconfig') @@ -1730,6 +1730,7 @@ class
> QEMUKvm(VirtBase):
>
> return cores
>
> + @staticmethod
Because below method used as decorator, so if it was decorated by staticmethod description, it will introduce issues same as nics/net_device module.
> def handle_control_session(func):
> """
> Wrapper function to handle serial port, must return serial to host session
> --
> 2.20.1
next prev parent reply other threads:[~2021-12-16 3:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:21 Juraj Linkeš
2021-12-16 3:15 ` Dong, JunX [this message]
2022-01-19 12:11 ` [PATCH v2] " Juraj Linkeš
2022-01-25 5:12 ` Dong, JunX
2022-01-25 5:34 ` Dong, JunX
2022-01-25 6:16 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5274F8278788879B5ED2C517EA779@BN9PR11MB5274.namprd11.prod.outlook.com \
--to=junx.dong@intel.com \
--cc=dts@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).