test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf_jumboframe:disable promise mode to forbid misc packets
@ 2019-04-17  9:27 zhang,yan
  2019-04-17 15:26 ` Rami Rosen
  0 siblings, 1 reply; 2+ messages in thread
From: zhang,yan @ 2019-04-17  9:27 UTC (permalink / raw)
  To: dts; +Cc: zhang,yan

Because  some miscellaneous packets may appearing on the receiving port, so use command "set promisc all off" to forbidden them

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index 32f89d7..dc16479 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -212,6 +212,7 @@ class TestVfJumboFrame(TestCase):
         self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_STANDARD_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
+        self.vm_testpmd.execute_cmd("set promisc all off")
         self.vm_testpmd.execute_cmd("start")
 
         self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
@@ -232,6 +233,7 @@ class TestVfJumboFrame(TestCase):
         self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
+        self.vm_testpmd.execute_cmd("set promisc all off")
         self.vm_testpmd.execute_cmd("start")
 
         self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
@@ -252,6 +254,7 @@ class TestVfJumboFrame(TestCase):
         self.vm_testpmd.start_testpmd("Default", "--port-topology=loop --tx-offloads=0x8000" )
 
         self.vm_testpmd.execute_cmd("set fwd mac")
+        self.vm_testpmd.execute_cmd("set promisc all off")
         self.vm_testpmd.execute_cmd("start")
 
         # On igb, for example i350, refer to :DPDK-1117
@@ -280,6 +283,7 @@ class TestVfJumboFrame(TestCase):
         self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
+        self.vm_testpmd.execute_cmd("set promisc all off")
         self.vm_testpmd.execute_cmd("start")
 
         self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1)
@@ -301,6 +305,7 @@ class TestVfJumboFrame(TestCase):
         self.vm_testpmd.start_testpmd("Default", "--max-pkt-len=%d --port-topology=loop --tx-offloads=0x8000" % (ETHER_JUMBO_FRAME_MTU))
 
         self.vm_testpmd.execute_cmd("set fwd mac")
+        self.vm_testpmd.execute_cmd("set promisc all off")
         self.vm_testpmd.execute_cmd("start")
 
         # On 1G NICs, when the jubmo frame MTU set as 9000, the software adjust it to 9004.
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_jumboframe:disable promise mode to forbid misc packets
  2019-04-17  9:27 [dts] [PATCH V1] tests/vf_jumboframe:disable promise mode to forbid misc packets zhang,yan
@ 2019-04-17 15:26 ` Rami Rosen
  0 siblings, 0 replies; 2+ messages in thread
From: Rami Rosen @ 2019-04-17 15:26 UTC (permalink / raw)
  To: zhang,yan; +Cc: dts

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Hi Zhang,
Two minor comments about the patch subject and the commit message:

disable promise mode-> disable promisc mode

 so use command "set promisc all off" to forbidden them->
 so use command "set promisc all off" to forbid them

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 660 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-17 15:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17  9:27 [dts] [PATCH V1] tests/vf_jumboframe:disable promise mode to forbid misc packets zhang,yan
2019-04-17 15:26 ` Rami Rosen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).