Re: [dts] [PATCH] add new ipsec lib test scripts

[Rami Rosen <ramirose@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3650 bytes --]

Hi, xuyanjie,
Few minor coments:

  should has -> should have:

+        # Generally, testbed should has 4 ports NIC, like,
> +        # 03:00.0 03:00.1 03:00.2 03:00.3
> +        # This test case will
> +        # - physical link is 03:00.0 <-> 03:00.1 and 03:00.2 <-> 03:00.3
> +        # - bind 03:00.0 and 03:00.2 to ipsec-secgw app
> +        # - send test packet from 03:00.3
> +        # - receive packet which forwarded by ipsec-secgw from 03:00.0
>

Should be dts ports.cfg
See: http://git.dpdk.org/tools/dts/tree/conf/ports.cfg

+        # - configure port and peer in dts port.cfg
> +        self.tx_port = self.tester.get_local_port(self.dut_ports[1])
> +        self.rx_port = self.tester.get_local_port(self.dut_ports[0])
> +
> +        self.tx_interface = self.tester.get_interface(self.tx_port)
> +        self.rx_interface = self.tester.get_interface(self.rx_port)
> +
> +        self.logger.info("tx interface = " + self.tx_interface)
> +        self.logger.info("rx interface = " + self.rx_interface)
> +
> +        self._app_path = "./examples/ipsec-secgw/build/ipsec-secgw"
> +        if not cc.is_build_skip(self):
> +            cc.build_dpdk_with_cryptodev(self)
> +        cc.bind_qat_device(self)
> +
> +        self._default_ipsec_gw_opts = {
> +            "config": None,
> +            "P": "",
> +            "p": "0x3",
> +            "f": "local_conf/ipsec_test.cfg",
> +            "u": "0x1"
> +        }
> +
> +        self._pcap_idx = 0
> +        self.pcap_filename = ''
> +
> +    def set_up(self):
> +        pass
> +
> +    def tear_down(self):
> +        self.dut.kill_all()
> +
> +    def tear_down_all(self):
> +        cc.clear_dpdk_config(self)
> +, "FAIL")
> +
>
...
...

>
+    def test_tun_qat_aes_gcm_ipv4(self):
> +        if cc.is_test_skip(self):
> +            return
> +
> +        result = True
> +
> +        self.logger.info("Test tun_qat_aes_gcm_ipv4")
> +        self.pcap_filename = "test_tun_qat_aes_gcm_ipv4"
> +        ipsec_gw_opt_str = self._get_ipsec_gw_opt_str()
> +        self.logger.debug(ipsec_gw_opt_str)
> +
> +        result = self._execute_ipsec_gw_test(ipsec_gw_opt_str)
> +        self.verify(result, "FAIL")
> +
> +    def test_tun_qat_aes_128_ctr_ipv4(self):
> +        if cc.is_test_skip(self):
> +            return
> +
> +        result = True
> +
> +        self.logger.info("Test tun_qat_aes_128_ctr_ipv4")
> +        self.pcap_filename = "test_tun_qat_aes_128_ctr_ipv4"
> +        ipsec_gw_opt_str = self._get_ipsec_gw_opt_str()
> +        self.logger.debug(ipsec_gw_opt_str)
> +
> +        result = self._execute_ipsec_gw_test(ipsec_gw_opt_str)
> +        self.verify(result, "FAIL")
> +
> +    def test_tun_qat_aes_128_ctr_ipv6(self):
> +        if cc.is_test_skip(self):
> +            return
> +
> +        result = True
> +
> +        self.logger.info("Test tun_qat_aes_128_ctr_ipv6")
> +        self.pcap_filename = "test_tun_qat_aes_128_ctr_ipv6"
> +        ipsec_gw_opt_str = self._get_ipsec_gw_opt_str()
> +        self.logger.debug(ipsec_gw_opt_str)
> +
> +        result = self._execute_ipsec_gw_test(ipsec_gw_opt_str)
> +        self.verify(result, "FAIL")
> +
> +    def test_qat_aes_128_ctr_ipv4_transport(self):
> +        if cc.is_test_skip(self):
> +            return
> +
> +        result = True
> +
>

Should be:
              self.logger.info("Test trs_qat_aes_128_ctr_ipv4_transport")

+        self.logger.info("Test trs_qat_aes_128_ctr_ipv4")
> +        self.pcap_filename = "test_trs_qat_aes_128_ctr_ipv4"
> +        ipsec_gw_opt_str = self._get_ipsec_gw_opt_str()
> +        self.logger.debug(ipsec_gw_opt_str)
> +
>

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 6764 bytes --]