test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it
@ 2021-01-06  6:52 Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Xie wei @ 2021-01-06  6:52 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.

Xie wei (2):
  tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet
    size
  tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes

 tests/TestSuite_veb_switch.py    | 3 +--
 tests/TestSuite_vf_jumboframe.py | 4 +---
 2 files changed, 2 insertions(+), 5 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
@ 2021-01-06  6:52 ` Xie wei
  2021-01-07  5:16   ` Tu, Lijuan
  2021-01-06  6:52 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes Xie wei
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Xie wei @ 2021-01-06  6:52 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.
After testing, found that:
when send a packet which length is 1513 bytes.
for iavf driver; the statistic from "show port stats 0" is: RX-bytes: 1513
for i40evf driver; the statistic from "show port stats 0" is: RX-bytes: 1517

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index 6da2c5e5..75480f1f 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -219,10 +219,8 @@ class TestVfJumboFrame(TestCase):
         if received:
             self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error")
 
-            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
+            if self.kdriver in ["ixgbe", "ice", "i40e"]:
                 self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
-            else:
-                self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size")
 
             if self.kdriver == "igb":
                 self.verify(tx_bytes == pktsize, "Tx packet size should be packet size")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
@ 2021-01-06  6:52 ` Xie wei
  2021-01-06  6:58 ` [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie, WeiX
  2021-01-06  7:30 ` Zhao, HaiyangX
  3 siblings, 0 replies; 6+ messages in thread
From: Xie wei @ 2021-01-06  6:52 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.
After testing, found that:
when send a packet which length is 60 bytes.
for iavf driver; the statistic from "show port stats 0" is: RX-bytes:56,
but set verbose 1, we can see the packet length is 60.
for i40evf driver; the statistic from "show port stats 0" is: RX-bytes: 60

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_veb_switch.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_veb_switch.py b/tests/TestSuite_veb_switch.py
index 00dd76e7..915296ff 100644
--- a/tests/TestSuite_veb_switch.py
+++ b/tests/TestSuite_veb_switch.py
@@ -286,8 +286,7 @@ class TestVEBSwitching(TestCase):
 
         vf0_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
         vf1_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
-        if self.kdriver == 'ice':
-            vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
+        vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
         self.verify(vf0_tx_stats[0] != 0, "no packet was sent by VF0")
         self.verify(vf0_tx_stats == vf1_rx_stats, "VF1 failed to receive packets from VF0")
     
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes Xie wei
@ 2021-01-06  6:58 ` Xie, WeiX
  2021-01-06  7:30 ` Zhao, HaiyangX
  3 siblings, 0 replies; 6+ messages in thread
From: Xie, WeiX @ 2021-01-06  6:58 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Wednesday, January 6, 2021 2:53 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V1 0/2] DTS framework has switched i40evf to iavf, so
> align with it

[-- Attachment #2: TestVEBSwitching.log --]
[-- Type: application/octet-stream, Size: 6637 bytes --]

[-- Attachment #3: TestVfJumboFrame.log --]
[-- Type: application/octet-stream, Size: 53736 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
                   ` (2 preceding siblings ...)
  2021-01-06  6:58 ` [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie, WeiX
@ 2021-01-06  7:30 ` Zhao, HaiyangX
  3 siblings, 0 replies; 6+ messages in thread
From: Zhao, HaiyangX @ 2021-01-06  7:30 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Best Regards,
Zhao Haiyang

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: Wednesday, January 6, 2021 14:53
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so
> align with it


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
@ 2021-01-07  5:16   ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2021-01-07  5:16 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> DTS framework has switched i40evf to iavf, so align with it.
> After testing, found that:
> when send a packet which length is 1513 bytes.
> for iavf driver; the statistic from "show port stats 0" is: RX-bytes: 1513 for
> i40evf driver; the statistic from "show port stats 0" is: RX-bytes: 1517
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_vf_jumboframe.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_jumboframe.py
> b/tests/TestSuite_vf_jumboframe.py
> index 6da2c5e5..75480f1f 100644
> --- a/tests/TestSuite_vf_jumboframe.py
> +++ b/tests/TestSuite_vf_jumboframe.py
> @@ -219,10 +219,8 @@ class TestVfJumboFrame(TestCase):
>          if received:
>              self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert
> error")
> 
> -            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
> +            if self.kdriver in ["ixgbe", "ice", "i40e"]:
>                  self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be
> packet size - 4")
> -            else:
> -                self.verify(rx_bytes == pktsize, "Rx packet size should be equal to
> packet size")

If not matched the if condition, miss verification, so there is a gap, thanks.

> 
>              if self.kdriver == "igb":
>                  self.verify(tx_bytes == pktsize, "Tx packet size should be packet
> size")
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-07  5:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
2021-01-07  5:16   ` Tu, Lijuan
2021-01-06  6:52 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes Xie wei
2021-01-06  6:58 ` [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie, WeiX
2021-01-06  7:30 ` Zhao, HaiyangX

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git