From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Chautru, Nicolas" <nicolas.chautru@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Vargas, Hernan" <hernan.vargas@intel.com>
Subject: Re: [PATCH v1 0/3] bbdev: remove offload cost
Date: Thu, 5 Jan 2023 10:53:44 +0100 [thread overview]
Message-ID: <e2e5f574-c465-4d64-f49e-5f70e9704427@redhat.com> (raw)
In-Reply-To: <BY5PR11MB44514BFA9D7B8CCA668CBE5BF8F59@BY5PR11MB4451.namprd11.prod.outlook.com>
Hi Nicolas,
On 1/4/23 19:01, Chautru, Nicolas wrote:
> Hi Maxime,
>
> I don’t see them on the baseband tree dpdk-next-baseband
>
> I did a clean clone, these are the last 3 commits
> dc0a5a0d2a (HEAD -> for-main, origin/for-main) test/bbdev: explicit check for allocation failure
> 0e927787a3 test/bbdev: fix build issue with optional build flag
> 51d49ccd23 test/bbdev: fix build issue with optional build flag
>
> I don’t see the last 3 commits from patchwork (ie. the serie from that email)
> [v1,3/3] app/bbdev-test: remove offload cost optional build flag bbdev: remove offload cost - - - 3-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream
> [v1,2/3] drivers/baseband: remove offload cost optional build flag bbdev: remove offload cost - - - 1-- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream
> [v1,1/3] test/bbdev: explicit check for allocation failure bbdev: remove offload cost - - - 11- 2022-12-14 Chautru, Nicolas mcoquelin Awaiting Upstream
> [v3,3/3] test/bbdev: explicit check for allocation failure test/bbdev: fix build issues with optional build flag - 1 - 10-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream
> [v3,2/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 1-- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream
> [v3,1/3] test/bbdev: fix build issue with optional build flag test/bbdev: fix build issues with optional build flag - 1 - 11- 2022-12-13 Chautru, Nicolas mcoquelin Awaiting Upstream
>
> Do I miss something? This last serie doesn’t look applied on the remote repo. Could you double check?
Hmm OK, I think I got mislead by the similarity of the commit titles
between the two series when I changed the state of the first series.
I'm reverting back the state of this series from "Awaiting upstream" to
"New" since I have not reviewed this one yet. I'll try to review it
before end of week.
Thanks for the heads-up!
Maxime
> Thanks
> Nic
>
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Wednesday, January 4, 2023 4:43 AM
>> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org
>> Cc: Vargas, Hernan <hernan.vargas@intel.com>
>> Subject: Re: [PATCH v1 0/3] bbdev: remove offload cost
>>
>> Hi Nicolas,
>>
>> On 1/3/23 23:07, Chautru, Nicolas wrote:
>>> Hi Maxime,
>>>
>>> Happy new year.
>>
>> Happy new year.
>>
>>> What does the state " Awaiting Upstream" mean in patchwork for that
>> serie? Can this be applied?
>>
>> It means it is the the bbdev tree, and is awaiting being pulled into the main
>> tree.
>>
>> So it is applied, but only in the bbdev tree for now.
>> This should not be an issue since you shold base your work on top of the
>> bbdev tree.
>>
>> Regards,
>> Maxime
>>
>>> Thanks
>>> Nic
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: Chautru, Nicolas <nicolas.chautru@intel.com>
>>>> Sent: Wednesday, December 14, 2022 3:34 PM
>>>> To: dev@dpdk.org; maxime.coquelin@redhat.com
>>>> Cc: Vargas, Hernan <hernan.vargas@intel.com>; Chautru, Nicolas
>>>> <nicolas.chautru@intel.com>
>>>> Subject: [PATCH v1 0/3] bbdev: remove offload cost
>>>>
>>>> Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel
>>>> baseband PMDs and bbdev-test application.
>>>> This helps to simplify build variants complexity causing compilation
>>>> issues to be missed.
>>>>
>>>> Maxime, the first commit is actually a miss related to last commit on
>>>> top of tree, you may want to merge these two commits together in the
>> history.
>>>> Sorry for missing it earlier.
>>>>
>>>>
>>>> Nicolas Chautru (3):
>>>> test/bbdev: explicit check for allocation failure
>>>> drivers/baseband: remove offload cost optional build flag
>>>> app/bbdev-test: remove offload cost optional build flag
>>>>
>>>> app/test-bbdev/test_bbdev_perf.c | 29 +-------
>>>> drivers/baseband/acc/acc_common.h | 12 +---
>>>> drivers/baseband/acc/rte_acc100_pmd.c | 2 -
>>>> drivers/baseband/acc/rte_acc200_pmd.c | 2 -
>>>> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 ---
>>>> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 10 ---
>>>> .../baseband/turbo_sw/bbdev_turbo_software.c | 70 ++++---------------
>>>> 7 files changed, 17 insertions(+), 118 deletions(-)
>>>>
>>>> --
>>>> 2.34.1
>>>
>
next prev parent reply other threads:[~2023-01-05 9:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 23:33 Nicolas Chautru
2022-12-14 23:33 ` [PATCH v1 1/3] test/bbdev: explicit check for allocation failure Nicolas Chautru
2023-01-06 14:51 ` Maxime Coquelin
2023-01-06 15:37 ` Chautru, Nicolas
2023-01-10 8:32 ` Maxime Coquelin
2022-12-14 23:33 ` [PATCH v1 2/3] drivers/baseband: remove offload cost optional build flag Nicolas Chautru
2023-01-06 14:54 ` Maxime Coquelin
2022-12-14 23:33 ` [PATCH v1 3/3] app/bbdev-test: " Nicolas Chautru
2023-01-06 14:55 ` Maxime Coquelin
2023-01-03 22:07 ` [PATCH v1 0/3] bbdev: remove offload cost Chautru, Nicolas
2023-01-04 12:42 ` Maxime Coquelin
2023-01-04 18:01 ` Chautru, Nicolas
2023-01-05 9:53 ` Maxime Coquelin [this message]
2023-01-10 8:43 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e5f574-c465-4d64-f49e-5f70e9704427@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).