From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, mvarlese@suse.de
Subject: Re: [dpdk-dev] [PATCH 2/2] mk: clean up static link with DPAA libraries
Date: Fri, 23 Feb 2018 15:32:55 +0530 [thread overview]
Message-ID: <fbafdeaa-8851-2f46-3bd3-790b55f6d7f0@nxp.com> (raw)
In-Reply-To: <1759755.H60iFR18bq@xps>
On 2/23/2018 2:55 PM, Thomas Monjalon wrote:
> 23/02/2018 07:25, Hemant Agrawal:
>> Hi Thomas,
>> On 2/23/2018 4:23 AM, Thomas Monjalon wrote:
>>> The bus and mempool dependencies should be declared after the PMD
>>> libraries needing them.
>>>
>>> Moreover there is no need to disable the PMDs at the Makefile level,
>>> in case the dependencies are not met.
>>> Such dependencies should be handled at configuration time.
>>>
>>> The other side effect of this clean-up is to take into account
>>> the mempool option CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL.
>>>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>> mk/rte.app.mk | 20 ++++----------------
>>> 1 file changed, 4 insertions(+), 16 deletions(-)
>>
>> This patch looks good, however I think we (NXP) need to also set some
>> dependency check in makefile to avoid dpaaX PMD compilations, if bus is
>> not available. I am working on a patch for the same.
>
> Why do you think such check is necessary?
> If the PMD is enable but not the bus, it is a configuration error.
> A good configuration system would resolve it automatically,
> but currently we do the configuration manually, so the user must fix
> its configuration file.
>
I agree with your comment. That is the ideal approach.
However, just to make it convenient and to support cases like VFIO
disable, I have added few checks in my v2.
next prev parent reply other threads:[~2018-02-23 10:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 14:23 [dpdk-dev] DPDK 18.02 on ARM64 is broken Marco Varlese
2018-02-22 14:33 ` Gaëtan Rivet
2018-02-22 17:28 ` Hemant Agrawal
2018-02-22 20:00 ` Marco Varlese
2018-02-22 22:53 ` [dpdk-dev] [PATCH 1/2] app/testpmd: fix DPAA shared library dependency Thomas Monjalon
2018-02-22 22:53 ` [dpdk-dev] [PATCH 2/2] mk: clean up static link with DPAA libraries Thomas Monjalon
2018-02-23 6:25 ` Hemant Agrawal
2018-02-23 9:25 ` Thomas Monjalon
2018-02-23 10:02 ` Hemant Agrawal [this message]
2018-02-23 5:15 ` [dpdk-dev] [PATCH 1/2] app/testpmd: fix DPAA shared library dependency Hemant Agrawal
2018-02-23 9:58 ` [dpdk-dev] [PATCH v2 " Hemant Agrawal
2018-02-23 9:58 ` [dpdk-dev] [PATCH v2 2/2] mk: fix the build dependency structure for dpaaX Hemant Agrawal
2018-03-13 23:36 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbafdeaa-8851-2f46-3bd3-790b55f6d7f0@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=mvarlese@suse.de \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).