Soft Patch Panel
 help / color / mirror / Atom feed
From: ogawa.yasufumi@lab.ntt.co.jp
To: spp@dpdk.org, ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Subject: [spp] [PATCH 6/6] shared/sec: rename func for parsing lcore ID
Date: Tue, 21 May 2019 11:31:22 +0900	[thread overview]
Message-ID: <1558405882-8201-7-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> (raw)
In-Reply-To: <1558405882-8201-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

This update is to rename `decode_core_value()` to `parse_lcore_id()`
which is not for decoding but parsing.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/shared/secondary/spp_worker_th/cmd_parser.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/shared/secondary/spp_worker_th/cmd_parser.c b/src/shared/secondary/spp_worker_th/cmd_parser.c
index e0da244..84e5b55 100644
--- a/src/shared/secondary/spp_worker_th/cmd_parser.c
+++ b/src/shared/secondary/spp_worker_th/cmd_parser.c
@@ -278,18 +278,17 @@ parse_port_uid(void *output, const char *arg_val)
 	return SPP_RET_OK;
 }
 
-/* decoding procedure of core */
+/* Parse given lcore ID. */
 static int
-decode_core_value(void *output, const char *arg_val)
+parse_lcore_id(void *output, const char *arg_val)
 {
-	int ret = SPP_RET_OK;
+	int ret;
 	ret = get_uint_in_range(output, arg_val, 0, RTE_MAX_LCORE-1);
 	if (unlikely(ret < 0)) {
-		RTE_LOG(ERR, SPP_COMMAND_PROC, "Bad core id. val=%s\n",
-				arg_val);
+		RTE_LOG(ERR, SPP_COMMAND_PROC,
+				"Invalid lcore id '%s'.\n", arg_val);
 		return SPP_RET_NG;
 	}
-
 	return SPP_RET_OK;
 }
 
@@ -356,7 +355,7 @@ decode_component_core_value(void *output, const char *arg_val,
 	if (component->wk_action != SPPWK_ACT_START)
 		return SPP_RET_OK;
 
-	return decode_core_value(&component->core, arg_val);
+	return parse_lcore_id(&component->core, arg_val);
 }
 
 /* decoding procedure of type for component command */
-- 
2.17.1


      parent reply	other threads:[~2019-05-21  2:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  2:31 [spp] [PATCH 0/6] Refactor parsing resource UID ogawa.yasufumi
2019-05-21  2:31 ` [spp] [PATCH 1/6] shared/sec: refactor func for getting VLAN ID ogawa.yasufumi
2019-05-21  2:31 ` [spp] [PATCH 2/6] shared/sec: rename misspelled get_arrary_index ogawa.yasufumi
2019-05-21  2:31 ` [spp] [PATCH 3/6] shared/sec: remove misunderstandable validate func ogawa.yasufumi
2019-05-21  2:31 ` [spp] [PATCH 4/6] shared/sec: rename func for parsing port UID ogawa.yasufumi
2019-05-21  2:31 ` [spp] [PATCH 5/6] shared/sec: fix funcs for getting int and uint ogawa.yasufumi
2019-05-21  2:31 ` ogawa.yasufumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558405882-8201-7-git-send-email-ogawa.yasufumi@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).