Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 7/2/2019 6:56 PM, Ferruh Yigit wrote:
> On 6/12/2019 2:04 AM, Zhao1, Wei wrote:
>>
>>
>>> -----Original Message-----
>>> From: Yigit, Ferruh
>>> Sent: Tuesday, June 11, 2019 10:42 PM
>>> To: Zhao1, Wei <wei.zhao1@intel.com>; Kevin Traynor
>>> <ktraynor@redhat.com>; dev@dpdk.org
>>> Cc: stable@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error
>>>
>>> On 6/11/2019 2:28 AM, Zhao1, Wei wrote:
>>>> Hi,  Kevin Traynor
>>>> 	This patch is based on Yigit Ferruh's suggestion in the following mail.
>>>> https://mails.dpdk.org/archives/dev/2019-May/132178.html
>>>> If we take your propose, it means we do need any patch at all.
>>>> Because the code implement now is just that scheme, we will do "or" for
>>> offloads.
>>>> Hello Ferruh,What is your comment?
>>>
>>> My comment was if the user not set the queue offload use the default one, so I
>>> think we don't need to track individual offload options.
>>>
>>> But also there is slightly difference between user not set the value and
>>> 'offloads' being zero. What if user set the offloads value to '0' to disable all
>>> offloads, it will use default values in this case.
>>>
>>
>> Yes, we can not distinguish between not set the value and using 0 to disable it, so if the bit is 0 how can we 
>> Know the actual purpose of users?  I think it is hard track individual offload as Kevin Traynor said.
> 
> Yes it is hard to track, and I believe this is better than the existing code, so:
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Applied to dpdk-next-net/master, thanks.