Re: [dpdk-stable] [PATCH v7 4/7] vhost: fix NUMA reallocation with multiqueue

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 6/30/21 9:24 AM, David Marchand wrote:
> On Tue, Jun 29, 2021 at 6:11 PM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> Since the Vhost-user device initialization has been reworked,
>> enabling the application to start using the device as soon as
>> the first queue pair is ready, NUMA reallocation no more
>> happened on queue pairs other than the first one since
>> numa_realloc() was returning early if the device was running.
>>
>> This patch fixes this issue by only preventing the device
>> metadata to be allocated if the device is running. For the
> 
> Hum, I understand the meaning, but I think we could make it easier to read:
> 
> This patch fixes this issue by reallocating the device metadata only
> if the device is not running.
> 
> WDYT?

It sounds better, I can be changed while applying if only issue.

>> virtqueues, a vring state change notification is sent to
>> notify the application of its disablement. Since the callback
>> is supposed to be blocking, it is safe to reallocate it
>> afterwards.
> 
>