[dpdk-stable] [PATCH] Add accumulated list of missing patches to release announce

[dpdk-stable] [PATCH] Add accumulated list of missing patches to release announce

[Yongseok Koh]

Stable maintainers sholud keep an accumulated list of missing patches. And
this will be notified in the release announce.

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 6-announce-release | 21 +++++++++++++++++++++
 README             | 13 ++++++++-----
 2 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/6-announce-release b/6-announce-release
index 4cd5b05..619065c 100755
--- a/6-announce-release
+++ b/6-announce-release
@@ -2,6 +2,14 @@
 
 source ./lib.sh
 
+if [ $# -lt 1 ] || [ ! -f "$1" ]
+then
+	echo "Usage: $0 failed_list"
+	exit 1
+fi
+failed_list="/tmp/.list-$$"
+grep -v "^#" $1 > $failed_list
+
 get_diffs()
 {
 	$GIT diff v${last_release}..v${stable_release} --stat
@@ -35,3 +43,16 @@ EOF
 }
 
 compose_release_note
+
+cat << EOF
+---[ List of missing patches ]---
+The following is the accumulated list of skipped patches. Authors/maintainers
+have not yet responded to backport requests. Actions to take per each patch,
+
+	a) say "it is not relevant to ${RTE_VER_MAJOR}"
+	b) send out a backport to stable@dpdk.org
+
+EOF
+while read commit patch; do
+	describe_commit $commit
+done < $failed_list | sort -k 2
diff --git a/README b/README
index fc1bc5d..25f09d5 100644
--- a/README
+++ b/README
@@ -88,10 +88,12 @@ base could have been changed that it needs a manual backport.
 
 The usage is:
 
-    $ 3-request-backport failed-list
-
-Where, the failed-list is generated from "1-import".
+    $ 3-request-backport accumulated-failed-list
 
+A failed-list for a release is generated from "1-import" but maintainer
+should keep an accumulated list for the stable tree and send out this
+request multiple times with the accumulated list of failed patches. This
+list will also be used by "6-announce-release".
 
 4-final-review
 ==============
@@ -158,8 +160,9 @@ and finally suggest that change to the web team at web@dpdk.org
 6-announce-release
 
 The last step is to announce it. The usage is also simpler: just type the
-command without any options. Again, it will generate a email, and you have
-to edit it (since it's way too short and simple so far :).
+command with the accumulated failed list mentioned in "3-request-backport".
+Again, it will generate an email, and you have to edit it (since it's way
+too short and simple so far :).
 
 
 That's all.
-- 
2.11.0

Re: [dpdk-stable] [PATCH] Add accumulated list of missing patches to release announce

[Luca Boccassi]

On Fri, 2019-01-18 at 16:31 -0800, Yongseok Koh wrote:
> Stable maintainers sholud keep an accumulated list of missing
> patches. And
> this will be notified in the release announce.
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>  6-announce-release | 21 +++++++++++++++++++++
>  README             | 13 ++++++++-----
>  2 files changed, 29 insertions(+), 5 deletions(-)
> 
> diff --git a/6-announce-release b/6-announce-release
> index 4cd5b05..619065c 100755
> --- a/6-announce-release
> +++ b/6-announce-release
> @@ -2,6 +2,14 @@
>  
>  source ./lib.sh
>  
> +if [ $# -lt 1 ] || [ ! -f "$1" ]
> +then
> +	echo "Usage: $0 failed_list"
> +	exit 1
> +fi
> +failed_list="/tmp/.list-$$"
> +grep -v "^#" $1 > $failed_list
> +
>  get_diffs()
>  {
>  	$GIT diff v${last_release}..v${stable_release} --stat
> @@ -35,3 +43,16 @@ EOF
>  }
>  
>  compose_release_note
> +
> +cat << EOF
> +---[ List of missing patches ]---
> +The following is the accumulated list of skipped patches.
> Authors/maintainers
> +have not yet responded to backport requests. Actions to take per
> each patch,
> +
> +	a) say "it is not relevant to ${RTE_VER_MAJOR}"
> +	b) send out a backport to stable@dpdk.org
> +
> +EOF
> +while read commit patch; do
> +	describe_commit $commit
> +done < $failed_list | sort -k 2
> diff --git a/README b/README
> index fc1bc5d..25f09d5 100644
> --- a/README
> +++ b/README
> @@ -88,10 +88,12 @@ base could have been changed that it needs a
> manual backport.
>  
>  The usage is:
>  
> -    $ 3-request-backport failed-list
> -
> -Where, the failed-list is generated from "1-import".
> +    $ 3-request-backport accumulated-failed-list
>  
> +A failed-list for a release is generated from "1-import" but
> maintainer
> +should keep an accumulated list for the stable tree and send out
> this
> +request multiple times with the accumulated list of failed patches.
> This
> +list will also be used by "6-announce-release".
>  
>  4-final-review
>  ==============
> @@ -158,8 +160,9 @@ and finally suggest that change to the web team
> at web@dpdk.org
>  6-announce-release
>  
>  The last step is to announce it. The usage is also simpler: just
> type the
> -command without any options. Again, it will generate a email, and
> you have
> -to edit it (since it's way too short and simple so far :).
> +command with the accumulated failed list mentioned in "3-request-
> backport".
> +Again, it will generate an email, and you have to edit it (since
> it's way
> +too short and simple so far :).
>  
>  
>  That's all.

Acked-by: Luca Boccassi <bluca@debian.org>

Applied, thanks

-- 
Kind regards,
Luca Boccassi