* [dpdk-stable] [PATCH] compress/isal: fix compression stream initialization
@ 2019-03-26 9:42 Tomasz Cel
2019-03-27 11:35 ` Daly, Lee
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Tomasz Cel @ 2019-03-26 9:42 UTC (permalink / raw)
To: dev; +Cc: stable, fiona.trahe, lee.daly, greg.b.tucker, tomaszx.jozwiak
This patch fixes ISAL internal state fields initialization.
Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
---
drivers/compress/isal/isal_compress_pmd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index 8879a42..1e518b3 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
uint8_t *temp_level_buf = qp->stream->level_buf;
/* Initialize compression stream */
- isal_deflate_stateless_init(qp->stream);
+ isal_deflate_init(qp->stream);
qp->stream->level_buf = temp_level_buf;
@@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
op->output_chksum = qp->stream->internal_state.crc;
}
- isal_deflate_reset(qp->stream);
-
return ret;
}
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH] compress/isal: fix compression stream initialization
2019-03-26 9:42 [dpdk-stable] [PATCH] compress/isal: fix compression stream initialization Tomasz Cel
@ 2019-03-27 11:35 ` Daly, Lee
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] This patch " Tomasz Cel
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 0/1] This patch " Tomasz Cel
2 siblings, 0 replies; 9+ messages in thread
From: Daly, Lee @ 2019-03-27 11:35 UTC (permalink / raw)
To: Cel, TomaszX, dev; +Cc: stable, Trahe, Fiona, Tucker, Greg B, Jozwiak, TomaszX
Hi Tomasz,
> -----Original Message-----
> From: Cel, TomaszX
> Sent: Tuesday, March 26, 2019 9:42 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee
> <lee.daly@intel.com>; Tucker, Greg B <greg.b.tucker@intel.com>; Jozwiak,
> TomaszX <tomaszx.jozwiak@intel.com>
> Subject: [PATCH] compress/isal: fix compression stream initialization
>
> This patch fixes ISAL internal state fields initialization.
>
> Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd.c
> b/drivers/compress/isal/isal_compress_pmd.c
> index 8879a42..1e518b3 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct
> isal_comp_qp *qp,
> uint8_t *temp_level_buf = qp->stream->level_buf;
>
> /* Initialize compression stream */
> - isal_deflate_stateless_init(qp->stream);
> + isal_deflate_init(qp->stream);
>
> qp->stream->level_buf = temp_level_buf;
>
> @@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct
> isal_comp_qp *qp,
> op->output_chksum = qp->stream->internal_state.crc;
> }
>
> - isal_deflate_reset(qp->stream);
I have tested this and it works, removing this reset function makes sense as everything cleared here is cleared in the init function anyway,
On that note, the same is to be said to isal_inflate_reset, everything cleared in reset is cleared, plus more, in isal_inflate_init.
I suggest we also remove isal_inflate_reset for commonality across both functions.
> -
> return ret;
> }
>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v2] This patch fix compression stream initialization
2019-03-26 9:42 [dpdk-stable] [PATCH] compress/isal: fix compression stream initialization Tomasz Cel
2019-03-27 11:35 ` Daly, Lee
@ 2019-03-27 17:46 ` Tomasz Cel
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] compress/isal: " Tomasz Cel
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 0/1] This patch " Tomasz Cel
2 siblings, 1 reply; 9+ messages in thread
From: Tomasz Cel @ 2019-03-27 17:46 UTC (permalink / raw)
To: dev
Cc: stable, fiona.trahe, lee.daly, greg.b.tucker, tomaszx.jozwiak,
tomaszx.cel
v2:
- removed isal_inflate_reset() function because is not neccesary,
everything is cleared by the isal_inflate_init function at the begining
Tomasz Cel (1):
compress/isal: fix compression stream initialization
drivers/compress/isal/isal_compress_pmd.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v2] compress/isal: fix compression stream initialization
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] This patch " Tomasz Cel
@ 2019-03-27 17:46 ` Tomasz Cel
0 siblings, 0 replies; 9+ messages in thread
From: Tomasz Cel @ 2019-03-27 17:46 UTC (permalink / raw)
To: dev
Cc: stable, fiona.trahe, lee.daly, greg.b.tucker, tomaszx.jozwiak,
tomaszx.cel
This patch fixes ISAL internal state fields initialization.
Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
---
drivers/compress/isal/isal_compress_pmd.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index 8879a42..ca1d703 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
uint8_t *temp_level_buf = qp->stream->level_buf;
/* Initialize compression stream */
- isal_deflate_stateless_init(qp->stream);
+ isal_deflate_init(qp->stream);
qp->stream->level_buf = temp_level_buf;
@@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
op->output_chksum = qp->stream->internal_state.crc;
}
- isal_deflate_reset(qp->stream);
-
return ret;
}
@@ -598,8 +596,6 @@ process_isal_inflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
op->produced = qp->state->total_out;
op->output_chksum = qp->state->crc;
- isal_inflate_reset(qp->state);
-
return ret;
}
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v3 0/1] This patch fix compression stream initialization
2019-03-26 9:42 [dpdk-stable] [PATCH] compress/isal: fix compression stream initialization Tomasz Cel
2019-03-27 11:35 ` Daly, Lee
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] This patch " Tomasz Cel
@ 2019-03-28 9:06 ` Tomasz Cel
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 1/1] compress/isal: " Tomasz Cel
2 siblings, 1 reply; 9+ messages in thread
From: Tomasz Cel @ 2019-03-28 9:06 UTC (permalink / raw)
To: dev
Cc: stable, fiona.trahe, lee.daly, greg.b.tucker, tomaszx.jozwiak,
tomaszx.cel
v3:
- fixed cover letter
v2:
- removed isal_inflate_reset() function because is not neccesary,
everything is cleared by the isal_inflate_init function at the begining
Tomasz Cel (1):
compress/isal: fix compression stream initialization
drivers/compress/isal/isal_compress_pmd.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v3 1/1] compress/isal: fix compression stream initialization
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 0/1] This patch " Tomasz Cel
@ 2019-03-28 9:06 ` Tomasz Cel
2019-03-28 12:58 ` Trahe, Fiona
0 siblings, 1 reply; 9+ messages in thread
From: Tomasz Cel @ 2019-03-28 9:06 UTC (permalink / raw)
To: dev
Cc: stable, fiona.trahe, lee.daly, greg.b.tucker, tomaszx.jozwiak,
tomaszx.cel
This patch fixes ISAL internal state fields initialization.
Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
---
drivers/compress/isal/isal_compress_pmd.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index 8879a42..ca1d703 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
uint8_t *temp_level_buf = qp->stream->level_buf;
/* Initialize compression stream */
- isal_deflate_stateless_init(qp->stream);
+ isal_deflate_init(qp->stream);
qp->stream->level_buf = temp_level_buf;
@@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
op->output_chksum = qp->stream->internal_state.crc;
}
- isal_deflate_reset(qp->stream);
-
return ret;
}
@@ -598,8 +596,6 @@ process_isal_inflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
op->produced = qp->state->total_out;
op->output_chksum = qp->state->crc;
- isal_inflate_reset(qp->state);
-
return ret;
}
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH v3 1/1] compress/isal: fix compression stream initialization
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 1/1] compress/isal: " Tomasz Cel
@ 2019-03-28 12:58 ` Trahe, Fiona
2019-03-28 13:23 ` Daly, Lee
0 siblings, 1 reply; 9+ messages in thread
From: Trahe, Fiona @ 2019-03-28 12:58 UTC (permalink / raw)
To: Cel, TomaszX, dev; +Cc: stable, Daly, Lee, Tucker, Greg B, Jozwiak, TomaszX
> -----Original Message-----
> From: Cel, TomaszX
> Sent: Thursday, March 28, 2019 9:06 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee <lee.daly@intel.com>; Tucker,
> Greg B <greg.b.tucker@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; Cel, TomaszX
> <tomaszx.cel@intel.com>
> Subject: [PATCH v3 1/1] compress/isal: fix compression stream initialization
>
> This patch fixes ISAL internal state fields initialization.
>
> Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH v3 1/1] compress/isal: fix compression stream initialization
2019-03-28 12:58 ` Trahe, Fiona
@ 2019-03-28 13:23 ` Daly, Lee
2019-03-29 14:20 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
0 siblings, 1 reply; 9+ messages in thread
From: Daly, Lee @ 2019-03-28 13:23 UTC (permalink / raw)
To: Trahe, Fiona, Cel, TomaszX, dev; +Cc: stable, Tucker, Greg B, Jozwiak, TomaszX
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, March 28, 2019 12:59 PM
> To: Cel, TomaszX <tomaszx.cel@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Daly, Lee <lee.daly@intel.com>; Tucker, Greg B
> <greg.b.tucker@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
> Subject: RE: [PATCH v3 1/1] compress/isal: fix compression stream
> initialization
>
>
>
> > -----Original Message-----
> > From: Cel, TomaszX
> > Sent: Thursday, March 28, 2019 9:06 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee
> > <lee.daly@intel.com>; Tucker, Greg B <greg.b.tucker@intel.com>;
> > Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; Cel, TomaszX
> > <tomaszx.cel@intel.com>
> > Subject: [PATCH v3 1/1] compress/isal: fix compression stream
> > initialization
> >
> > This patch fixes ISAL internal state fields initialization.
> >
> > Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression
> > functionality")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Lee Daly <lee.daly@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] compress/isal: fix compression stream initialization
2019-03-28 13:23 ` Daly, Lee
@ 2019-03-29 14:20 ` Akhil Goyal
0 siblings, 0 replies; 9+ messages in thread
From: Akhil Goyal @ 2019-03-29 14:20 UTC (permalink / raw)
To: Daly, Lee, Trahe, Fiona, Cel, TomaszX, dev
Cc: stable, Tucker, Greg B, Jozwiak, TomaszX
On 3/28/2019 6:53 PM, Daly, Lee wrote:
>
>> -----Original Message-----
>> From: Trahe, Fiona
>> Sent: Thursday, March 28, 2019 12:59 PM
>> To: Cel, TomaszX <tomaszx.cel@intel.com>; dev@dpdk.org
>> Cc: stable@dpdk.org; Daly, Lee <lee.daly@intel.com>; Tucker, Greg B
>> <greg.b.tucker@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
>> Subject: RE: [PATCH v3 1/1] compress/isal: fix compression stream
>> initialization
>>
>>
>>
>>> -----Original Message-----
>>> From: Cel, TomaszX
>>> Sent: Thursday, March 28, 2019 9:06 AM
>>> To: dev@dpdk.org
>>> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee
>>> <lee.daly@intel.com>; Tucker, Greg B <greg.b.tucker@intel.com>;
>>> Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; Cel, TomaszX
>>> <tomaszx.cel@intel.com>
>>> Subject: [PATCH v3 1/1] compress/isal: fix compression stream
>>> initialization
>>>
>>> This patch fixes ISAL internal state fields initialization.
>>>
>>> Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression
>>> functionality")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
>> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: Lee Daly <lee.daly@intel.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-03-29 14:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26 9:42 [dpdk-stable] [PATCH] compress/isal: fix compression stream initialization Tomasz Cel
2019-03-27 11:35 ` Daly, Lee
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] This patch " Tomasz Cel
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] compress/isal: " Tomasz Cel
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 0/1] This patch " Tomasz Cel
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 1/1] compress/isal: " Tomasz Cel
2019-03-28 12:58 ` Trahe, Fiona
2019-03-28 13:23 ` Daly, Lee
2019-03-29 14:20 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).