From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Michael Santana <msantana@redhat.com>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH] test/hash: rectify slaveid to point to valid cores
Date: Mon, 3 Jun 2019 20:43:31 +0000 [thread overview]
Message-ID: <1A80BD8E-5A81-4DB1-B2C3-834353660E9E@arm.com> (raw)
In-Reply-To: <CAJFAV8xp7XN3FGa4iU+kPYrqnPc8UiHn5gOa5KEBbed_GQQ2vg@mail.gmail.com>
> On Jun 3, 2019, at 2:31 PM, David Marchand <david.marchand@redhat.com> wrote:
>
>
> On Mon, Jun 3, 2019 at 6:57 PM Dharmik Thakkar <Dharmik.Thakkar@arm.com> wrote:
> > On Jun 1, 2019, at 10:59 AM, David Marchand <david.marchand@redhat.com> wrote:
> > I would change the Fixes: tag, fix the checkpatch warning, and send it next week.
> I am not sure about this. Do we simply go by 'git blame' or insert the commit that truly introduced the error?
>
> http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
> See the part about Fixes:.
>
> The purpose of this tag is to point at the commit that introduced an issue so that stable maintainers can catch it with scripts and backport it in the relevant branches.
Got it. Thank you!
>
>
> --
> David Marchand
next prev parent reply other threads:[~2019-06-03 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 23:27 Dharmik Thakkar
2019-06-01 15:59 ` David Marchand
2019-06-03 16:56 ` Dharmik Thakkar
2019-06-03 19:31 ` David Marchand
2019-06-03 20:43 ` Dharmik Thakkar [this message]
2019-06-05 17:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A80BD8E-5A81-4DB1-B2C3-834353660E9E@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=msantana@redhat.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).