* [dpdk-stable] [PATCH v1 2/3] examples/fips_validation: fix cmac test failure [not found] <20190411141656.27720-1-marko.kovacevic@intel.com> @ 2019-04-11 14:16 ` Marko Kovacevic 2019-04-11 14:16 ` [dpdk-stable] [PATCH v1 3/3] cryptodev: fix uninitialized session clear Marko Kovacevic [not found] ` <20190415150449.44799-1-marko.kovacevic@intel.com> 2 siblings, 0 replies; 5+ messages in thread From: Marko Kovacevic @ 2019-04-11 14:16 UTC (permalink / raw) To: dev; +Cc: john.mcnamara, xinfengx.zhao, akhil.goyal, Marko Kovacevic, stable As a result of the cmac test running the test where PT len is 65536 it should give a result back to the user USER1: Error -1: Prepare op USER1: PT len 65536 as this MSG len is not supported. Issue was that the application was not freeing the op properly after a while causing the app to fail. CRYPTODEV: rte_cryptodev_sym_session_create() line 1340: couldn't get object from session mempool USER1: Error -12: test block USER1: Error -12: Failed test CMAC/req/CMAC.req Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing") Cc: marko.kovacevic@intel.com Cc: stable@dpdk.org Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com> --- examples/fips_validation/main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 5e3d5baa8..aef45055e 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -949,19 +949,20 @@ fips_run_test(void) if (ret < 0) { RTE_LOG(ERR, USER1, "Error %i: Init session\n", ret); - return ret; + goto exit; } ret = test_ops.prepare_op(); if (ret < 0) { RTE_LOG(ERR, USER1, "Error %i: Prepare op\n", ret); - return ret; + goto exit; } if (rte_cryptodev_enqueue_burst(env.dev_id, 0, &env.op, 1) < 1) { RTE_LOG(ERR, USER1, "Error: Failed enqueue\n"); - return ret; + ret = -1; + goto exit; } do { @@ -973,6 +974,7 @@ fips_run_test(void) vec.status = env.op->status; +exit: rte_cryptodev_sym_session_clear(env.dev_id, env.sess); rte_cryptodev_sym_session_free(env.sess); env.sess = NULL; -- 2.13.6 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] [PATCH v1 3/3] cryptodev: fix uninitialized session clear [not found] <20190411141656.27720-1-marko.kovacevic@intel.com> 2019-04-11 14:16 ` [dpdk-stable] [PATCH v1 2/3] examples/fips_validation: fix cmac test failure Marko Kovacevic @ 2019-04-11 14:16 ` Marko Kovacevic [not found] ` <20190415150449.44799-1-marko.kovacevic@intel.com> 2 siblings, 0 replies; 5+ messages in thread From: Marko Kovacevic @ 2019-04-11 14:16 UTC (permalink / raw) To: dev Cc: john.mcnamara, xinfengx.zhao, akhil.goyal, Marko Kovacevic, roy.fan.zhang, stable added check to see if a session for a device has been initialised if it has return 0. Fixes: 5d6c73dd5938 ("cryptodev: add reference count to session private data") Cc: roy.fan.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com> --- lib/librte_cryptodev/rte_cryptodev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 2675e1ef7..00c2cf432 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -1386,6 +1386,8 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id, return -EINVAL; driver_id = dev->driver_id; + if (sess->sess_data[driver_id].refcnt == 0) + return 0; if (--sess->sess_data[driver_id].refcnt != 0) return -EBUSY; -- 2.13.6 ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20190415150449.44799-1-marko.kovacevic@intel.com>]
* [dpdk-stable] [PATCH v2 2/3] examples/fips_validation: fix cmac test failure [not found] ` <20190415150449.44799-1-marko.kovacevic@intel.com> @ 2019-04-15 15:04 ` Marko Kovacevic 2019-04-15 15:04 ` [dpdk-stable] [PATCH v2 3/3] cryptodev: fix uninitialized session clear Marko Kovacevic 1 sibling, 0 replies; 5+ messages in thread From: Marko Kovacevic @ 2019-04-15 15:04 UTC (permalink / raw) To: dev; +Cc: john.mcnamara, xinfengx.zhao, akhil.goyal, Marko Kovacevic, stable As a result of the cmac test running the test where PT len is 65536 it should give a result back to the user USER1: Error -1: Prepare op USER1: PT len 65536 as this MSG len is not supported. Issue was that the application was not freeing the op properly after a while causing the app to fail. CRYPTODEV: rte_cryptodev_sym_session_create() line 1340: couldn't get object from session mempool USER1: Error -12: test block USER1: Error -12: Failed test CMAC/req/CMAC.req Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing") Cc: marko.kovacevic@intel.com Cc: stable@dpdk.org Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com> --- examples/fips_validation/main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 5e3d5baa8..aef45055e 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -949,19 +949,20 @@ fips_run_test(void) if (ret < 0) { RTE_LOG(ERR, USER1, "Error %i: Init session\n", ret); - return ret; + goto exit; } ret = test_ops.prepare_op(); if (ret < 0) { RTE_LOG(ERR, USER1, "Error %i: Prepare op\n", ret); - return ret; + goto exit; } if (rte_cryptodev_enqueue_burst(env.dev_id, 0, &env.op, 1) < 1) { RTE_LOG(ERR, USER1, "Error: Failed enqueue\n"); - return ret; + ret = -1; + goto exit; } do { @@ -973,6 +974,7 @@ fips_run_test(void) vec.status = env.op->status; +exit: rte_cryptodev_sym_session_clear(env.dev_id, env.sess); rte_cryptodev_sym_session_free(env.sess); env.sess = NULL; -- 2.13.6 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] [PATCH v2 3/3] cryptodev: fix uninitialized session clear [not found] ` <20190415150449.44799-1-marko.kovacevic@intel.com> 2019-04-15 15:04 ` [dpdk-stable] [PATCH v2 2/3] examples/fips_validation: fix cmac test failure Marko Kovacevic @ 2019-04-15 15:04 ` Marko Kovacevic 2019-04-15 18:06 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona 1 sibling, 1 reply; 5+ messages in thread From: Marko Kovacevic @ 2019-04-15 15:04 UTC (permalink / raw) To: dev Cc: john.mcnamara, xinfengx.zhao, akhil.goyal, Marko Kovacevic, roy.fan.zhang, stable added check to see if a session for a device has been initialised if it has return 0. Fixes: 5d6c73dd5938 ("cryptodev: add reference count to session private data") Cc: roy.fan.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com> --- lib/librte_cryptodev/rte_cryptodev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 2675e1ef7..00c2cf432 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -1386,6 +1386,8 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id, return -EINVAL; driver_id = dev->driver_id; + if (sess->sess_data[driver_id].refcnt == 0) + return 0; if (--sess->sess_data[driver_id].refcnt != 0) return -EBUSY; -- 2.13.6 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 3/3] cryptodev: fix uninitialized session clear 2019-04-15 15:04 ` [dpdk-stable] [PATCH v2 3/3] cryptodev: fix uninitialized session clear Marko Kovacevic @ 2019-04-15 18:06 ` Trahe, Fiona 0 siblings, 0 replies; 5+ messages in thread From: Trahe, Fiona @ 2019-04-15 18:06 UTC (permalink / raw) To: Kovacevic, Marko, dev Cc: Mcnamara, John, Zhao, XinfengX, akhil.goyal, Kovacevic, Marko, Zhang, Roy Fan, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marko Kovacevic > Sent: Monday, April 15, 2019 4:05 PM > To: dev@dpdk.org > Cc: Mcnamara, John <john.mcnamara@intel.com>; Zhao, XinfengX <xinfengx.zhao@intel.com>; > akhil.goyal@nxp.com; Kovacevic, Marko <marko.kovacevic@intel.com>; Zhang, Roy Fan > <roy.fan.zhang@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/3] cryptodev: fix uninitialized session clear > > added check to see if a session for a device > has been initialised if it has return 0. > > Fixes: 5d6c73dd5938 ("cryptodev: add reference count to session private data") > Cc: roy.fan.zhang@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-15 18:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190411141656.27720-1-marko.kovacevic@intel.com>
2019-04-11 14:16 ` [dpdk-stable] [PATCH v1 2/3] examples/fips_validation: fix cmac test failure Marko Kovacevic
2019-04-11 14:16 ` [dpdk-stable] [PATCH v1 3/3] cryptodev: fix uninitialized session clear Marko Kovacevic
[not found] ` <20190415150449.44799-1-marko.kovacevic@intel.com>
2019-04-15 15:04 ` [dpdk-stable] [PATCH v2 2/3] examples/fips_validation: fix cmac test failure Marko Kovacevic
2019-04-15 15:04 ` [dpdk-stable] [PATCH v2 3/3] cryptodev: fix uninitialized session clear Marko Kovacevic
2019-04-15 18:06 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).