* [dpdk-stable] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token
[not found] ` <20191022154310.41238-1-bruce.richardson@intel.com>
@ 2019-10-22 15:43 ` Bruce Richardson
2019-10-23 10:40 ` [dpdk-stable] [dpdk-dev] " Hunt, David
0 siblings, 1 reply; 2+ messages in thread
From: Bruce Richardson @ 2019-10-22 15:43 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
Building the example with clang gives the error:
error: expression which evaluates to zero treated as a null pointer
constant of type 'const char *' [-Werror,-Wnon-literal-null-conversion]
lcore_id, UINT8);
^~~~~
This error is due to the wrong data type being given for the
cmd_set_cpu_freq_core_num value - it was specified as string rather than
numeric type.
Fixes: f5e5c3347ae3 ("examples/vm_power: cli in guest")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index fe09b0778..610d9aeac 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -171,7 +171,7 @@ cmd_set_cpu_freq_parsed(void *parsed_result, struct cmdline *cl,
cmdline_parse_token_string_t cmd_set_cpu_freq =
TOKEN_STRING_INITIALIZER(struct cmd_set_cpu_freq_result,
set_cpu_freq, "set_cpu_freq");
-cmdline_parse_token_string_t cmd_set_cpu_freq_core_num =
+cmdline_parse_token_num_t cmd_set_cpu_freq_core_num =
TOKEN_NUM_INITIALIZER(struct cmd_set_cpu_freq_result,
lcore_id, UINT8);
cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token
2019-10-22 15:43 ` [dpdk-stable] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token Bruce Richardson
@ 2019-10-23 10:40 ` Hunt, David
0 siblings, 0 replies; 2+ messages in thread
From: Hunt, David @ 2019-10-23 10:40 UTC (permalink / raw)
To: Bruce Richardson, dev; +Cc: stable
On 22/10/2019 16:43, Bruce Richardson wrote:
> Building the example with clang gives the error:
>
> error: expression which evaluates to zero treated as a null pointer
> constant of type 'const char *' [-Werror,-Wnon-literal-null-conversion]
> lcore_id, UINT8);
> ^~~~~
>
> This error is due to the wrong data type being given for the
> cmd_set_cpu_freq_core_num value - it was specified as string rather than
> numeric type.
>
> Fixes: f5e5c3347ae3 ("examples/vm_power: cli in guest")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-23 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191014113448.7442-1-bruce.richardson@intel.com>
[not found] ` <20191022154310.41238-1-bruce.richardson@intel.com>
2019-10-22 15:43 ` [dpdk-stable] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token Bruce Richardson
2019-10-23 10:40 ` [dpdk-stable] [dpdk-dev] " Hunt, David
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).